| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove references to Less_Environment::$_outputMap | mediawiki/libs/less.php | master | +6 -41 | |
| Add support for /deep/ selectors | mediawiki/libs/less.php | master | +32 -11 |
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T288498 Update less.php port to support Less.js 3.13 behaviours | |||
| Resolved | Hokwelum | T365481 Update less.php port to complete support Less.js 2.5.3 behaviours | |||
| Resolved | Hokwelum | T352862 [css-3.less test case] Add support for /deep/ selector |
Event Timeline
Comment Actions
Change 1003506 had a related patch set uploaded (by Hokwelum; author: Hokwelum):
[mediawiki/libs/less.php@master] Add support for deep Selector
Comment Actions
Change 1003506 merged by jenkins-bot:
[mediawiki/libs/less.php@master] Add support for /deep/ selectors
Comment Actions
Change 1004661 had a related patch set uploaded (by Hokwelum; author: Hokwelum):
[mediawiki/libs/less.php@master] Clean up all reference to $_outputMap
Comment Actions
Change 1004661 merged by jenkins-bot:
[mediawiki/libs/less.php@master] Remove references to Less_Environment::$_outputMap
Comment Actions
This task is supposed to fix the import-reference fixture, but this test is still failing:
--- actual +++ /Users/pmiazga/projects/wmf/less.php/test/Fixtures/lessjs-2.5.3/css/import-reference.css @@ -1,4 +1,3 @@ -@import url("import/test.css"); input[type="text"].class#id[attr=32]:not(1) { color: white; } @@ -35,8 +34,14 @@ .visible + .visible .sub { color: green; } -this isn't very valid CSS. -this isn't very valid CSS. +@supports (something: else) { + .class { + something: else; + } + .nestedToo .class { + something: else; + } +} .b { color: red; color: green; @@ -54,7 +59,7 @@ color: green; } .y { - pulled-in: yes; + pulled-in: yes /* inline comment survives */; } /* comment pulled in */ .visible { @@ -72,6 +77,20 @@ .test { color: red; } +.test:first-child { + color: blue; +} +@keyframes some-name { + property: value; +} +@supports (animation-name: test) { + @keyframes some-name { + property: value; + } + .selector { + color: red; + } +} div { this isn't very valid CSS. }
I'm reopening this ticket, after fixing the issue please remember to remove the
'import-reference' => true, // T352862
from known failing fixtures (https://gerrit.wikimedia.org/g/mediawiki/libs/less.php/+/9105597e08185b135748d9f6968d5359dbd78783/test/phpunit/FixturesTest.php#34)