Page MenuHomePhabricator

Make core classes follow PSR-4
Open, Needs TriagePublic

Description

See the parent for more info. Currently (2025-01-26) there are 32 classes in includes/*/ and 13 in includes/ itself that need to be namespaced. That's going to explode the parent so let's do that in the subticket.

List of them:

1/var/lib/mediawiki/includes/DefaultSettings.php
2/var/lib/mediawiki/includes/DevelopmentSettings.php
3/var/lib/mediawiki/includes/PHPVersionCheck.php
4/var/lib/mediawiki/includes/BootstrapHelperFunctions.php
5/var/lib/mediawiki/includes/AutoLoader.php
6/var/lib/mediawiki/includes/Setup.php
7/var/lib/mediawiki/includes/ServiceWiring.php
8/var/lib/mediawiki/includes/Defines.php
9/var/lib/mediawiki/includes/WebStart.php
10/var/lib/mediawiki/includes/SetupDynamicConfig.php
11/var/lib/mediawiki/includes/GlobalFunctions.php
12/var/lib/mediawiki/includes/MediaWiki.php
13/var/lib/mediawiki/includes/config-schema.php
14
15
16/var/lib/mediawiki/includes/Output/NoLocalSettings.php
17/var/lib/mediawiki/includes/Language/Dependency/CacheDependency.php
18/var/lib/mediawiki/includes/Language/Dependency/ConstantDependency.php
19/var/lib/mediawiki/includes/Language/Dependency/FileDependency.php
20/var/lib/mediawiki/includes/Language/Dependency/DependencyWrapper.php
21/var/lib/mediawiki/includes/Language/Dependency/MainConfigDependency.php
22/var/lib/mediawiki/includes/Language/Dependency/GlobalDependency.php
23/var/lib/mediawiki/includes/HistoryBlob/ConcatenatedGzipHistoryBlob.php
24/var/lib/mediawiki/includes/HistoryBlob/HistoryBlobStub.php
25/var/lib/mediawiki/includes/HistoryBlob/DiffHistoryBlob.php
26/var/lib/mediawiki/includes/HistoryBlob/HistoryBlobCurStub.php
27/var/lib/mediawiki/includes/HistoryBlob/HistoryBlobUtils.php
28/var/lib/mediawiki/includes/HistoryBlob/HistoryBlob.php
29/var/lib/mediawiki/includes/libs/RiffExtractor.php
30/var/lib/mediawiki/includes/libs/MWCryptHash.php
31/var/lib/mediawiki/includes/libs/XhprofData.php
32/var/lib/mediawiki/includes/libs/Deflate.php
33/var/lib/mediawiki/includes/libs/CookieJar.php
34/var/lib/mediawiki/includes/libs/MappedIterator.php
35/var/lib/mediawiki/includes/libs/StatusValue.php
36/var/lib/mediawiki/includes/libs/Cookie.php
37/var/lib/mediawiki/includes/libs/UDPTransport.php
38/var/lib/mediawiki/includes/libs/DnsSrvDiscoverer.php
39/var/lib/mediawiki/includes/libs/Mime/defines.php
40/var/lib/mediawiki/includes/libs/ObjectCache/MemoizedCallable.php
41/var/lib/mediawiki/includes/libs/ObjectCache/Utils/MemcachedClient.php
42/var/lib/mediawiki/includes/libs/Rdbms/defines.php
43/var/lib/mediawiki/includes/libs/Iterators/NotRecursiveIterator.php
44/var/lib/mediawiki/includes/libs/Iterators/IteratorDecorator.php
45/var/lib/mediawiki/includes/Shell/Result.php

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/coremaster+44 -14
mediawiki/coremaster+58 -5
mediawiki/coremaster+47 -4
mediawiki/coremaster+40 -15
mediawiki/coremaster+19 -1
mediawiki/coremaster+125 -40
mediawiki/coremaster+128 -56
mediawiki/coremaster+34 -0
mediawiki/coremaster+81 -24
mediawiki/coremaster+259 -25
mediawiki/coremaster+188 -93
mediawiki/coremaster+109 -103
mediawiki/coremaster+183 -59
mediawiki/coremaster+110 -35
mediawiki/coremaster+84 -32
mediawiki/extensions/Wikibasemaster+205 -78
mediawiki/extensions/Wikibasemaster+10 -7
mediawiki/coremaster+352 -61
mediawiki/coremaster+196 -58
mediawiki/coremaster+120 -21
mediawiki/coremaster+127 -13
mediawiki/coremaster+228 -99
mediawiki/coremaster+173 -61
mediawiki/coremaster+35 -6
mediawiki/coremaster+995 -708
mediawiki/coremaster+80 -16
mediawiki/coremaster+122 -39
mediawiki/coremaster+151 -61
mediawiki/coremaster+18 -5
mediawiki/coremaster+50 -0
mediawiki/coremaster+32 -14
mediawiki/coreREL1_45+2 -2
mediawiki/coremaster+2 -2
mediawiki/coremaster+158 -31
mediawiki/coremaster+99 -50
mediawiki/coreREL1_44+2 -2
mediawiki/tools/phan/SecurityCheckPluginmaster+174 -166
mediawiki/coremaster+237 -127
mediawiki/coremaster+159 -93
mediawiki/coremaster+126 -73
mediawiki/coremaster+375 -193
mediawiki/coremaster+509 -158
mediawiki/coremaster+248 -122
mediawiki/coremaster+494 -249
mediawiki/coremaster+212 -29
mediawiki/coremaster+435 -136
mediawiki/coremaster+287 -157
mediawiki/coremaster+57 -0
mediawiki/coremaster+1 -1
mediawiki/coremaster+435 -241
mediawiki/coremaster+136 -33
mediawiki/coremaster+356 -37
mediawiki/coremaster+138 -46
mediawiki/coremaster+115 -49
mediawiki/coremaster+33 -6
mediawiki/coremaster+142 -89
mediawiki/coremaster+1 K -294
mediawiki/coremaster+210 -137
mediawiki/coremaster+140 -105
mediawiki/coremaster+191 -38
mediawiki/coremaster+28 -5
mediawiki/coremaster+59 -29
mediawiki/coremaster+526 -153
mediawiki/coremaster+23 -5
mediawiki/coremaster+59 -23
mediawiki/coremaster+51 -26
mediawiki/coremaster+57 -0
mediawiki/coremaster+1 -0
mediawiki/coremaster+45 -6
mediawiki/coremaster+18 -8
mediawiki/coremaster+25 -11
mediawiki/coremaster+32 -11
mediawiki/coremaster+19 -8
mediawiki/coremaster+33 -11
mediawiki/coremaster+6 -1
mediawiki/coremaster+13 -6
mediawiki/coremaster+10 -5
mediawiki/coremaster+29 -11
mediawiki/coremaster+75 -40
mediawiki/coremaster+10 -5
mediawiki/coremaster+12 -3
mediawiki/coremaster+65 -13
mediawiki/coremaster+14 -3
mediawiki/coremaster+6 -1
mediawiki/coremaster+17 -5
mediawiki/coremaster+126 -64
mediawiki/coremaster+302 -139
mediawiki/coremaster+18 -7
mediawiki/coremaster+24 -10
mediawiki/coremaster+8 -1
mediawiki/coremaster+7 -1
mediawiki/coremaster+16 -6
mediawiki/coremaster+12 -3
mediawiki/coremaster+10 -5
mediawiki/coremaster+25 -11
mediawiki/coremaster+24 -4
mediawiki/coremaster+19 -6
mediawiki/coremaster+10 -3
mediawiki/coremaster+11 -0
mediawiki/coremaster+13 -2
mediawiki/coremaster+84 -36
mediawiki/coremaster+104 -73
mediawiki/coremaster+18 -4
mediawiki/coremaster+34 -9
mediawiki/coremaster+176 -71
mediawiki/coremaster+101 -82
mediawiki/coremaster+676 -161
mediawiki/coremaster+450 -153
mediawiki/coremaster+14 -1
mediawiki/coremaster+2 -0
mediawiki/coremaster+5 -14
mediawiki/coremaster+7 -3
mediawiki/coremaster+79 -15
mediawiki/coremaster+162 -124
mediawiki/coremaster+139 -38
mediawiki/coremaster+118 -22
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change #1130188 merged by jenkins-bot:

[mediawiki/core@master] Namespace all remaining files in includes/skin

https://gerrit.wikimedia.org/r/1130188

Change #1130189 merged by jenkins-bot:

[mediawiki/core@master] Namespace various singleton files

https://gerrit.wikimedia.org/r/1130189

Change #1152415 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/phan/SecurityCheckPlugin@master] Update for new Message FQSEN in MediaWiki core

https://gerrit.wikimedia.org/r/1152415

Change #1152415 merged by jenkins-bot:

[mediawiki/tools/phan/SecurityCheckPlugin@master] Update for new Message FQSEN in MediaWiki core

https://gerrit.wikimedia.org/r/1152415

Change #1166824 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_44] RELEASE-NOTES-1.44: Update entry re. namespaced class count

https://gerrit.wikimedia.org/r/1166824

Change #1166824 merged by jenkins-bot:

[mediawiki/core@REL1_44] RELEASE-NOTES-1.44: Update entry re. namespaced class count

https://gerrit.wikimedia.org/r/1166824

Change #1166873 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Namespace 12 classes in includes/collation, 2 in includes/db, and 1 in includes/debug

https://gerrit.wikimedia.org/r/1166873

Change #1203274 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Gallery: Namespace most classes

https://gerrit.wikimedia.org/r/1203274

Change #1203274 merged by jenkins-bot:

[mediawiki/core@master] Gallery: Namespace most classes

https://gerrit.wikimedia.org/r/1203274

Change #1166873 merged by jenkins-bot:

[mediawiki/core@master] Namespace 12 classes in includes/Collation, 2 in includes/DB, and 1 in includes/Debug

https://gerrit.wikimedia.org/r/1166873

Change #1204673 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] RELEASE-NOTES-1.45: Update entry re. namespaced class count

https://gerrit.wikimedia.org/r/1204673

Change #1204674 had a related patch set uploaded (by Ladsgroup; author: Jforrester):

[mediawiki/core@REL1_45] RELEASE-NOTES-1.45: Update entry re. namespaced class count

https://gerrit.wikimedia.org/r/1204674

Change #1204673 merged by jenkins-bot:

[mediawiki/core@master] RELEASE-NOTES-1.45: Update entry re. namespaced class count

https://gerrit.wikimedia.org/r/1204673

Change #1204674 merged by jenkins-bot:

[mediawiki/core@REL1_45] RELEASE-NOTES-1.45: Update entry re. namespaced class count

https://gerrit.wikimedia.org/r/1204674

Change #1209206 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Gallery: Move class ImageGalleryClassNotFoundException to namespace

https://gerrit.wikimedia.org/r/1209206

Change #1209206 merged by jenkins-bot:

[mediawiki/core@master] Gallery: Move class ImageGalleryClassNotFoundException to namespace

https://gerrit.wikimedia.org/r/1209206

Change #1209376 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] FileBackend: Move class LockManagerGroup to namespace

https://gerrit.wikimedia.org/r/1209376

Change #1212242 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Validate namespaced classes against folder structure for PSR-4

https://gerrit.wikimedia.org/r/1212242

Change #1212242 merged by jenkins-bot:

[mediawiki/core@master] tests: Validate namespaced classes against folder structure for PSR-4

https://gerrit.wikimedia.org/r/1212242

Change #1209376 abandoned by Umherirrender:

[mediawiki/core@master] FileBackend: Move class LockManagerGroup to namespace

Reason:

Needs some kind of "moving map" before starting.

https://gerrit.wikimedia.org/r/1209376

Change #1213094 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Upload: Namespace classes

https://gerrit.wikimedia.org/r/1213094

With that ^ only 8% left (298 classes: P85110)

Change #1213094 merged by jenkins-bot:

[mediawiki/core@master] Upload: Namespace classes

https://gerrit.wikimedia.org/r/1213094

Change #1213608 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] includes/libs/LockManager: namespace classes

https://gerrit.wikimedia.org/r/1213608

Change #1212625 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] tests/common: Namespace code

https://gerrit.wikimedia.org/r/1212625

Change #1212625 merged by jenkins-bot:

[mediawiki/core@master] tests/common: Namespace code

https://gerrit.wikimedia.org/r/1212625

Change #1213608 merged by jenkins-bot:

[mediawiki/core@master] includes/libs/LockManager: namespace classes

https://gerrit.wikimedia.org/r/1213608

Change #1215712 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Use namespaced TS::* enumeration instead of global TS_* constants

https://gerrit.wikimedia.org/r/1215712

Change #1215712 merged by jenkins-bot:

[mediawiki/core@master] Use namespaced TS::* enumeration instead of global TS_* constants

https://gerrit.wikimedia.org/r/1215712

Change #1217136 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Search: Namespace three classes

https://gerrit.wikimedia.org/r/1217136

Change #1217136 merged by jenkins-bot:

[mediawiki/core@master] Search: Namespace three classes

https://gerrit.wikimedia.org/r/1217136

Change #1221093 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Search: Namespace more classes

https://gerrit.wikimedia.org/r/1221093

Change #1221093 merged by jenkins-bot:

[mediawiki/core@master] Search: Namespace more classes

https://gerrit.wikimedia.org/r/1221093

Change #1222754 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Search: Namespace rest of the classes

https://gerrit.wikimedia.org/r/1222754

I wrote a python script that is obviously not great but makes this work way less terrible: P86764

Change #1222754 merged by jenkins-bot:

[mediawiki/core@master] Search: Namespace rest of the classes

https://gerrit.wikimedia.org/r/1222754

Change #1222787 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] RevisionDelete: Namespace classes

https://gerrit.wikimedia.org/r/1222787

Change #1222787 merged by jenkins-bot:

[mediawiki/core@master] RevisionDelete: Namespace classes

https://gerrit.wikimedia.org/r/1222787

Change #1222826 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Import: Namespace classes

https://gerrit.wikimedia.org/r/1222826

Change #1222826 merged by jenkins-bot:

[mediawiki/core@master] Import: Namespace classes

https://gerrit.wikimedia.org/r/1222826

Change #1223697 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Export: Namespace classes

https://gerrit.wikimedia.org/r/1223697

Change #1223697 merged by jenkins-bot:

[mediawiki/core@master] Export: Namespace classes

https://gerrit.wikimedia.org/r/1223697

Change #1224075 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Media: Namespace classes

https://gerrit.wikimedia.org/r/1224075

Change #1224196 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Wikibase@master] Use namespaced TS::* enumeration instead of global TS_* constants

https://gerrit.wikimedia.org/r/1224196

Change #1224206 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Wikibase@master] Use namespaced TS::* enumeration instead of global TS_* constants

https://gerrit.wikimedia.org/r/1224206

Change #1224075 merged by jenkins-bot:

[mediawiki/core@master] Media: Namespace classes

https://gerrit.wikimedia.org/r/1224075

Change #1224739 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Diff: Namespace classes

https://gerrit.wikimedia.org/r/1224739

Change #1224196 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] wikibase/changes: Use namespaced TS::* enumeration

https://gerrit.wikimedia.org/r/1224196

Change #1224206 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use namespaced TS::* enumeration instead of global TS_* constants

https://gerrit.wikimedia.org/r/1224206

Change #1224739 merged by jenkins-bot:

[mediawiki/core@master] Diff: Namespace classes

https://gerrit.wikimedia.org/r/1224739

Change #1225582 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] ExternalStore: Namespace classes

https://gerrit.wikimedia.org/r/1225582

Change #1225582 merged by jenkins-bot:

[mediawiki/core@master] ExternalStore: Namespace classes

https://gerrit.wikimedia.org/r/1225582

Change #1226938 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Language: Namespace language converters

https://gerrit.wikimedia.org/r/1226938

Change #1226953 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] tests: Update @covers annotations for various PSR-4-related class moves

https://gerrit.wikimedia.org/r/1226953

Change #1226938 merged by jenkins-bot:

[mediawiki/core@master] Language: Namespace language converters

https://gerrit.wikimedia.org/r/1226938

Change #1226972 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Language: Namespace classes

https://gerrit.wikimedia.org/r/1226972

Change #1226953 merged by jenkins-bot:

[mediawiki/core@master] tests: Update @covers annotations for various PSR-4-related class moves

https://gerrit.wikimedia.org/r/1226953

Change #1226972 merged by jenkins-bot:

[mediawiki/core@master] Language: Namespace classes

https://gerrit.wikimedia.org/r/1226972

Change #1227357 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Language: Namespace language classes

https://gerrit.wikimedia.org/r/1227357

Change #1227357 merged by jenkins-bot:

[mediawiki/core@master] Languages: Namespace language classes

https://gerrit.wikimedia.org/r/1227357

Change #1227999 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Profiler: Namespace classes

https://gerrit.wikimedia.org/r/1227999

Change #1227999 merged by jenkins-bot:

[mediawiki/core@master] Profiler: Namespace classes

https://gerrit.wikimedia.org/r/1227999

Change #1228558 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] Language: Namespace dependency classes

https://gerrit.wikimedia.org/r/1228558

Change #1228558 merged by jenkins-bot:

[mediawiki/core@master] Language: Namespace dependency classes

https://gerrit.wikimedia.org/r/1228558

Change #1230383 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] Profiler: Namespace output classes

https://gerrit.wikimedia.org/r/1230383

Change #1230383 merged by jenkins-bot:

[mediawiki/core@master] Profiler: Namespace output classes

https://gerrit.wikimedia.org/r/1230383

Change #1230946 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] Specials: Namespace rest of the classes

https://gerrit.wikimedia.org/r/1230946

Change #1233126 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] MediaWiki\Utils: Namespace classes

https://gerrit.wikimedia.org/r/1233126

Change #1233126 merged by jenkins-bot:

[mediawiki/core@master] MediaWiki\Utils: Namespace classes

https://gerrit.wikimedia.org/r/1233126

Change #1230946 merged by jenkins-bot:

[mediawiki/core@master] Specials: Namespace rest of the classes

https://gerrit.wikimedia.org/r/1230946

Change #1233224 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] autoload: Namespace classes

https://gerrit.wikimedia.org/r/1233224

Change #1233224 merged by jenkins-bot:

[mediawiki/core@master] autoload: Namespace classes

https://gerrit.wikimedia.org/r/1233224

Change #1233239 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] Https: Namespace classes

https://gerrit.wikimedia.org/r/1233239

Change #1233328 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] HistoryBlob: Namespace classes

https://gerrit.wikimedia.org/r/1233328

Change #1233340 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] ObjectCache: Namespace classes

https://gerrit.wikimedia.org/r/1233340

Change #1233239 merged by jenkins-bot:

[mediawiki/core@master] Http: Namespace classes

https://gerrit.wikimedia.org/r/1233239

Change #1233340 merged by jenkins-bot:

[mediawiki/core@master] ObjectCache: Namespace classes

https://gerrit.wikimedia.org/r/1233340