Page MenuHomePhabricator
Create Task
Maniphest T353458

Make core classes follow PSR-4
Open, Needs TriagePublic
Actions

Description

See the parent for more info. Currently there are ~970 classes that need to be namespaced. That's going to explode the parent so let's do that in the subticket.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT166010 The Great Namespaceization Effort
 OpenNoneT353458 Make core classes follow PSR-4

Event Timeline

Ladsgroup created this task.Dec 14 2023, 3:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2023, 3:32 PM
gerritbot added a comment.Dec 14 2023, 3:32 PM

Change 983206 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Namespace Site and SiteList

https://gerrit.wikimedia.org/r/983206

gerritbot added a project: Patch-For-Review.Dec 14 2023, 3:32 PM
Ladsgroup moved this task from Incoming to Cleanup / Tech Debt on the MediaWiki CodeJam Dec 2023 board.Dec 14 2023, 3:33 PM
Jdforrester-WMF subscribed.Dec 14 2023, 5:22 PM
gerritbot added a comment.Dec 14 2023, 5:43 PM

Change 983206 merged by jenkins-bot:

[mediawiki/core@master] Namespace Site and SiteList

https://gerrit.wikimedia.org/r/983206

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 14 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 14 2023, 6:10 PM
gerritbot added a comment.Dec 14 2023, 6:37 PM

Change 983253 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Namespace remaining files in includes/site

https://gerrit.wikimedia.org/r/983253

gerritbot added a project: Patch-For-Review.Dec 14 2023, 6:37 PM
Jdforrester-WMF added a comment.Dec 14 2023, 6:48 PM

As a quick hacky way of prioritising work, via rg -I '^use ([^\\]*);' | sort | uniq -c | sort -nr I get a reasonable hitlist (if you ignore the PHP ones):

96 use MediaWikiIntegrationTestCase;
95 use ParserOutput;
84 use MediaWikiUnitTestCase;
71 use Message;
71 use IContextSource;
70 use Language;
66 use HTMLForm;
65 use StatusValue;
63 use WikiPage;
60 use ParserOptions;
56 use Content;
52 use Skin;
42 use BagOStuff;
41 use RequestContext;
39 use MWException;
34 use WANObjectCache;
34 use Parser;
32 use File;
31 use Article;
30 use ChangeTags;
29 use Xml;
29 use RepoGroup;
27 use WikitextContent;
27 use ErrorPageError;
26 use MessageLocalizer;
26 use HtmlArmor;
26 use HashBagOStuff;
gerritbot added a comment.Dec 14 2023, 7:20 PM

Change 983256 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Namespace ParserOutput

https://gerrit.wikimedia.org/r/983256

gerritbot added a comment.Dec 15 2023, 5:43 AM

Change 983253 merged by jenkins-bot:

[mediawiki/core@master] Namespace remaining files in includes/site

https://gerrit.wikimedia.org/r/983253

pmiazga mentioned this in T353529: Add namespace to ObjectCache (BagOStuff and friends) library.Dec 15 2023, 2:49 PM
gerritbot added a comment.Dec 15 2023, 3:53 PM

Change 983442 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] PoolCounter: Namespace classes

https://gerrit.wikimedia.org/r/983442

gerritbot added a comment.Dec 15 2023, 4:17 PM

Change 983256 merged by jenkins-bot:

[mediawiki/core@master] Namespace ParserOutput

https://gerrit.wikimedia.org/r/983256

gerritbot added a comment.Dec 20 2023, 10:06 AM

Change 983442 merged by jenkins-bot:

[mediawiki/core@master] PoolCounter: Namespace classes

https://gerrit.wikimedia.org/r/983442

Maintenance_bot removed a project: Patch-For-Review.Dec 20 2023, 10:30 AM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.12; 2024-01-02); removed MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 20 2023, 11:00 AM
Reedy mentioned this in T353835: PHP Fatal Error from line 51 of /srv/mediawiki/php-1.42.0-wmf.9/includes/parser/ParserOutput.php: Cannot declare class ParserOutput, because the name is already in use.Dec 20 2023, 7:26 PM
gerritbot added a comment.Dec 21 2023, 11:16 AM

Change 984816 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] [WIP] maintenance/version: Namespace and rename

https://gerrit.wikimedia.org/r/984816

gerritbot added a project: Patch-For-Review.Dec 21 2023, 11:16 AM
gerritbot added a comment.Dec 21 2023, 1:32 PM

Change 984816 merged by jenkins-bot:

[mediawiki/core@master] maintenance/version: Namespace and rename

https://gerrit.wikimedia.org/r/984816

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2023, 2:30 PM
gerritbot added a comment.Feb 8 2024, 12:44 PM

Change 998867 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] LinkedData: Namespace PageDataRequestHandler

https://gerrit.wikimedia.org/r/998867

gerritbot added a project: Patch-For-Review.Feb 8 2024, 12:44 PM
gerritbot added a comment.Feb 8 2024, 1:57 PM

Change 998922 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] RELEASE-NOTES-1.42: Only need one copy of the User\Options namespacing

https://gerrit.wikimedia.org/r/998922

gerritbot added a comment.Feb 8 2024, 2:00 PM

Change 998925 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] RELEASE-NOTES-1.42: Add namespace note for maintenance/Version.php

https://gerrit.wikimedia.org/r/998925

gerritbot added a comment.Feb 8 2024, 2:23 PM

Change 998922 merged by jenkins-bot:

[mediawiki/core@master] RELEASE-NOTES-1.42: Only need one copy of the User\Options namespacing

https://gerrit.wikimedia.org/r/998922

gerritbot added a comment.Feb 8 2024, 2:58 PM

Change 998941 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Namespace includes/context

https://gerrit.wikimedia.org/r/998941

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.18; 2024-02-13); removed MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Feb 8 2024, 3:00 PM
gerritbot added a comment.Feb 8 2024, 3:34 PM

Change 998955 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] [WIP] Namespace HTMLForm

https://gerrit.wikimedia.org/r/998955

gerritbot added a comment.Feb 8 2024, 5:04 PM

Change 998925 merged by jenkins-bot:

[mediawiki/core@master] RELEASE-NOTES-1.42: Add namespace note for maintenance/Version.php

https://gerrit.wikimedia.org/r/998925

gerritbot added a comment.Feb 8 2024, 5:04 PM

Change 998867 merged by jenkins-bot:

[mediawiki/core@master] LinkedData: Namespace PageDataRequestHandler

https://gerrit.wikimedia.org/r/998867

gerritbot added a comment.Feb 8 2024, 6:04 PM

Change 998941 merged by jenkins-bot:

[mediawiki/core@master] Namespace includes/context

https://gerrit.wikimedia.org/r/998941

gerritbot added a comment.Feb 8 2024, 7:14 PM

Change 999057 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Namespace Message, move to appropriate directory

https://gerrit.wikimedia.org/r/999057

gerritbot added a comment.Feb 8 2024, 7:14 PM

Change 999058 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] [WIP] Namespace includes/cache

https://gerrit.wikimedia.org/r/999058

gerritbot added a comment.Feb 14 2024, 7:21 PM

Change 998955 merged by jenkins-bot:

[mediawiki/core@master] Namespace HTMLForm and friends

https://gerrit.wikimedia.org/r/998955

gerritbot added a comment.Feb 15 2024, 3:51 PM

Change 999057 merged by jenkins-bot:

[mediawiki/core@master] Namespace Message, move to appropriate directory

https://gerrit.wikimedia.org/r/999057

gerritbot added a comment.Feb 16 2024, 3:48 PM

Change 1004161 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Namespace all remaining classes in includes/parser

https://gerrit.wikimedia.org/r/1004161

gerritbot added a comment.Feb 28 2024, 3:10 PM

Change 999058 merged by jenkins-bot:

[mediawiki/core@master] Namespace includes/cache

https://gerrit.wikimedia.org/r/999058

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.21; 2024-03-05); removed MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 28 2024, 5:01 PM
gerritbot added a comment.Fri, May 3, 7:32 PM

Change #1027007 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] namespace MWDebug

https://gerrit.wikimedia.org/r/1027007

Ladsgroup added projects: MediaWiki-core-Hackathon-2024, Wikimedia-Hackathon-2024.Fri, May 3, 7:33 PM
gerritbot added a comment.Fri, May 3, 9:43 PM

Change #1027007 merged by jenkins-bot:

[mediawiki/core@master] namespace MWDebug

https://gerrit.wikimedia.org/r/1027007

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).Fri, May 3, 10:00 PM
Jdforrester-WMF moved this task from Backlog to Hacking projects on the Wikimedia-Hackathon-2024 board.Sat, May 4, 1:02 PM
gerritbot added a comment.Sat, May 4, 6:15 PM

Change #1027236 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/core@master] Add namespace and deprecation alias to DeprecationHelper

https://gerrit.wikimedia.org/r/1027236

gerritbot added a comment.Sun, May 5, 1:56 PM

Change #1027236 merged by jenkins-bot:

[mediawiki/core@master] Add namespace and deprecation alias to DeprecationHelper

https://gerrit.wikimedia.org/r/1027236

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL