Page MenuHomePhabricator
Create Task
Maniphest T353578

Some IME composition broken in all VisualEditor surfaces
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Use Visual editor to edit pages
  • Type Chinese words using Chinese IMEs
  • some words disappear / cannot choose candidates

What happens?:
When using Chinese input in Visual editor, some word that typed out disappear. When I try to choose a word by clicking number keys, the whole part I typed out disappeared.

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

螢幕錄製 2023-12-16 下午9.48.03 (1).mov3 MBDownload

Details

SubjectRepoBranchLines +/-
Update VE core submodule to wmf.9 (6bada65)mediawiki/extensions/VisualEditorwmf/1.42.0-wmf.9+1 -1
Update VE core submodule to wmf.9 (6bada65)mediawiki/extensions/VisualEditormaster+1 -1
Revert "Put zero-width space after inline focusable nodes"VisualEditor/VisualEditorwmf/1.42.0-wmf.9+10 -38
Revert "Fix English Gboard backspace over aliens"VisualEditor/VisualEditorwmf/1.42.0-wmf.9+0 -87
Update VE core submodule to master (4b3fa495f)mediawiki/extensions/VisualEditormaster+1 -1
Revert "Fix English Gboard backspace over aliens"VisualEditor/VisualEditormaster+0 -87
Revert "Put zero-width space after inline focusable nodes"VisualEditor/VisualEditormaster+10 -38
Customize query in gerrit

Related Objects

Event Timeline

Yutommy0612 created this task.Dec 16 2023, 1:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2023, 1:56 PM
Yutommy0612 added a comment.Dec 16 2023, 1:58 PM

The related video in .mp4

螢幕錄製 2023-12-16 下午9.48.03 (1) (1).mp41 MBDownload

DLynch added a project: VisualEditor-ContentLanguage.Dec 16 2023, 3:03 PM
DLynch added subscribers: dchan, DLynch.

Additional note from the video: they seem to be using desktop + macOS + Chrome.

@Yutommy0612 The video shows it happening in a table cell. Does it happen elsewhere as well, or is this table-specific?

Yutommy0612 added a comment.Dec 16 2023, 3:12 PM

even for normal paragraph it happen too

SunAfterRain subscribed.Dec 16 2023, 5:23 PM
Nardog added projects: VisualEditor-MediaWiki-2017WikitextEditor, DiscussionTools, I18n.Dec 18 2023, 2:48 AM
Nardog subscribed.

Several users have reported similar issues with VE/17WTE/DT on Japanese Wikipedia since Friday. I was able to reproduce it with Edge on Windows 11 but not with Firefox or on Android 13.

Shizhao added a project: Chinese-Sites.Dec 18 2023, 2:49 AM
Shizhao moved this task from Backlog to Extensions/Skins on the Chinese-Sites board.Dec 18 2023, 2:55 AM
Aklapper renamed this task from VisualEditor Chinese input bug to Chinese input: Some words disappear.Dec 18 2023, 12:17 PM
Syunsyunminmin subscribed.Dec 18 2023, 1:41 PM
gerritbot added a comment.Dec 18 2023, 5:22 PM

Change 983847 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Revert "Put zero-width space after inline focusable nodes"

https://gerrit.wikimedia.org/r/983847

gerritbot added a project: Patch-For-Review.Dec 18 2023, 5:22 PM

Change 983848 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Revert "Fix English Gboard backspace over aliens"

https://gerrit.wikimedia.org/r/983848

gerritbot added a comment.Dec 18 2023, 5:40 PM

Change 983847 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Revert "Put zero-width space after inline focusable nodes"

https://gerrit.wikimedia.org/r/983847

gerritbot added a comment.Dec 18 2023, 5:40 PM

Change 983848 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Revert "Fix English Gboard backspace over aliens"

https://gerrit.wikimedia.org/r/983848

gerritbot added a comment.Dec 18 2023, 5:43 PM

Change 983894 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4b3fa495f)

https://gerrit.wikimedia.org/r/983894

gerritbot added a comment.Dec 18 2023, 6:07 PM

Change 983745 had a related patch set uploaded (by DLynch; author: Esanders):

[VisualEditor/VisualEditor@wmf/1.42.0-wmf.9] Revert "Fix English Gboard backspace over aliens"

https://gerrit.wikimedia.org/r/983745

gerritbot added a comment.Dec 18 2023, 6:07 PM

Change 983906 had a related patch set uploaded (by DLynch; author: Esanders):

[VisualEditor/VisualEditor@wmf/1.42.0-wmf.9] Revert "Put zero-width space after inline focusable nodes"

https://gerrit.wikimedia.org/r/983906

gerritbot added a comment.Dec 18 2023, 6:23 PM

Change 983894 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4b3fa495f)

https://gerrit.wikimedia.org/r/983894

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 18 2023, 7:00 PM
gerritbot added a comment.Dec 18 2023, 8:26 PM

Change 983937 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to wmf.9 (6bada65)

https://gerrit.wikimedia.org/r/983937

gerritbot added a comment.Dec 18 2023, 9:09 PM

Change 983745 merged by jenkins-bot:

[VisualEditor/VisualEditor@wmf/1.42.0-wmf.9] Revert "Fix English Gboard backspace over aliens"

https://gerrit.wikimedia.org/r/983745

gerritbot added a comment.Dec 18 2023, 9:09 PM

Change 983906 merged by jenkins-bot:

[VisualEditor/VisualEditor@wmf/1.42.0-wmf.9] Revert "Put zero-width space after inline focusable nodes"

https://gerrit.wikimedia.org/r/983906

gerritbot added a comment.Dec 18 2023, 9:15 PM

Change 983911 had a related patch set uploaded (by DLynch; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.42.0-wmf.9] Update VE core submodule to wmf.9 (6bada65)

https://gerrit.wikimedia.org/r/983911

gerritbot added a comment.Dec 18 2023, 9:41 PM

Change 983937 abandoned by DLynch:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to wmf.9 (6bada65)

Reason:

Replaced by 983911

https://gerrit.wikimedia.org/r/983937

gerritbot added a comment.Dec 18 2023, 9:53 PM

Change 983911 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.42.0-wmf.9] Update VE core submodule to wmf.9 (6bada65)

https://gerrit.wikimedia.org/r/983911

Stashbot mentioned this in T330284: English Gboard causes corruption when backspacing a focusable node that ends with a Latin letter.Dec 18 2023, 9:54 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-18T21:54:05Z] <dancy@deploy2002> Started scap: Backport for [[gerrit:983745|Revert "Fix English Gboard backspace over aliens" (T353578 T325129)]], [[gerrit:983906|Revert "Put zero-width space after inline focusable nodes" (T353578 T330284)]], [[gerrit:983911|Update VE core submodule to wmf.9 (6bada65) (T353578 T330284 T325129)]]

Stashbot mentioned this in T325129: On-screen keyboard disappears when cursor encounters non-breaking space in Chrome; cannot delete nbsp in Firefox.Dec 18 2023, 9:54 PM
Stashbot added a comment.Dec 18 2023, 9:56 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-18T21:56:07Z] <dancy@deploy2002> dancy and kemayo: Backport for [[gerrit:983745|Revert "Fix English Gboard backspace over aliens" (T353578 T325129)]], [[gerrit:983906|Revert "Put zero-width space after inline focusable nodes" (T353578 T330284)]], [[gerrit:983911|Update VE core submodule to wmf.9 (6bada65) (T353578 T330284 T325129)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Dec 18 2023, 10:07 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-18T22:07:40Z] <dancy@deploy2002> Finished scap: Backport for [[gerrit:983745|Revert "Fix English Gboard backspace over aliens" (T353578 T325129)]], [[gerrit:983906|Revert "Put zero-width space after inline focusable nodes" (T353578 T330284)]], [[gerrit:983911|Update VE core submodule to wmf.9 (6bada65) (T353578 T330284 T325129)]] (duration: 13m 34s)

Maintenance_bot removed a project: Patch-For-Review.Dec 18 2023, 10:30 PM
Diskdance renamed this task from Chinese input: Some words disappear to IME composition broken in Visual Editor & DiscussionTools.Dec 19 2023, 8:12 AM
Diskdance updated the task description. (Show Details)
Diskdance subscribed.Dec 19 2023, 8:16 AM
Esanders renamed this task from IME composition broken in Visual Editor & DiscussionTools to Some IME composition broken in all VisualEditor surfaces.Dec 19 2023, 11:23 AM
Esanders removed projects: DiscussionTools, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-ContentLanguage.
Esanders subscribed.Dec 19 2023, 12:53 PM

We have backported some fixes. Can someone verify if this is fixed now?

Esanders added a comment.Dec 19 2023, 12:55 PM

Based on the reports on jawiki, it appears the backport was successful:

As of 7:30pm today, it seems to be much easier to input. (Edge,Win11) ----Little Star
Report - There seems to be no problem in my environment at the moment. Unnatural behavior when inputting on a mobile device is also gone. --Yushukasai

Diskdance added a comment.Dec 20 2023, 4:53 AM
In T353578#9415257, @Esanders wrote:

We have backported some fixes. Can someone verify if this is fixed now?

I can confirm this is fixed on my end.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL