REST HTML endpoint returning 500 for JSON page
Open, HighPublicBUG REPORT
Actions

Assigned To

None

Authored By

	daniel
	Dec 19 2023, 7:02 AM

Description

Steps to replicate the issue (include links if applicable):

Load https://ckb.wikipedia.org/w/rest.php/v1/page/%D8%AF%D8%A7%DA%95%DB%8E%DA%98%DB%95%3ACOVID-19_data%2Fdata/html

What happens?:

Get status 500

What should have happened instead?:

Get rendered content of https://ckb.wikipedia.org/w/index.php/%D8%AF%D8%A7%DA%95%DB%8E%DA%98%DB%95%3ACOVID-19_data%2Fdata, or at least dummy content per T311728.

Notes:

Note that the page in question uses the JSON content model.

Logstash

reqId: befbc706-3204-43a7-8955-bc1804b69b8b
exception.message: Failed to find content language in page bundle data

from /srv/mediawiki/php-1.42.0-wmf.20/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(614)
#0 /srv/mediawiki/php-1.42.0-wmf.20/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(629): MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getHtmlOutputContentLanguage()
#1 /srv/mediawiki/php-1.42.0-wmf.20/includes/Rest/Handler/PageHTMLHandler.php(137): MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->putHeaders(MediaWiki\Rest\Response, boolean)
#2 /srv/mediawiki/php-1.42.0-wmf.20/includes/Rest/SimpleHandler.php(40): MediaWiki\Rest\Handler\PageHTMLHandler->run(string)

Details

	Subject	Repo	Branch	Lines +/-
	HtmlOutputRendererHelper: fall back to page language	mediawiki/core	master	+83 -17

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Stalled		None	T324931 Clean up open RESTBase related tickets
In Progress		None	T262315 <CORE TECHNOLOGY> API Migration & RESTBase Sunset
Open		None	T344944 Move Parsoid endpoints out of RESTBase
Open		MSantos	T334238 Create deprecation plan for public parsoid endpoints
Open		None	T335512 Transition Enterprise MediaWiki from RESTBase to core page HTML endpoints
Open		None	T350538 Move all cache property initialization into ContentRenderer
Open	BUG REPORT	None	T353689 REST HTML endpoint returning 500 for JSON page

Event Timeline

daniel created this task.Dec 19 2023, 7:02 AM

Restricted Application added a project: Parsoid. · View Herald TranscriptDec 19 2023, 7:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

daniel updated the task description. (Show Details)Dec 19 2023, 7:03 AM

Analysis

Reproduced locally by defining a namespace that uses the JSON content model.
Full error message: "Error: exception of type InvalidArgumentException: ParserOutput does not have a render ID"
Triggered by HtmlOutputRendererHelper::getHtml by calling ParsoidOutputAccess::getParsoidRenderID
This fails, because no render ID is set, because it's not parsoid output
There is already a ticket for a related issue: T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content
Should be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/957773