Page MenuHomePhabricator

Files used in CR comments don't get listed as being used on wiki on file description pages
Closed, DeclinedPublic

Description

Files used in CR comments don't get listed as being used on wiki on file description pages


Version: unspecified
Severity: normal

Details

Reference
bz33382

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:09 AM
bzimport set Reference to bz33382.
bzimport added a subscriber: Unknown Object (MLST).

Special pages don't exactly have article ids we can stuff in imagelinks.il_from

I heard ideas for the long term to have CodeReview comments go into a LiquidThread instead (iirc the new LQT will have the ability for threads that don't have a wiki page as host), which should make this possible (assuming they are still in the thread namespace).

But then again for the other long term, we won't use CodeReview at all after the switch to Git, right ?

(In reply to comment #2)

I heard ideas for the long term to have CodeReview comments go into a
LiquidThread instead (iirc the new LQT will have the ability for threads that
don't have a wiki page as host), which should make this possible (assuming they
are still in the thread namespace).

But then again for the other long term, we won't use CodeReview at all after
the switch to Git, right ?

Indeed. I've backed off on doing CR development, features at least...

I'd consider the relationship between CodeReview and an image repo (foreign or not) to be roughly the equivalent of mywikisite.org and a foreign file repo like Wikimedia Commons. We don't (and won't) track file usage on foreign wikis. Similarly, I don't think it's necessary to track file usage in CodeReview comments. I'd recommend "wontfix" or "invalid" here.