[SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023)
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Michael
	Dec 22 2023, 5:08 PM

Description

Yesterday, our Wikibase Secondary CI on GitHub for changes merged to master broke.
It seems the immediate cause is phpunit: Deprecate suite.xml and composer phpunit:entrypoint (If2ffe052) coming from T227900: Phase out usage of tests/phpunit/suite.xml.

The last successful Wikibase Secondary CI run had

[...]
+ cd ../mediawiki
+ composer phpunit:entrypoint -- --group Wikibase
> phpunit '-c' 'tests/phpunit/suite.xml' '--group' 'Wikibase'
Using PHP 7.4.33
[...]

but the failing ones now have

[...]
+ cd ../mediawiki
+ composer phpunit:entrypoint -- --group Wikibase
> phpunit '--group' 'Wikibase'
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

Usage:
  phpunit [options] UnitTest.php
  phpunit [options] <directory>

Code Coverage Options:
[...]

Acceptance criteria

Wikibase Seconday CI is green again
email sending works again, with a somehow more robust solution
- a proper solution for this is also needed for T314987: Wikibase GitHub workflow that extracts library commits is broken (which is broken again)
- previously in this series:
  - Aug 2023 T344415: Wikibase secondary CI email sending is broken
  - Sep 2021 T291250: Wikibase Secondary CI email failing
  - Apr 2021 T280826: Secondary CI email notifications are broken

Details

	Subject	Repo	Branch	Lines +/-
	Fix secondary CI on GitHub by actually cloning MediaWiki	mediawiki/extensions/Wikibase	master	+1 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for temporary accounts
Open	None	T326908 Update WMDE Engineering-owned products that may be affected by IP Masking
Resolved	Arian_Bozorg	T351968 Update Wikidata-related extensions for IP Masking
Resolved	Lucas_Werkmeister_WMDE	T353961 Consider creating a Wikibase Secondary CI job with temporary accounts enabled
Open	None	T353957 [SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023)

Event Timeline

Michael created this task.Dec 22 2023, 5:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2023, 5:08 PM

Michael updated the task description. (Show Details)Dec 22 2023, 5:09 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 22 2023, 5:10 PM

Lucas_Werkmeister_WMDE subscribed.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 22 2023, 5:12 PM

Michael updated the task description. (Show Details)Dec 22 2023, 5:23 PM

Michael updated the task description. (Show Details)Dec 22 2023, 5:32 PM

Michael mentioned this in T353960: EntitySchema daily CI broken and emails broken.Dec 22 2023, 5:40 PM

Michael mentioned this in T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled.Dec 22 2023, 5:50 PM

Michael added a parent task: T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled.

Hmmmm I don't quite understand why PHPUnit is printing the usage and then aborting. It's definitely not the first time I'm seeing this, but I can't remember what the cause is.

In T353957#9424131, @Daimona wrote:

Hmmmm I don't quite understand why PHPUnit is printing the usage and then aborting. It's definitely not the first time I'm seeing this, but I can't remember what the cause is.

Maybe it can't find a config file? That would be weird though, as it should use the phpunit.xml.dist in MW core by default.

In T353957#9424132, @Daimona wrote:

In T353957#9424131, @Daimona wrote:

Hmmmm I don't quite understand why PHPUnit is printing the usage and then aborting. It's definitely not the first time I'm seeing this, but I can't remember what the cause is.

Maybe it can't find a config file? That would be weird though, as it should use the phpunit.xml.dist in MW core by default.

That is it! We're not cloning MediaWiki here, we're downloading it via wget -O- https://github.com/wikimedia/mediawiki/archive/$MW_BRANCH.tar.gz and the .gitattributes file has phpunit.xml.dist export-ignore, so that file is not included there.

I got to go now, but will think tomorrow about what direction this should best be fixed.

Thoughts welcome :)

In T353957#9435658, @Michael wrote:

That is it! We're not cloning MediaWiki here, we're downloading it via wget -O- https://github.com/wikimedia/mediawiki/archive/$MW_BRANCH.tar.gz and the .gitattributes file has phpunit.xml.dist export-ignore, so that file is not included there.

Jeeeeeeez. Thanks for figuring that out ^^

Apparently the motivation for that is “to keep DocumentRoot clear for tar-ball installs” (Gerrit comment); tests/ instead has an .htaccess file, so that’s why we don’t export-ignore all of tests/, I guess.

We should probably just use a real git clone? With --depth=1 it hopefully shouldn’t take much longer than downloading the tarball.

In T353957#9441083, @Lucas_Werkmeister_WMDE wrote:

In T353957#9435658, @Michael wrote:

That is it! We're not cloning MediaWiki here, we're downloading it via wget -O- https://github.com/wikimedia/mediawiki/archive/$MW_BRANCH.tar.gz and the .gitattributes file has phpunit.xml.dist export-ignore, so that file is not included there.

Jeeeeeeez. Thanks for figuring that out ^^

Apparently the motivation for that is “to keep DocumentRoot clear for tar-ball installs” (Gerrit comment); tests/ instead has an .htaccess file, so that’s why we don’t export-ignore all of tests/, I guess.

We should probably just use a real git clone? With --depth=1 it hopefully shouldn’t take much longer than downloading the tarball.

Yeah, that's what I did in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/987955 and it works fine. It should work here just as well.

(Though, I did not find an answer for why we actually switched to downloading the tarball back in 2014 for TravisCI. We originally started out with cloning it as well.)

Change 988657 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Fix secondary CI on GitHub by actually cloning MediaWiki

https://gerrit.wikimedia.org/r/988657

gerritbot added a project: Patch-For-Review.Jan 8 2024, 3:51 PM

Change 988657 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix secondary CI on GitHub by actually cloning MediaWiki

https://gerrit.wikimedia.org/r/988657

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2024, 4:31 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 8 2024, 5:00 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board.Feb 9 2024, 3:09 PM

Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team.

karapayneWMDE moved this task from Incoming to [DOT] Tech Backlog on the Wikidata Dev Team board.Feb 13 2024, 3:06 PM

karapayneWMDE removed a project: Wikidata Dev Team.Feb 13 2024, 3:47 PM

Prio Notes:

Impact Area	Affected
production / end users	✘
monitoring	✘
development efforts	✔
onboarding efforts	✘
additional stakeholders	✔

(Additional stakeholders: other Wikidata/Wikibase teams.)

Lucas_Werkmeister_WMDE renamed this task from Wikibase secondary CI is broken and email sending is broken again (Dec 2023) to [SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023).Mar 12 2024, 9:30 AM

Lucas_Werkmeister_WMDE moved this task from [DOT] By Project to [DOT] Prioritized on the wmde-wikidata-tech board.

[SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023)Open, Needs TriagePublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

[SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023)
Open, Needs TriagePublic
Actions

Related Objects
Search...