Description

https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&action=history

Screenshot 2024-01-02 at 12.18.44 PM.png (429×1 px, 78 KB)

Removing the max-height seems like the simplest solution here.

QA Results - Prod

AC	Status	Details
1	✅	T354218#9470939

Details

	Subject	Repo	Branch	Lines +/-
	Fix text overflow in history page	mediawiki/skins/MinervaNeue	wmf/1.42.0-wmf.13	+3 -1
	Fix text overflow in history page	mediawiki/skins/MinervaNeue	master	+3 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T305113 [EPIC] Remove mobile history page
Resolved	Jdlrobson	T353388 Enable desktop history HTML on mobile
Resolved	Edtadros	T354218 Long edit summaries spill out of container on history page

Event Timeline

Jdlrobson triaged this task as High priority.Jan 2 2024, 8:20 PM

Jdlrobson created this task.

Jdlrobson moved this task from Backlog to Remove mobile diff and history page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 3 2024, 1:57 AM

Osps7 awarded a token.Jan 5 2024, 10:18 AM

Change 988057 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fix text overflow in history page

https://gerrit.wikimedia.org/r/988057

gerritbot added a project: Patch-For-Review.Jan 5 2024, 7:28 PM

Change 988057 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix text overflow in history page

https://gerrit.wikimedia.org/r/988057

Edward QA of this is low priority but would be appreciated!

Jdlrobson lowered the priority of this task from High to Low.Jan 11 2024, 9:05 PM

Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.

Maintenance_bot removed a project: Patch-For-Review.Jan 11 2024, 9:31 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 11 2024, 10:00 PM

Jdlrobson moved this task from Backlog to History on the MobileFrontend (MobileFrontend Special Pages) board.Jan 12 2024, 5:10 PM

Change 991049 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.13] Fix text overflow in history page

https://gerrit.wikimedia.org/r/991049

gerritbot added a project: Patch-For-Review.Jan 16 2024, 6:05 PM

Change 991049 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.13] Fix text overflow in history page

https://gerrit.wikimedia.org/r/991049

Mentioned in SAL (#wikimedia-operations) [2024-01-17T21:45:54Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:991049|Fix text overflow in history page (T354218)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-17T21:47:20Z] <catrope@deploy2002> jdlrobson and catrope: Backport for [[gerrit:991049|Fix text overflow in history page (T354218)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-17T21:55:34Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:991049|Fix text overflow in history page (T354218)]] (duration: 09m 39s)

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2024, 10:31 PM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ); removed MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 17 2024, 11:00 PM

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Long edits should not spill out of container

Edtadros updated the task description. (Show Details)Jan 18 2024, 9:35 PM

Edtadros mentioned this in T354296: Verify 1.42.0-wmf.13 deployment.Jan 18 2024, 10:40 PM

Jdlrobson closed this task as Resolved.Jan 19 2024, 12:48 AM

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.

	F41649021: Screenshot 2024-01-02 at 12.18.44 PM.png
	Jan 2 2024, 8:20 PM

	F41698225: screenshot 408.png
	Jan 18 2024, 9:34 PM

Long edit summaries spill out of container on history pageClosed, ResolvedPublic0 Estimated Story PointsActions