Page MenuHomePhabricator

InvalidArgumentException: Passing a raw callable is not allowed here. Use [ 'factory' => $callable ] instead.
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   InvalidArgumentException: Passing a raw callable is not allowed here. Use [ 'factory' => $callable ] instead.
error.stack_trace
from /srv/mediawiki/php-1.42.0-wmf.15/vendor/wikimedia/object-factory/src/ObjectFactory.php(279)
#0 /srv/mediawiki/php-1.42.0-wmf.15/vendor/wikimedia/object-factory/src/ObjectFactory.php(174): Wikimedia\ObjectFactory\ObjectFactory::validateSpec(string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.15/vendor/wikimedia/object-factory/src/ObjectFactory.php(149): Wikimedia\ObjectFactory\ObjectFactory::getObjectFromSpec(string, array)
#2 /srv/mediawiki/php-1.42.0-wmf.15/includes/logging/LogFormatter.php(72): Wikimedia\ObjectFactory\ObjectFactory->createObject(string, array)
#3 /srv/mediawiki/php-1.42.0-wmf.15/includes/logging/LogFormatter.php(89): LogFormatter::newFromEntry(DatabaseLogEntry)
#4 /srv/mediawiki/php-1.42.0-wmf.15/includes/logging/LogPager.php(443): LogFormatter::newFromRow(stdClass)
#5 /srv/mediawiki/php-1.42.0-wmf.15/includes/pager/IndexPager.php(576): MediaWiki\Pager\LogPager->doBatchLookups()
#6 /srv/mediawiki/php-1.42.0-wmf.15/includes/specials/SpecialLog.php(313): MediaWiki\Pager\IndexPager->getBody()
#7 /srv/mediawiki/php-1.42.0-wmf.15/includes/specials/SpecialLog.php(192): MediaWiki\Specials\SpecialLog->show(MediaWiki\Html\FormOptions, array)
#8 /srv/mediawiki/php-1.42.0-wmf.15/includes/specialpage/SpecialPage.php(727): MediaWiki\Specials\SpecialLog->execute(string)
#9 /srv/mediawiki/php-1.42.0-wmf.15/includes/specialpage/SpecialPageFactory.php(1652): MediaWiki\SpecialPage\SpecialPage->run(string)
#10 /srv/mediawiki/php-1.42.0-wmf.15/includes/actions/ActionEntryPoint.php(504): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.42.0-wmf.15/includes/actions/ActionEntryPoint.php(151): MediaWiki\Actions\ActionEntryPoint->performRequest()
#12 /srv/mediawiki/php-1.42.0-wmf.15/includes/MediaWikiEntryPoint.php(169): MediaWiki\Actions\ActionEntryPoint->execute()
#13 /srv/mediawiki/php-1.42.0-wmf.15/index.php(50): MediaWiki\MediaWikiEntryPoint->run()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}
Impact
Notes

Event Timeline

…and I think they haven't worked for about 10 years, since that has not been supported for a long time, but the bad definitions were previously ignored. We can probably just remove those definitions?

Maybe they worked…

Change 992472 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/LiquidThreads@master] Use a class for 'LogActionsHandlers'

https://gerrit.wikimedia.org/r/992472

Change 992513 had a related patch set uploaded (by Hashar; author: Bartosz Dziewoński):

[mediawiki/extensions/LiquidThreads@wmf/1.42.0-wmf.15] Use a class for 'LogActionsHandlers'

https://gerrit.wikimedia.org/r/992513

Change 992472 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Use a class for 'LogActionsHandlers'

https://gerrit.wikimedia.org/r/992472

Change 992513 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@wmf/1.42.0-wmf.15] Use a class for 'LogActionsHandlers'

https://gerrit.wikimedia.org/r/992513

Mentioned in SAL (#wikimedia-operations) [2024-01-24T08:28:45Z] <hashar@deploy2002> Started scap: Backport for [[gerrit:992513|Use a class for 'LogActionsHandlers' (T355680)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-24T08:30:14Z] <hashar@deploy2002> hashar: Backport for [[gerrit:992513|Use a class for 'LogActionsHandlers' (T355680)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-24T08:36:46Z] <hashar@deploy2002> Finished scap: Backport for [[gerrit:992513|Use a class for 'LogActionsHandlers' (T355680)]] (duration: 08m 00s)

Looks fixed, thank you very much @matmarex !

Change 992837 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Clarify breaking change release notes for $wgLogActionsHandlers

https://gerrit.wikimedia.org/r/992837

Change 992837 merged by jenkins-bot:

[mediawiki/core@master] Clarify breaking change release notes for $wgLogActionsHandlers

https://gerrit.wikimedia.org/r/992837