Page MenuHomePhabricator

Reference Previews not showing when users disable page previews in settings
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Reference Preview is not showing

What should have happened instead?:

  • Reference Preview should show

There's a check in the code to make sure that we stop initializing the extension and the code bails out if there are no selectors configured:

https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/694b96a19f0673d936ad9257e9f42155ae8d0b47/src/index.js#256

But reference previews seems to register correctly with:

https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/694b96a19f0673d936ad9257e9f42155ae8d0b47/src/preview/model.js#241

Still when the check is done the selectors are empty. So I guess there's somewhat of a race condition happening.

Event Timeline

Change 993080 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Popups@master] Don't bail out early when there are no selectors configured

https://gerrit.wikimedia.org/r/993080

Change 993080 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Don't bail out early when there are no selectors configured

https://gerrit.wikimedia.org/r/993080

Change 994028 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.15] Don't bail out early when there are no selectors configured

https://gerrit.wikimedia.org/r/994028

Change 994028 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.15] Don't bail out early when there are no selectors configured

https://gerrit.wikimedia.org/r/994028

Mentioned in SAL (#wikimedia-operations) [2024-01-30T14:09:51Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Started scap: Backport for [[gerrit:994028|Don't bail out early when there are no selectors configured (T355933)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-30T14:11:27Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 wmde-fisch and lucaswerkmeister-wmde: Backport for [[gerrit:994028|Don't bail out early when there are no selectors configured (T355933)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-30T14:18:55Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Finished scap: Backport for [[gerrit:994028|Don't bail out early when there are no selectors configured (T355933)]] (duration: 09m 04s)

Change 994198 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994198

Change 994198 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994198

Change 994202 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.16] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994202

Change 994203 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.15] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994203

Change 994202 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.16] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994202

Change 994203 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.15] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994203

Mentioned in SAL (#wikimedia-operations) [2024-01-30T17:10:29Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:994202|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]], [[gerrit:994203|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-30T17:14:34Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:994202|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]], [[gerrit:994203|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-30T17:22:21Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:994202|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]], [[gerrit:994203|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]] (duration: 11m 51s)