Page MenuHomePhabricator
Create Task
Maniphest T356193

SyntaxError: Failed to execute 'closest' on 'Element': The provided selector is empty.
Closed, DuplicatePublicBUG REPORT
Actions

Description

Screenshot 2024-01-30 at 8.29.19 AM.png (614×2 px, 107 KB)

500,000 errors in last 2 hrs
https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-default-1-7.0.0-1-2024.01.30?id=z6kxW40Bk70gu8Gmb2AK
https://logstash.wikimedia.org/app/dashboards#/view/AXDBY8Qhh3Uj6x1zCF56?_g=h@c45c1a7&_a=h@3910f78

This seems to correspond with this backport:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/994028

Details

SubjectRepoBranchLines +/-
Do not search for elements if no previews have been registeredmediawiki/extensions/Popupswmf/1.42.0-wmf.15+7 -4
Do not search for elements if no previews have been registeredmediawiki/extensions/Popupswmf/1.42.0-wmf.16+7 -4
Do not search for elements if no previews have been registeredmediawiki/extensions/Popupsmaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jan 30 2024, 4:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2024, 4:28 PM
Jdlrobson triaged this task as Unbreak Now! priority.Jan 30 2024, 4:28 PM
Jdlrobson updated the task description. (Show Details)
Jdforrester-WMF subscribed.Jan 30 2024, 4:33 PM

Same as T356186?

matmarex closed this task as a duplicate of T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector".Jan 30 2024, 4:34 PM
matmarex subscribed.
gerritbot added a comment.Jan 30 2024, 4:35 PM

Change 994198 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994198

gerritbot added a project: Patch-For-Review.Jan 30 2024, 4:35 PM
Jdlrobson mentioned this in T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector".Jan 30 2024, 4:38 PM

Sounds like they are slightly different as no errors were being logged before the backport and that other ticket was created before, however I imagine the fix is the same.

gerritbot added a comment.Jan 30 2024, 4:51 PM

Change 994198 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994198

gerritbot added a comment.Jan 30 2024, 4:56 PM

Change 994202 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.16] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994202

gerritbot added a comment.Jan 30 2024, 4:58 PM

Change 994203 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.15] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994203

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 30 2024, 5:00 PM
gerritbot added a comment.Jan 30 2024, 5:08 PM

Change 994202 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.16] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994202

gerritbot added a comment.Jan 30 2024, 5:10 PM

Change 994203 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.15] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994203

Stashbot added a comment.Jan 30 2024, 5:10 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-30T17:10:29Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:994202|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]], [[gerrit:994203|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]]

Stashbot mentioned this in T355933: Reference Previews not showing when users disable page previews in settings.Jan 30 2024, 5:10 PM
Stashbot added a comment.Jan 30 2024, 5:14 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-30T17:14:34Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:994202|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]], [[gerrit:994203|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 30 2024, 5:22 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-30T17:22:21Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:994202|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]], [[gerrit:994203|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]] (duration: 11m 51s)

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2024, 5:30 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.15; 2024-01-23); removed MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 30 2024, 6:00 PM
awight added a subscriber: WMDE-Fisch.Jan 31 2024, 6:18 AM
awight subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL