Page MenuHomePhabricator
Create Task
Maniphest T356186

"Uncaught DOMException: Element.closest: '' is not a valid selector"
Closed, ResolvedPublicBUG REPORT
Actions

Description

Screenshot 2024-01-30 at 8.29.19 AM.png (614×2 px, 107 KB)

500,000 errors in last 2 hrs
https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-default-1-7.0.0-1-2024.01.30?id=z6kxW40Bk70gu8Gmb2AK
https://logstash.wikimedia.org/app/dashboards#/view/AXDBY8Qhh3Uj6x1zCF56?_g=h@c45c1a7&_a=h@3910f78

This seems to correspond with this backport:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/994028

Steps to replicate the issue:

  • Open a page on enwiki
  • Open browser console

What happens?:
"Uncaught DOMException: Element.closest: '' is not a valid selector" at /w/extensions/Popups/resources/dist/index.js:1:33508 (SourceMap is not working).

Example of stacktrace:

Uncaught DOMException: Element.closest: '' is not a valid selector
    Me https://en.wikipedia.org/w/extensions/Popups/src/preview/model.js:127
    EventListener.handleEvent* https://en.wikipedia.org/w/extensions/Popups/src/index.js:299
    <anonymous> https://en.wikipedia.org/w/extensions/Popups/src/index.js:178
    <anonymous> https://en.wikipedia.org/w/extensions/Popups/resources/dist/index.js?51e95:1
    <anonymous> https://en.wikipedia.org/w/extensions/Popups/resources/dist/index.js?51e95:1

What should have happened instead?:
No errors.

Details

SubjectRepoBranchLines +/-
Do not search for elements if no previews have been registeredmediawiki/extensions/Popupswmf/1.42.0-wmf.15+7 -4
Do not search for elements if no previews have been registeredmediawiki/extensions/Popupswmf/1.42.0-wmf.16+7 -4
Do not search for elements if no previews have been registeredmediawiki/extensions/Popupsmaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

Nardog created this task.Jan 30 2024, 2:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2024, 2:55 PM
A_smart_kitten subscribed.Jan 30 2024, 3:04 PM
Nardog mentioned this in T355933: Reference Previews not showing when users disable page previews in settings.Jan 30 2024, 3:04 PM
Jdforrester-WMF subscribed.Jan 30 2024, 3:07 PM

I cannot replicate, either logged-in or logged-out. Does it happen with safemode on for you (i.e. on https://en.wikipedia.org/wiki/Main_Page?safemode=1)?

A_smart_kitten added a comment.Jan 30 2024, 3:09 PM

I think this should be filed under Navigation-Popups-Gadget - the errors occur for me when this gadget is enabled.

Nardog added a comment.Jan 30 2024, 3:10 PM

Does it happen with safemode on for you (i.e. on https://en.wikipedia.org/wiki/Main_Page?safemode=1)?

Yes. And I have page previews disabled.

Jdforrester-WMF added a comment.Jan 30 2024, 3:11 PM
In T356186#9498691, @Nardog wrote:

Does it happen with safemode on for you (i.e. on https://en.wikipedia.org/wiki/Main_Page?safemode=1)?

Yes. And I have page previews disabled.

Interesting. If you use debug mode (https://en.wikipedia.org/wiki/Main_Page?safemode=1&debug=1) do you get a useful stack trace?

Nardog added a comment.Jan 30 2024, 3:14 PM
Uncaught DOMException: Element.closest: '' is not a valid selector
    Me https://en.wikipedia.org/w/extensions/Popups/src/preview/model.js:127
    EventListener.handleEvent* https://en.wikipedia.org/w/extensions/Popups/src/index.js:299
    <anonymous> https://en.wikipedia.org/w/extensions/Popups/src/index.js:178
    <anonymous> https://en.wikipedia.org/w/extensions/Popups/resources/dist/index.js?51e95:1
    <anonymous> https://en.wikipedia.org/w/extensions/Popups/resources/dist/index.js?51e95:1
Nardog updated the task description. (Show Details)Jan 30 2024, 3:22 PM
Jdforrester-WMF renamed this task from "Uncaught DOMException: Element.closest: '' is not a valid selector" to "Uncaught DOMException: Element.closest: '' is not a valid selector" when Page Previews is disabled but Navigation Popups gadget is enabled.Jan 30 2024, 4:06 PM
Jdforrester-WMF added a project: Navigation-Popups-Gadget.
Jdforrester-WMF added a comment.Jan 30 2024, 4:10 PM

Can reproduce by disabling Page Previews and enabling the Navigation Popups gadget.

This is particularly bizarre, as it appears(?) to be triggered by the preference to load the gadget itself rather than code from the gadget, as even in safemode when no gadget is loaded the error occurs?

Jdforrester-WMF mentioned this in T356193: SyntaxError: Failed to execute 'closest' on 'Element': The provided selector is empty..Jan 30 2024, 4:33 PM
matmarex merged a task: T356193: SyntaxError: Failed to execute 'closest' on 'Element': The provided selector is empty..Jan 30 2024, 4:34 PM
matmarex added a subscriber: Jdlrobson.
matmarex subscribed.
Jdlrobson added a comment.Jan 30 2024, 4:38 PM

Possibly the same as T356193 (but now at a considerably higher UBN rate)?

Jdlrobson triaged this task as Unbreak Now! priority.Jan 30 2024, 4:38 PM
Jdlrobson updated the task description. (Show Details)
matmarex added a comment.Jan 30 2024, 4:41 PM

The different error messages ("'' is not a valid selector" vs "The provided selector is empty") is probably a difference between browsers. These look like the same error.

gerritbot added a comment.Jan 30 2024, 4:42 PM

Change 994198 had a related patch set uploaded (by Bartosz Dziewoński; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994198

gerritbot added a project: Patch-For-Review.Jan 30 2024, 4:42 PM
gerritbot added a comment.Jan 30 2024, 4:51 PM

Change 994198 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994198

Mvolz added a project: Reference Previews.Jan 30 2024, 4:55 PM
gerritbot added a comment.Jan 30 2024, 4:56 PM

Change 994202 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.16] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994202

gerritbot added a comment.Jan 30 2024, 4:58 PM

Change 994203 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.15] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994203

gerritbot added a comment.Jan 30 2024, 5:09 PM

Change 994202 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.16] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994202

gerritbot added a comment.Jan 30 2024, 5:10 PM

Change 994203 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.42.0-wmf.15] Do not search for elements if no previews have been registered

https://gerrit.wikimedia.org/r/994203

Stashbot added a comment.Jan 30 2024, 5:10 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-30T17:10:29Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:994202|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]], [[gerrit:994203|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]]

Stashbot added a comment.Jan 30 2024, 5:14 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-30T17:14:34Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:994202|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]], [[gerrit:994203|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

NightWolf1223 subscribed.Jan 30 2024, 5:17 PM
Stashbot added a comment.Jan 30 2024, 5:22 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-30T17:22:21Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:994202|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]], [[gerrit:994203|Do not search for elements if no previews have been registered (T355933 T356186 T356193)]] (duration: 11m 51s)

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2024, 5:30 PM
A_smart_kitten attached a referenced file: F41731716: Screenshot 2024-01-30 at 8.29.19 AM.png. (Show Details)Jan 30 2024, 7:20 PM
Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.Jan 30 2024, 7:31 PM

Errors seem to be trailing off now: https://grafana.wikimedia.org/d/000000566/overview?orgId=1&tab=alert&viewPanel=16&from=now-30d&to=now
@Nardog can you confirm if this is also fixed for you?

Amorymeltzer subscribed.Jan 30 2024, 7:36 PM

(IANAnd but) It stopped for me around that time

Jdlrobson added a comment.Jan 30 2024, 8:21 PM

"IANAnd" lol :)

A_smart_kitten added a comment.Jan 30 2024, 8:27 PM

I'm no longer getting the stream of errors I was earlier after enabling the Navigation Popups gadget, so it (crosses fingers) seems to be fixed for me :)

Nardog renamed this task from "Uncaught DOMException: Element.closest: '' is not a valid selector" when Page Previews is disabled but Navigation Popups gadget is enabled to "Uncaught DOMException: Element.closest: '' is not a valid selector".EditedJan 31 2024, 4:46 AM

I didn't have the Navigation Popups gadget enabled and I still got the error.

Nardog removed a project: Navigation-Popups-Gadget.Jan 31 2024, 5:00 AM
Mvolz subscribed.Jan 31 2024, 7:49 AM
In T356186#9500883, @Nardog wrote:

I didn't have the Navigation Popups gadget enabled and I still got the error.

Fixed for me by the backport.

It was any gadget that used the pop up extension. The biggest culprit was probably the Reference Previews Gadget because a) it's enabled on registered accounts by default and b) there are lots of references on any given page. It was giving me maybe ~100 errors per minute per page? Navigation Popups also threw a lot too but isn't enabled by default so probably fewer people have it enabled (I'd guess). I also had a few user scripts that triggered it a few times as well.

Mvolz added a project: MediaWiki-extensions-PopupAlerts.Jan 31 2024, 7:52 AM
Mvolz removed a project: MediaWiki-extensions-PopupAlerts.
matmarex closed this task as Resolved.Jan 31 2024, 11:39 AM
Jdlrobson awarded a token.Jan 31 2024, 6:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL