Description

NOTE: Blocks deployment on mediawiki.org (15% of all errors there)

Steps to replicate the issue (include links if applicable):

What happens?:
Code block is unreadable

Screenshot 2024-02-07 at 8.13.50 PM.png (722×1 px, 109 KB)

What should have happened instead?:
Code block should be readable.

Software version (skip for WMF-hosted wikis like Wikipedia):

Solutions

Quick short term fix ***

Assert a color.

div.mw-highlight {
    background-color: white;
    color: @color-base;
}

Long term fix ***

We likely need to introduce a night mode set of styles.

QA Results - Beta

AC	Status	Details
1	✅	T356956#9728498

Details

	Subject	Repo	Branch	Lines +/-
	Adjust colors for remaining color contrast issues in night mode	mediawiki/extensions/SyntaxHighlight_GeSHi	master	+8 -6
	Make syntax highlighting readable in night mode	mediawiki/extensions/SyntaxHighlight_GeSHi	master	+2 -1

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Feb 8 2024, 4:17 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 8 2024, 4:17 AM

Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Feb 9 2024, 6:30 PM

Change 1003569 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Make syntax highlighting readable in night mode

https://gerrit.wikimedia.org/r/1003569

gerritbot added a project: Patch-For-Review.Feb 15 2024, 12:25 AM

Jdlrobson updated the task description. (Show Details)Feb 15 2024, 12:25 AM

Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Feb 22 2024, 4:35 PM

Jdlrobson triaged this task as Medium priority.Feb 22 2024, 6:56 PM

Jdlrobson moved this task from Backlog to Night mode coordination on the Web-Team-Backlog (Needs Prioritization (Tech)) board.

Jdlrobson added a project: Editing-team.Feb 29 2024, 10:59 PM

Jdlrobson added a subscriber: Esanders.

Jdlrobson moved this task from Night mode (mobile) to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 8 2024, 12:14 AM

Jdlrobson raised the priority of this task from Medium to High.Mar 8 2024, 11:57 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Night mode (desktop) to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 12 2024, 5:27 PM

Change #1003569 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Make syntax highlighting readable in night mode

https://gerrit.wikimedia.org/r/1003569

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Wed, Apr 17, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Wed, Apr 17, 12:30 PM

Jdlrobson updated the task description. (Show Details)Wed, Apr 17, 3:47 PM

Change #1020857 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Adjust colors for remaining color contrast issues in night mode

https://gerrit.wikimedia.org/r/1020857

gerritbot added a project: Patch-For-Review.Wed, Apr 17, 3:50 PM

Change #1020857 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Adjust colors for remaining color contrast issues in night mode

https://gerrit.wikimedia.org/r/1020857

Jdlrobson assigned this task to Edtadros.Thu, Apr 18, 6:41 PM

Jdlrobson lowered the priority of this task from High to Medium.

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 1); removed Web-Team-Backlog (Needs Prioritization (Tech)).

Jdlrobson set the point value for this task to 1.

Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 1) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://m.mediawiki.org/wiki/Extension:MobileFrontend?minervanightmode=1 or https://m.mediawiki.org/wiki/Manual:Configuring_file_uploads?minervanightmode=1 or https://en.m.wikipedia.beta.wmflabs.org/wiki/SyntaxHighlight?minervanightmode=1
Scroll to code block
✅ AC1: Code block should be readable.

Edtadros updated the task description. (Show Details)Fri, Apr 19, 12:38 AM

Jdlrobson assigned this task to ovasileva.Fri, Apr 19, 8:26 PM

Looks good, resolving.

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:57 PM

	F41810813: Screenshot 2024-02-07 at 8.13.50 PM.png
	Feb 8 2024, 4:17 AM

	F47426082: screenshot 227.png
	Fri, Apr 19, 12:38 AM

	F47426081: screenshot 228.png
	Fri, Apr 19, 12:38 AM

	F47426080: screenshot 229.png
	Fri, Apr 19, 12:38 AM

Prepare syntax highlighting for night modeClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions