Page MenuHomePhabricator
Create Task
Maniphest T356956

Prepare syntax highlighting for night mode
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Feb 8 2024, 4:17 AM
Tags
Referenced Files
F49673032: 2024-05-01_10-58-52.png
May 1 2024, 6:38 PM
F49657421: 2024-05-01_09-28-53.png
May 1 2024, 4:33 PM
F47426082: screenshot 227.png
Apr 19 2024, 12:38 AM
F47426081: screenshot 228.png
Apr 19 2024, 12:38 AM
F47426080: screenshot 229.png
Apr 19 2024, 12:38 AM
F41810813: Screenshot 2024-02-07 at 8.13.50 PM.png
Feb 8 2024, 4:17 AM
Subscribers
Aklapper
Edtadros
Esanders
GMikesell-WMF
Jdlrobson
Masumrezarock100

Description

NOTE: Blocks deployment on mediawiki.org (15% of all errors there)

Steps to replicate the issue (include links if applicable):

What happens?:
Code block is unreadable

Screenshot 2024-02-07 at 8.13.50 PM.png (722×1 px, 109 KB)

What should have happened instead?:
Code block should be readable.

Software version (skip for WMF-hosted wikis like Wikipedia):

Solutions

  • Quick short term fix ***

Assert a color.

div.mw-highlight {
    background-color: white;
    color: @color-base;
}
  • Long term fix ***

We likely need to introduce a night mode set of styles.

QA Results - Beta

ACStatusDetails
1✅T356956#9728498

QA Results - PROD

ACStatusDetails
1✅T356956#9761477

Details

SubjectRepoBranchLines +/-
SyntaxHighlight: Add color to override skinmediawiki/extensions/SyntaxHighlight_GeSHimaster+1 -0
Apply background to pre tagsmediawiki/extensions/SyntaxHighlight_GeSHimaster+1 -0
Adjust colors for remaining color contrast issues in night modemediawiki/extensions/SyntaxHighlight_GeSHimaster+8 -6
Make syntax highlighting readable in night modemediawiki/extensions/SyntaxHighlight_GeSHimaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Feb 8 2024, 4:17 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 8 2024, 4:17 AM
Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Feb 9 2024, 6:30 PM
gerritbot added a comment.Feb 15 2024, 12:25 AM

Change 1003569 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Make syntax highlighting readable in night mode

https://gerrit.wikimedia.org/r/1003569

gerritbot added a project: Patch-For-Review.Feb 15 2024, 12:25 AM
Jdlrobson updated the task description. (Show Details)Feb 15 2024, 12:25 AM
Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Feb 22 2024, 4:35 PM
Jdlrobson triaged this task as Medium priority.Feb 22 2024, 6:56 PM
Jdlrobson moved this task from Backlog to Night mode coordination on the Web-Team-Backlog (Needs Prioritization (Tech)) board.
Jdlrobson added a project: Editing-team.Feb 29 2024, 10:59 PM
Jdlrobson added a subscriber: Esanders.
Jdlrobson moved this task from Night mode (mobile) to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 8 2024, 12:14 AM
Jdlrobson raised the priority of this task from Medium to High.Mar 8 2024, 11:57 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Night mode (desktop) to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 12 2024, 5:27 PM
gerritbot added a comment.Apr 17 2024, 11:42 AM

Change #1003569 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Make syntax highlighting readable in night mode

https://gerrit.wikimedia.org/r/1003569

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 17 2024, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 17 2024, 12:30 PM
Jdlrobson updated the task description. (Show Details)Apr 17 2024, 3:47 PM
gerritbot added a comment.Apr 17 2024, 3:50 PM

Change #1020857 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Adjust colors for remaining color contrast issues in night mode

https://gerrit.wikimedia.org/r/1020857

gerritbot added a project: Patch-For-Review.Apr 17 2024, 3:50 PM
gerritbot added a comment.Apr 18 2024, 5:31 PM

Change #1020857 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Adjust colors for remaining color contrast issues in night mode

https://gerrit.wikimedia.org/r/1020857

Jdlrobson assigned this task to Edtadros.Apr 18 2024, 6:41 PM
Jdlrobson lowered the priority of this task from High to Medium.
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 1); removed Web-Team-Backlog (Needs Prioritization (Tech)).
Jdlrobson set the point value for this task to 1.
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 1) board.
Edtadros removed Edtadros as the assignee of this task.Apr 19 2024, 12:38 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 1) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://m.mediawiki.org/wiki/Extension:MobileFrontend?minervanightmode=1 or https://m.mediawiki.org/wiki/Manual:Configuring_file_uploads?minervanightmode=1 or https://en.m.wikipedia.beta.wmflabs.org/wiki/SyntaxHighlight?minervanightmode=1
Scroll to code block
✅ AC1: Code block should be readable.

screenshot 229.png (932×429 px, 41 KB)

screenshot 228.png (932×429 px, 71 KB)

screenshot 227.png (932×429 px, 73 KB)

Edtadros updated the task description. (Show Details)Apr 19 2024, 12:38 AM
Jdlrobson assigned this task to ovasileva.Apr 19 2024, 8:26 PM
ovasileva closed this task as Resolved.Apr 23 2024, 11:56 AM

Looks good, resolving.

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 6:57 PM
Edtadros mentioned this in T363369: Verify 1.43.0-wmf.2 deployment.Apr 29 2024, 5:12 PM
GMikesell-WMF subscribed.EditedMay 1 2024, 4:33 PM

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.4.1
Browser: Chrome 124
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.m.wikipedia.org/wiki/Code_folding?minervanightmode=1
Scroll to code block
✅ AC1: Code block should be readable.

2024-05-01_10-58-52.png (649×743 px, 113 KB)

GMikesell-WMF updated the task description. (Show Details)May 1 2024, 4:34 PM
GMikesell-WMF added a project: Verified.May 1 2024, 8:58 PM
gerritbot added a comment.May 17 2024, 2:18 PM

Change #1032792 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Apply background to

https://gerrit.wikimedia.org/r/1032792

gerritbot added a project: Patch-For-Review.May 17 2024, 2:18 PM
gerritbot added a comment.May 20 2024, 7:25 PM

Change #1032792 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Apply background to pre tags

https://gerrit.wikimedia.org/r/1032792

Maintenance_bot removed a project: Patch-For-Review.May 20 2024, 7:31 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.6; 2024-05-21); removed MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).May 20 2024, 8:00 PM
Izno mentioned this in T365774: Black text should not inherit colour in page syntax highlighting.May 25 2024, 10:21 PM
gerritbot added a comment.May 25 2024, 11:27 PM

Change #1035658 had a related patch set uploaded (by Steven Rawson; author: Steven Rawson):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] SyntaxHighlight: Add color to override skin

https://gerrit.wikimedia.org/r/1035658

gerritbot added a project: Patch-For-Review.May 25 2024, 11:27 PM
gerritbot added a comment.May 28 2024, 8:39 PM

Change #1035658 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] SyntaxHighlight: Add color to override skin

https://gerrit.wikimedia.org/r/1035658

Maintenance_bot removed a project: Patch-For-Review.May 28 2024, 9:30 PM
Lucas_Werkmeister_WMDE mentioned this in T369283: Section for links on entity schema pages has the wrong background colour.Jul 8 2024, 4:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits