Page MenuHomePhabricator
Create Task
Maniphest T357166

Categories appear in light theme
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Feb 9 2024, 6:29 PM
Tags
Referenced Files
F45443356: screenshot 196.png
Tue, Apr 9, 11:10 PM
F45443355: screenshot 195.png
Tue, Apr 9, 11:10 PM
F44369639: screenshot 165.png
Wed, Apr 3, 8:00 PM
F44369637: screenshot 166.png
Wed, Apr 3, 8:00 PM
F41830176: Screenshot 2024-02-09 at 10.29.55 AM.png
Feb 9 2024, 6:30 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
Masumrezarock100

Description

This should be automatically fixed once T334790 is resolved.

In advanced mode visit https://en.m.wikipedia.org/wiki/Spain?minervanightmode=1 and scroll to bottom

Screenshot 2024-02-09 at 10.29.55 AM.png (644×2 px, 126 KB)

Expected: No color contrast issues. Should appear blue links on dark background.

QA Results - Beta

ACStatusDetails
1✅T357166#9685923

QA Results - Prod

ACStatusDetails
1✅T357166#9702684

Details

SubjectRepoBranchLines +/-
Define background-color-neutral-subtle in dark mode palettemediawiki/skins/MinervaNeuemaster+1 -0
Skin: Use design tokens rather than hardcoded valuesmediawiki/coremaster+7 -6
Skin: Use LESS variable for design tokens rather than CSS variablesmediawiki/coremaster+6 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Feb 9 2024, 6:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2024, 6:29 PM
Jdlrobson updated the task description. (Show Details)Feb 9 2024, 6:30 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptFeb 9 2024, 6:30 PM
Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Feb 9 2024, 6:30 PM
Jdlrobson renamed this task from [Tracking] Categories appear in light theme to Categories appear in light theme.Feb 23 2024, 3:21 PM
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task from Incoming to FY2023-24 Q3 Sprint 5 on the Web-Team-Backlog board.Feb 23 2024, 6:58 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog.
gerritbot added a comment.Feb 27 2024, 4:40 PM

Change 997978 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Skin: Use design tokens rather than hardcoded values

https://gerrit.wikimedia.org/r/997978

gerritbot added a project: Patch-For-Review.Feb 27 2024, 4:40 PM
Jdlrobson added a parent task: T334790: tokens: Implement new static layout background-color tokens.Feb 27 2024, 4:43 PM
Jdlrobson triaged this task as Medium priority.Feb 29 2024, 4:26 PM
CCiufo-WMF removed a parent task: T334790: tokens: Implement new static layout background-color tokens.Mar 5 2024, 3:45 PM
CCiufo-WMF added a subtask: T334790: tokens: Implement new static layout background-color tokens.
CCiufo-WMF changed the status of subtask T334790: tokens: Implement new static layout background-color tokens from Open to In Progress.Mar 5 2024, 3:48 PM
Jdlrobson moved this task from Night mode (mobile) to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 8 2024, 12:13 AM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).Mar 11 2024, 7:08 PM
gerritbot added a comment.Mar 11 2024, 8:54 PM

Change 1010317 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Skin: Use design tokens rather than hardcoded values

https://gerrit.wikimedia.org/r/1010317

gerritbot added a comment.Mar 19 2024, 6:57 PM

Change 997978 abandoned by Jdlrobson:

[mediawiki/core@master] Skin: Use LESS variable for design tokens rather than CSS variables

Reason:

Merged into https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1010317/1?usp=related-change

https://gerrit.wikimedia.org/r/997978

egardner closed subtask T334790: tokens: Implement new static layout background-color tokens as Resolved.Mar 19 2024, 10:16 PM
gerritbot added a comment.Mar 20 2024, 12:49 AM

Change 1010317 merged by jenkins-bot:

[mediawiki/core@master] Skin: Use design tokens rather than hardcoded values

https://gerrit.wikimedia.org/r/1010317

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2024, 1:30 AM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 6); removed Web-Team-Backlog.Mar 20 2024, 3:59 PM
Jdlrobson set the point value for this task to 0.
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.

This can be QAed as part of sprint 6.

Jdlrobson updated the task description. (Show Details)Mar 20 2024, 4:03 PM
Jdlrobson updated the task description. (Show Details)Mar 27 2024, 2:14 PM
Jdlrobson moved this task from QA to Needs More Work on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.Mon, Apr 1, 1:10 AM
gerritbot added a comment.Mon, Apr 1, 1:17 AM

Change #1015657 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Define background-color-neutral-subtle in dark mode palette

https://gerrit.wikimedia.org/r/1015657

gerritbot added a project: Patch-For-Review.Mon, Apr 1, 1:17 AM
Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.Mon, Apr 1, 1:17 AM

This does not appear to be working. --background-color-neutral-subtle only seems to be defined for light mode theme. https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1015657 fixes it.

Mabualruz moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.Mon, Apr 1, 1:41 AM
gerritbot added a comment.Mon, Apr 1, 2:07 AM

Change #1015657 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Define background-color-neutral-subtle in dark mode palette

https://gerrit.wikimedia.org/r/1015657

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mon, Apr 1, 3:00 AM
Jdlrobson assigned this task to Edtadros.Wed, Apr 3, 10:58 AM
Edtadros removed Edtadros as the assignee of this task.Wed, Apr 3, 8:00 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

In advanced mode visit https://en.m.wikipedia.org/wiki/Spain?minervanightmode=1 and scroll to bottom
✅ AC1: Expected: No color contrast issues. Should appear blue links on dark background.

screenshot 166.png (826×1 px, 231 KB)

screenshot 165.png (826×1 px, 231 KB)

Edtadros updated the task description. (Show Details)Wed, Apr 3, 8:28 PM
ovasileva claimed this task.Thu, Apr 4, 4:38 PM
ovasileva closed this task as Resolved.Mon, Apr 8, 9:21 AM

All done

Edtadros added a project: Verified.Tue, Apr 9, 11:10 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

In advanced mode visit https://en.m.wikipedia.org/wiki/Spain?minervanightmode=1 and scroll to bottom
✅ AC1: Expected: No color contrast issues. Should appear blue links on dark background.

screenshot 195.png (1×1 px, 372 KB)

screenshot 196.png (1×1 px, 459 KB)

Edtadros updated the task description. (Show Details)Tue, Apr 9, 11:11 PM
Edtadros mentioned this in T360465: Verify 1.42.0-wmf.25 deployment.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL