| Jdlrobson | |
| Feb 9 2024, 6:29 PM |
| F45443356: screenshot 196.png | |
| Apr 9 2024, 11:10 PM |
| F45443355: screenshot 195.png | |
| Apr 9 2024, 11:10 PM |
| F44369639: screenshot 165.png | |
| Apr 3 2024, 8:00 PM |
| F44369637: screenshot 166.png | |
| Apr 3 2024, 8:00 PM |
| F41830176: Screenshot 2024-02-09 at 10.29.55 AM.png | |
| Feb 9 2024, 6:30 PM |
This should be automatically fixed once T334790 is resolved.
In advanced mode visit https://en.m.wikipedia.org/wiki/Spain?minervanightmode=1 and scroll to bottom
Expected: No color contrast issues. Should appear blue links on dark background.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T357166#9685923 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T357166#9702684 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T357166 Categories appear in light theme | |||
| Resolved | Volker_E | T334790 tokens: Implement new static layout background-color tokens |
Change 997978 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Skin: Use design tokens rather than hardcoded values
Change 1010317 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Skin: Use design tokens rather than hardcoded values
Change 997978 abandoned by Jdlrobson:
[mediawiki/core@master] Skin: Use LESS variable for design tokens rather than CSS variables
Reason:
Merged into https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1010317/1?usp=related-change
Change 1010317 merged by jenkins-bot:
[mediawiki/core@master] Skin: Use design tokens rather than hardcoded values
Change #1015657 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Define background-color-neutral-subtle in dark mode palette
This does not appear to be working. --background-color-neutral-subtle only seems to be defined for light mode theme. https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1015657 fixes it.
Change #1015657 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Define background-color-neutral-subtle in dark mode palette
Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
In advanced mode visit https://en.m.wikipedia.org/wiki/Spain?minervanightmode=1 and scroll to bottom
✅ AC1: Expected: No color contrast issues. Should appear blue links on dark background.
Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
In advanced mode visit https://en.m.wikipedia.org/wiki/Spain?minervanightmode=1 and scroll to bottom
✅ AC1: Expected: No color contrast issues. Should appear blue links on dark background.
