Page MenuHomePhabricator
Create Task
Maniphest T358814

[Bug] Night mode applies to form elements in mobile when night mode is disabled
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Feb 29 2024, 11:04 PM
Tags
Referenced Files
F42471549: screenshot 689.png
Mar 8 2024, 6:13 PM
F42471548: screenshot 688.png
Mar 8 2024, 6:13 PM
F42398527: screenshot 624.png
Mar 5 2024, 2:59 PM
F42398526: screenshot 623.png
Mar 5 2024, 2:59 PM
F42267182: image.png
Feb 29 2024, 11:04 PM
Subscribers
Aklapper
Edtadros
Frostly
Jdlrobson
Lofhi
Masumrezarock100
ovasileva
Yahya

Description

Steps to reproduce

  1. On operating system set dark mode as preference
  2. Visit https://en.m.wikipedia.org/wiki/Facebook?safemode=1 (or https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Dog)
  3. Click edit

Expected results

  • Editor should still appear in light mode

Actual results

Editor appears in night mode.

image.png (586×720 px, 179 KB)

Notes

Patched in https://en.m.wikipedia.org/w/index.php?title=MediaWiki:Mobile.css&diff=1211115644&oldid=1158451032&title=MediaWiki%3AMobile.css&diffonly=1

Environments observed

  • Browser version:
  • OS version:
  • Device model:
  • Device language:

Check any additional observations

Stack trace

Console output





QA Results - Beta





ACStatusDetails


1✅T358814#9601345









QA Results - Prod





ACStatusDetails


1✅T358814#9615938


Details
SubjectRepoBranchLines +/-
 Move color-scheme property from :root to .skin-night-mode-clientpref-2mediawiki/skins/MinervaNeuemaster+1 -1
Customize query in gerrit
Related Objects
Event Timeline
Jdlrobson created this task.Feb 29 2024, 11:04 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper.  ·  View Herald TranscriptFeb 29 2024, 11:04 PM
Jdlrobson updated the task description. (Show Details)Feb 29 2024, 11:05 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Regression.
gerritbot added a comment.Feb 29 2024, 11:11 PM
Change 1007733 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):



[mediawiki/skins/MinervaNeue@master] Remove color-scheme property from :root selector



https://gerrit.wikimedia.org/r/1007733
gerritbot added a project: Patch-For-Review.Feb 29 2024, 11:11 PM
ovasileva subscribed.Mar 1 2024, 12:17 PM
ovasileva triaged this task as High priority.Mar 1 2024, 12:25 PM
Jdlrobson assigned this task to Edtadros.Mar 1 2024, 9:37 PM
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Mar 1 2024, 10:02 PM
Change 1007733 merged by jenkins-bot:



[mediawiki/skins/MinervaNeue@master] Move color-scheme property from :root to .skin-night-mode-clientpref-2



https://gerrit.wikimedia.org/r/1007733
Jdlrobson set the point value for this task to 1.Mar 1 2024, 10:04 PM
Jdlrobson added a project: Unplanned-Sprint-Work.
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2024, 10:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 1 2024, 11:00 PM
Dragoniez mentioned this in T358957: Night mode applies to script-generated <input> tags in mobile when on-wiki night mode is disabled.Mar 2 2024, 5:51 PM
Frostly subscribed.Mar 2 2024, 8:28 PM
Edtadros removed Edtadros as the assignee of this task.Mar 5 2024, 2:59 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
Edtadros subscribed.
Test Result - Beta



Status: ✅ PASS

Environment: beta

OS: macOS Sonoma

Browser: Chrome

Device: MBA

Emulated Device:NA



Test Artifact(s):



QA Steps



On operating system set dark mode as preference

Select Day mode in settings

Visit https://en.m.wikipedia.org/wiki/Facebook?safemode=1 (or https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Dog)

Click edit

✅ AC1: Editor should still appear in light mode


screenshot 623.png (844×390 px, 105 KB)



screenshot 624.png (844×390 px, 237 KB)
Edtadros updated the task description. (Show Details)Mar 5 2024, 3:00 PM
Yahya subscribed.Mar 5 2024, 7:32 PM
Jdlrobson renamed this task from [Bug] Night mode applies to textareas in mobile when night mode is disabled to [Bug] Night mode applies to form elements in mobile when night mode is disabled.Mar 6 2024, 4:34 PM
Jdlrobson merged a task: T359314: Somehow a regression: base light inputs background are dark.
Jdlrobson added a subscriber: Lofhi.
SToyofuku-WMF assigned this task to ovasileva.Mar 7 2024, 5:38 PM
ovasileva closed this task as Resolved.Mar 8 2024, 1:59 PM
Edtadros added a project: Verified.Mar 8 2024, 6:13 PM
Test Result - Prod



Status: ✅ PASS

Environment: enwiki

OS: macOS Sonoma

Browser: Chrome

Device: MBA

Emulated Device:NA



Test Artifact(s):



QA Steps



On operating system set dark mode as preference

Select Day mode in settings

Visit https://en.m.wikipedia.org/wiki/Facebook?safemode=1 (or https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Dog)

Click edit

✅ AC1: Editor should still appear in light mode


screenshot 688.png (933×427 px, 126 KB)



screenshot 689.png (933×427 px, 164 KB)
Edtadros updated the task description. (Show Details)Mar 8 2024, 6:14 PM
Edtadros mentioned this in T358382: Verify 1.42.0-wmf.21 deployment.Mar 14 2024, 9:27 PM
Aklapper added a project: MinervaNeue.Mar 18 2024, 1:04 PM
Jdrewniak mentioned this in T358528: Mobile editor inconsistently renders both night mode and light mode elements.Mar 20 2024, 1:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL