Page MenuHomePhabricator
Create Task
Maniphest T359018

HTMLButtonField: Don't hard-code button flags in Codex implementation
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The Codex implementation of HTMLButtonField always outputs a primary progressive button. But we should instead look at $this->mFlags and set the appropriate CSS classes, so that we can support all types of buttons.

Details

SubjectRepoBranchLines +/-
HTMLButtonField: remove hard-coded button flags in Codexmediawiki/coremaster+17 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Mar 4 2024, 6:32 AM
CCiufo-WMF moved this task from Inbox to Up Next on the Design-System-Team board.Mar 4 2024, 9:12 PM
CCiufo-WMF triaged this task as High priority.Mar 13 2024, 5:24 PM
lwatson set the point value for this task to 1.Mar 18 2024, 5:20 PM
CCiufo-WMF moved this task from Up Next to DST-Sprint-19 (2024-03-18 to 2024-03-29) on the Design-System-Team board.Mar 18 2024, 5:26 PM
CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)); removed Design-System-Team.
gerritbot added a comment.Mar 20 2024, 9:32 PM

Change 1013143 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] HTMLButtonField: remove hard-coded button flags in Codex

https://gerrit.wikimedia.org/r/1013143

gerritbot added a project: Patch-For-Review.Mar 20 2024, 9:32 PM
lwatson changed the task status from Open to In Progress.Mar 20 2024, 9:32 PM
lwatson claimed this task.
lwatson moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.
lwatson moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.Mar 20 2024, 10:03 PM
Catrope closed this task as Resolved.Mar 22 2024, 1:57 AM
Catrope moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.
gerritbot added a comment.Mar 22 2024, 2:20 AM

Change #1013143 merged by jenkins-bot:

[mediawiki/core@master] HTMLButtonField: remove hard-coded button flags in Codex

https://gerrit.wikimedia.org/r/1013143

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2024, 2:30 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 22 2024, 3:00 AM
lwatson mentioned this in T359017: CodexHTMLForm: Codexify buttons at the bottom of the form.Mar 22 2024, 3:23 PM
Catrope edited projects, added MediaWiki-HTMLForm; removed Codex.Mar 26 2024, 4:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL