CodexHTMLForm: Codexify buttons at the bottom of the form
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Catrope
	Mar 4 2024, 6:28 AM

Description

The buttons at the bottom of the form are generated by HTMLForm::getButtons(). We need to override this method to produce Codex buttons instead of plain buttons.

When the $wgUseCodexSpecialBlock = true; configuration is set to true in LocalSettings.php, the Codex version of the form (CodexHTMLForm) is produced.

Acceptance Criteria

Stop hard-coding button flags in HTMLButtonField T359018
Create a function getButtons() in CodexHTMLForm that produces Codex buttons at the bottom of the form.
- As discussed, we will not include a Codex reset button because the reset button will be removed from HTMLForm.

Follow-up tasks

Remove the reset button from HTMLForm since it's unused. T361032
Refactor CodexHTMLForm::getButtons() to use a static method (similar to HTMLTextField).

Details

	Subject	Repo	Branch	Lines +/-
	CodexHTMLForm: Make form submit button container a `div`	mediawiki/core	master	+1 -1
	CodexHTMLForm: Codexify buttons at the bottom of the form	mediawiki/core	master	+108 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	bmartinezcalvo	T355148 [EPIC] Multiblocks
Resolved	Catrope	T359012 Migrate Special:Block to CodexHTMLForm
Resolved	None	T359011 [EPIC] CodexHTMLForm improvements for Multiblocks
Resolved	lwatson	T359017 CodexHTMLForm: Codexify buttons at the bottom of the form
Resolved	lwatson	T359018 HTMLButtonField: Don't hard-code button flags in Codex implementation

Event Timeline

Catrope created this task.Mar 4 2024, 6:28 AM

Catrope mentioned this in T359011: [EPIC] CodexHTMLForm improvements for Multiblocks.Mar 4 2024, 6:55 AM

Catrope renamed this task from CodexHTMLForm: Codexify buttons at the bottom of the form in to CodexHTMLForm: Codexify buttons at the bottom of the form.Mar 4 2024, 6:59 PM

CCiufo-WMF moved this task from Inbox to Up Next on the Design-System-Team board.Mar 4 2024, 9:12 PM

CCiufo-WMF triaged this task as High priority.Mar 13 2024, 5:24 PM

CCiufo-WMF removed a project: Epic.

lwatson set the point value for this task to 2.Mar 18 2024, 5:19 PM

CCiufo-WMF moved this task from Up Next to DST-Sprint-19 (2024-03-18 to 2024-03-29) on the Design-System-Team board.Mar 18 2024, 5:26 PM

CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)); removed Design-System-Team.

lwatson changed the task status from Open to In Progress.Mar 20 2024, 9:32 PM

lwatson claimed this task.

lwatson changed the status of subtask T359018: HTMLButtonField: Don't hard-code button flags in Codex implementation from Open to In Progress.

lwatson moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.

Catrope closed subtask T359018: HTMLButtonField: Don't hard-code button flags in Codex implementation as Resolved.Mar 22 2024, 1:57 AM

Change #1013568 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] [WIP]CodexHTMLForm: Codexify buttons at the bottom of the form

https://gerrit.wikimedia.org/r/1013568

gerritbot added a project: Patch-For-Review.Mar 22 2024, 3:23 PM

lwatson updated the task description. (Show Details)Mar 22 2024, 3:23 PM

Catrope edited projects, added MediaWiki-HTMLForm; removed Codex.Mar 26 2024, 4:24 PM

lwatson moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.Mar 29 2024, 1:29 PM

lwatson updated the task description. (Show Details)Mar 29 2024, 5:32 PM

Catrope moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.Mar 29 2024, 8:57 PM

Change #1013568 merged by jenkins-bot:

[mediawiki/core@master] CodexHTMLForm: Codexify buttons at the bottom of the form

https://gerrit.wikimedia.org/r/1013568

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 29 2024, 10:00 PM

Change #1016054 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] CodexHTMLForm: Make form submit button container a `div`

https://gerrit.wikimedia.org/r/1016054

The container needs to be a block-level element, otherwise we can use the margins just for primping our hair. (A German idiom ;) )
That's also what it is in OOUIHTMLForm.

Change #1016054 merged by jenkins-bot:

[mediawiki/core@master] CodexHTMLForm: Make form submit button container a `div`

https://gerrit.wikimedia.org/r/1016054

Volker_E removed a project: Patch-For-Review.Tue, Apr 2, 4:16 AM

Change #1015615 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] htmlform: Introduce CodexHTMLForm stylesheet

https://gerrit.wikimedia.org/r/1015615

gerritbot added a project: Patch-For-Review.Tue, Apr 2, 5:08 AM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.26; 2024-04-09); removed MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Wed, Apr 3, 2:02 PM

Volker_E closed this task as Resolved.Thu, Apr 4, 9:54 PM

Volker_E removed a project: Patch-For-Review.