HTMLForm: Remove unused reset button
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Catrope
	Mar 26 2024, 4:36 PM

Description

HTMLForm supports three kinds of built-in buttons at the bottom of the form: submit, reset and cancel. However, the reset button is disabled by default, and while SpecialPreferences needlessly calls suppressReset() to remove it, no code I could find does the opposite, so it seems to be completely unused, probably since e5a74e5ff74b7ab1642035290e55359e45d8361a (in September 2009) changed the default for mShowReset from true to false.

Details

Subject	Repo	Branch	Lines +/-
htmlform: Remove the reset button	mediawiki/core	master	+2 -32
htmlform: Remove call to `suppressReset()`	mediawiki/extensions/EditUser	master	+0 -1
htmlform: Remove call to `suppressReset()`	mediawiki/extensions/GlobalPreferences	master	+0 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		In Progress		bmartinezcalvo	T355148 [EPIC] Multiblocks
		Resolved		Volker_E	T361032 HTMLForm: Remove unused reset button

Event Timeline

Catrope created this task.Mar 26 2024, 4:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2024, 4:36 PM

Catrope moved this task from Inbox to Up Next on the Design-System-Team board.Mar 26 2024, 4:36 PM

Catrope mentioned this in T361034: HTMLForm: Refactor button code to consolidate.Mar 26 2024, 4:44 PM

lwatson mentioned this in T359017: CodexHTMLForm: Codexify buttons at the bottom of the form.Mar 29 2024, 5:32 PM

CCiufo-WMF triaged this task as High priority.Mon, Apr 1, 1:53 PM

Catrope set the point value for this task to 2.Mon, Apr 1, 5:19 PM

Catrope moved this task from Up Next to DST-Sprint-20 (2024-04-01 to 2024-04-12) on the Design-System-Team board.Mon, Apr 1, 5:24 PM

Catrope edited projects, added Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)); removed Design-System-Team.

matmarex awarded a token.Mon, Apr 1, 7:24 PM

matmarex subscribed.

lwatson claimed this task.Tue, Apr 2, 5:36 PM

lwatson removed lwatson as the assignee of this task.

lwatson subscribed.

CCiufo-WMF added a parent task: T355148: [EPIC] Multiblocks.Tue, Apr 9, 7:33 PM

I've shared my minor concern about if a reset button might be a useful usability feature in certain contexts of MediaWiki consumers outside. But I'll go ahead with the removal of the functionality.

Change #1019667 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GlobalPreferences@master] htmlform: Remove call to `suppressReset()`

https://gerrit.wikimedia.org/r/1019667

gerritbot added a project: Patch-For-Review.Mon, Apr 15, 7:34 AM

Change #1019668 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/EditUser@master] htmlform: Remove call to `suppressReset()`

https://gerrit.wikimedia.org/r/1019668

Change #1019669 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] htmlform: Remove the reset button

https://gerrit.wikimedia.org/r/1019669

Volker_E claimed this task.Mon, Apr 15, 7:43 AM

Volker_E moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)) board.