Page MenuHomePhabricator

HTMLForm: Remove unused reset button
Closed, ResolvedPublic2 Estimated Story Points

Description

HTMLForm supports three kinds of built-in buttons at the bottom of the form: submit, reset and cancel. However, the reset button is disabled by default, and while SpecialPreferences needlessly calls suppressReset() to remove it, no code I could find does the opposite, so it seems to be completely unused, probably since e5a74e5ff74b7ab1642035290e55359e45d8361a (in September 2009) changed the default for mShowReset from true to false.

Event Timeline

Catrope set the point value for this task to 2.Apr 1 2024, 5:19 PM
lwatson removed lwatson as the assignee of this task.
lwatson subscribed.
Volker_E subscribed.

I've shared my minor concern about if a reset button might be a useful usability feature in certain contexts of MediaWiki consumers outside. But I'll go ahead with the removal of the functionality.

Change #1019667 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GlobalPreferences@master] htmlform: Remove call to `suppressReset()`

https://gerrit.wikimedia.org/r/1019667

Change #1019668 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/EditUser@master] htmlform: Remove call to `suppressReset()`

https://gerrit.wikimedia.org/r/1019668

Change #1019669 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] htmlform: Remove the reset button

https://gerrit.wikimedia.org/r/1019669

Change #1019667 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] htmlform: Remove call to `suppressReset()`

https://gerrit.wikimedia.org/r/1019667

Change #1019668 merged by jenkins-bot:

[mediawiki/extensions/EditUser@master] htmlform: Remove call to `suppressReset()`

https://gerrit.wikimedia.org/r/1019668

Change #1019669 merged by jenkins-bot:

[mediawiki/core@master] htmlform: Remove the reset button

https://gerrit.wikimedia.org/r/1019669