Page MenuHomePhabricator

Tokens: Add dark mode decision tokens
Closed, ResolvedPublic2 Estimated Story Points

Description

Now that an expanded set of option tokens has been added to the WikimediaUI theme file in the Codex design tokens package (T358032), we need to take the next step and select a sub-set of these tokens to serve as decision tokens in our upcoming dark mode.

Acceptance Criteria
  • Create a new file, modes/dark.json in the codex-design-tokens project (The file was created in this patch)
  • This modes/dark.json file should contain a subset of the tokens in application.json (anything that dark mode needs to override); token names should be the same but the values should draw from other pre-defined option tokens (from the newly added colors). Colors should be represented as hex values.
  • Confirm with design that all chosen colors are correct.

Note: This task does not include the work to output dark-mode specific assets. See T360343 for that work.

Event Timeline

Change #1015983 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] tokens: Add dark mode decision tokens

https://gerrit.wikimedia.org/r/1015983

Change #1016397 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] styles: adjust component colors for dark mode to work

https://gerrit.wikimedia.org/r/1016397

Change #1015983 merged by jenkins-bot:

[design/codex@main] tokens: Add dark mode decision tokens

https://gerrit.wikimedia.org/r/1015983

Change #1018357 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] tokens: Add color-base-fixed to application.json

https://gerrit.wikimedia.org/r/1018357

Change #1018357 merged by jenkins-bot:

[design/codex@main] tokens: Add color-base-fixed to application.json

https://gerrit.wikimedia.org/r/1018357

Change #1016397 merged by jenkins-bot:

[design/codex@main] styles: adjust component colors for dark mode to work

https://gerrit.wikimedia.org/r/1016397

Change #1019305 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] tokens: remove color-base-fixed

https://gerrit.wikimedia.org/r/1019305

Change #1019305 merged by jenkins-bot:

[design/codex@main] tokens: remove color-base-fixed

https://gerrit.wikimedia.org/r/1019305

Change #1020918 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918

Change #1020918 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918