Tokens: reorganize token files
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	lwatson
	Feb 20 2024, 6:25 PM

Description

Reorganize the Codex design tokens into 3 tiers per ADR 8.

Option tokens for a given theme (right now we only support one theme, wikimedia-ui)
Decision tokens for a given mode (right now we only have a default light mode, but soon we'll have a dark mode as well; we may also define other modes or variants here as needed)
Component-specific tokens, which should not need to change on a per-theme or per-mode basis

Details

Subject	Repo	Branch	Lines +/-
Update Codex from v1.3.5 to v1.3.6	mediawiki/core	master	+1 K -276
build: Make "legacy" build redundant	design/codex	main	+346 -403
Update Codex from 1.3.4 to 1.3.5	mediawiki/core	master	+115 -70
build: Token reorganization part 2	design/codex	main	+152 -71
build: Re-organize Codex design tokens	design/codex	main	+23 -12
Update Codex from v1.3.3 to v1.3.4	mediawiki/core	master	+2 K -635

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		In Progress		DTorsani-WMF	T355147 [EPIC] Dark Mode
		Resolved		egardner	T358031 Tokens: reorganize token files

Event Timeline

lwatson created this task.Feb 20 2024, 6:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2024, 6:25 PM

lwatson set the point value for this task to 3.Feb 20 2024, 6:26 PM

CCiufo-WMF triaged this task as High priority.Feb 20 2024, 6:32 PM

egardner moved this task from Committed to Blocked ⛔ on the Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)) board.Feb 20 2024, 6:34 PM

CCiufo-WMF renamed this task from token: reorganize token files to Tokens: reorganize token files.Feb 20 2024, 6:42 PM

CCiufo-WMF added a project: Codex.

Restricted Application edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)). · View Herald TranscriptFeb 20 2024, 6:42 PM

CCiufo-WMF renamed this task from Tokens: reorganize token files to [PLACEHOLDER] Tokens: reorganize token files.Feb 20 2024, 6:42 PM

CCiufo-WMF moved this task from Inbox to DST-Sprint-17 (2024-02-20 to 2024-03-01) on the Design-System-Team board.

CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)); removed Design-System-Team.

egardner claimed this task.Feb 20 2024, 6:46 PM

CCiufo-WMF mentioned this in T357835: Dark mode color palette.Feb 20 2024, 7:36 PM

egardner moved this task from Blocked ⛔ to In Progress on the Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)) board.Feb 29 2024, 5:33 PM

Change 1007474 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build: Re-organize Codex design tokens

https://gerrit.wikimedia.org/r/1007474

gerritbot added a project: Patch-For-Review.Feb 29 2024, 7:13 PM

egardner moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)) board.Feb 29 2024, 8:02 PM

Change 1007984 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build, tokens: treat "legacy" font size as a mode

https://gerrit.wikimedia.org/r/1007984

CCiufo-WMF moved this task from DST-Sprint-17 (2024-02-20 to 2024-03-01) to Up Next on the Design-System-Team board.Mar 4 2024, 5:52 PM

CCiufo-WMF edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)).

CCiufo-WMF moved this task from Up Next to DST-Sprint-18 (2024-03-04 to 2024-03-15) on the Design-System-Team board.Mar 4 2024, 6:45 PM

CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)); removed Design-System-Team.

CCiufo-WMF moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)) board.Mar 4 2024, 6:55 PM

egardner mentioned this in T358032: Put night mode color palette in Codex.Mar 4 2024, 7:48 PM

Change 1007474 merged by jenkins-bot:

[design/codex@main] build: Re-organize Codex design tokens

https://gerrit.wikimedia.org/r/1007474

egardner renamed this task from [PLACEHOLDER] Tokens: reorganize token files to Tokens: reorganize token files.Mar 4 2024, 8:15 PM

egardner updated the task description. (Show Details)

CCiufo-WMF added a parent task: T355147: [EPIC] Dark Mode.Mar 5 2024, 3:44 PM

Change 1008950 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.3.3 to v1.3.4

https://gerrit.wikimedia.org/r/1008950

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cd11cbf23a/w

Change 1008970 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build: Token reorganization part 2

https://gerrit.wikimedia.org/r/1008970

Change 1008950 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.3.3 to v1.3.4

https://gerrit.wikimedia.org/r/1008950

Change 1008970 merged by jenkins-bot:

[design/codex@main] build: Token reorganization part 2

https://gerrit.wikimedia.org/r/1008970

egardner moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)) board.Mar 12 2024, 4:08 PM

egardner moved this task from DST-Sprint-18 (2024-03-04 to 2024-03-15) to DST-Sprint-19 (2024-03-18 to 2024-03-29) on the Design-System-Team board.Mar 18 2024, 5:20 PM

egardner edited projects, added Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)); removed Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)).

egardner moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.

Change 1012737 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from 1.3.4 to 1.3.5

https://gerrit.wikimedia.org/r/1012737

Change 1012737 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.3.4 to 1.3.5

https://gerrit.wikimedia.org/r/1012737

egardner moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.Mar 19 2024, 9:25 PM

Change 1007984 merged by jenkins-bot:

[design/codex@main] build: Make "legacy" build redundant

https://gerrit.wikimedia.org/r/1007984

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2024, 11:30 PM

Lofhi subscribed.Mar 21 2024, 4:52 PM

Does it mean we will have a official night mode color palette coming from Codex (see T357835)? Since the night mode is pushed on wikis and editors are starting to use their own colors... Edit: just found T360343, I think it covers my question.

In T358031#9650695, @Lofhi wrote:

Does it mean we will have a official night mode color palette coming from Codex (see T357835)? Since the night mode is pushed on wikis and editors are starting to use their own colors... Edit: just found T360343, I think it covers my question.

The initial beta version of the Night Mode feature is being developed in Minerva. But eventually we'd like everything to come from Codex. We just expanded the Codex color palette internally, and soon we will add a new file that defines which colors will be overridden in dark mode (T360341). Finally, we will start producing the dark mode CSS files from Codex itself (T360343 will start this work).

Eventually Night Mode will be introduced in Vector as well as Minerva. Our goal is to make it so that all the dark mode color values can come from Codex itself at that point, with the files produced in such a way to allow optimized and client-side switching between light and dark colors.

You might find this article interesting, as it informs a lot of the work we are doing here: https://dbanks.design/blog/dark-mode-with-style-dictionary/. The author is also the creator of Style Dictionary, an open-source tool that we use within Codex to manage our design tokens.

Moving this out of code review because all the associated patches are merged.

@egardner is this task done or is there more work to do here?

In T358031#9652635, @Catrope wrote:

Moving this out of code review because all the associated patches are merged.

@egardner is this task done or is there more work to do here?

I think we can consider this one done now.

egardner claimed this task.Mar 22 2024, 5:13 PM

egardner moved this task from Committed to Pending Release on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.

Change #1016452 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v1.3.5 to v1.3.6

https://gerrit.wikimedia.org/r/1016452

gerritbot added a project: Patch-For-Review.Tue, Apr 2, 10:14 PM

Change #1016452 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.3.5 to v1.3.6

https://gerrit.wikimedia.org/r/1016452

Volker_E closed this task as Resolved.Thu, Apr 4, 9:04 PM