Growth features: Migrate Help panel settings from Special:EditGrowthConfig to Community configuration 2.0
Open, HighPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Mar 19 2024, 7:46 PM

Description

As part of migrating Special:EditGrowthConfig to the Community configuration 2.0 system, we need to migrate the "Help panel settings" and "Help panel links" sections from https://en.wikipedia.org/wiki/Special:EditGrowthConfig to Special:CommunityConfiguration. This task captures that work.

Design for Help panel links


Existing implementation	Proposed design for the links section

Acceptance Criteria

"Help panel settings" configuration options are moved to Special:CommunityConfiguration/HelpPanel
"Help panel links" configuration options are moved to Special:CommunityConfiguration/HelpPanel

Details

Subject	Repo	Branch	Lines +/-
Config: add partial HelpPanel schema	mediawiki/extensions/GrowthExperiments	master	+89 -0
Editor: add control for array type	mediawiki/extensions/CommunityConfiguration	master	+215 -31
[refactor] Factor out ui subschema construction	mediawiki/extensions/CommunityConfiguration	master	+27 -17
Introduce AbstractProvider::storeConfiguration	mediawiki/extensions/CommunityConfiguration	master	+25 -1
Object control: use fieldset to display a main label	mediawiki/extensions/CommunityConfiguration	master	+23 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T265163 Create a system to encode best practices into editing experiences
Open		None	T327563 Enable volunteers to configure Edit Check in ways that align with project policies and norms
Open		None	T340453 [Epic] FY 2023-24 Growth Maintenance Work
Open		None	T327655 Epic: Migration of some GrowthExperiments features into MediaWiki core
Stalled	Feature	None	T328171 Use Community Configuration in Babel extension
Open		None	T323811 [EPIC] Community configuration 2.0: Factor Community configuration out of GrowthExperiments
Open		Sgs	T355317 Community configuration 2.0: migrate Special:EditGrowthConfig
Open		Sgs	T360472 Growth features: Migrate Help panel settings from Special:EditGrowthConfig to Community configuration 2.0
Resolved		Sgs	T357708 Namespaces selector control

Event Timeline

Urbanecm_WMF created this task.Mar 19 2024, 7:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2024, 7:46 PM

Urbanecm_WMF added a parent task: T355317: Community configuration 2.0: migrate Special:EditGrowthConfig.Mar 19 2024, 7:46 PM

Urbanecm_WMF moved this task from Backlog to Migrate Special:EditGrowthConfig on the CommunityConfiguration board.Mar 19 2024, 7:50 PM

This is currently blocked on implementing the agreed-on changes to T357718: Support schema references. Moving to Blocked to reflect that.

KStoller-WMF set the point value for this task to 3.Tue, Apr 2, 4:30 PM

Urbanecm_WMF edited projects, added Growth-Team (Sprint 11 (Growth Team)); removed Growth-Team (Sprint 10 (Growth Team)).Tue, Apr 2, 4:46 PM

Sgs claimed this task.Fri, Apr 5, 9:01 AM

Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 11 (Growth Team)) board.

Change #1017256 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Config: add HelpPanel schema

https://gerrit.wikimedia.org/r/1017256

gerritbot added a project: Patch-For-Review.Fri, Apr 5, 9:50 AM

Change #1017302 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/CommunityConfiguration@master] Editor: add control for array type

https://gerrit.wikimedia.org/r/1017302

Sgs moved this task from Sprint 11 (Growth Team) to Sprint 12 (Growth Team) on the Growth-Team board.Tue, Apr 16, 4:37 PM

Sgs edited projects, added Growth-Team (Sprint 12 (Growth Team)); removed Growth-Team (Sprint 11 (Growth Team)).

Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 12 (Growth Team)) board.

Sgs added a subtask: T357708: Namespaces selector control.Tue, Apr 16, 5:02 PM

Change #1020873 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/CommunityConfiguration@master] Object control: use fieldset to display a main label

https://gerrit.wikimedia.org/r/1020873

Change #1021411 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] Introduce AbstractProvider::storeConfiguration

https://gerrit.wikimedia.org/r/1021411

Change #1020873 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Object control: use fieldset to display a main label

https://gerrit.wikimedia.org/r/1020873

Change #1021411 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Introduce AbstractProvider::storeConfiguration

https://gerrit.wikimedia.org/r/1021411

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Thu, Apr 18, 12:00 PM

Change #1021465 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/CommunityConfiguration@master] [refactor] Factor out ui subschema construction

https://gerrit.wikimedia.org/r/1021465

@JFernandez-WMF @KStoller-WMF In the existing implementation we have a recommended link for each item in the list, should we keep that information? The new design does not reflect it.

Sgs mentioned this in T362906: Add management support for arrays.Thu, Apr 18, 3:46 PM

@JFernandez-WMF - Should we add that recommendation as a replacement for the "placeholder" Label text?
We should replace the link "placeholder" text as well. Should we provide an example for how the link should be formatted?

Sgs attached a referenced file: F43470829: help panel links example.png. (Show Details)Thu, Apr 18, 4:32 PM

In T360472#9726980, @Sgs wrote:

@JFernandez-WMF @KStoller-WMF In the existing implementation we have a recommended link for each item in the list, should we keep that information? The new design does not reflect it.

Yes sorry I missed that on the designs. Can we have the recommended labels and destinations in the Placeholder text instead of having 'recommended: X" in the label?

In T360472#9727148, @KStoller-WMF wrote:

Should we provide an example for how the link should be formatted?

@Sgs is the 'Destination page' field using Lookup? If it does then I don't think it is necessary to provide examples since admins can search through suggested results, but feel free to disagree.

In T360472#9727273, @JFernandez-WMF wrote:

In T360472#9726980, @Sgs wrote:

@JFernandez-WMF @KStoller-WMF In the existing implementation we have a recommended link for each item in the list, should we keep that information? The new design does not reflect it.

Yes sorry I missed that on the designs. Can we have the recommended labels and destinations in the Placeholder text instead of having 'recommended: X" in the label?

That sounds ok from a design pov but sadly we don't have support for custom placeholders yet, filed as T363051: Add support for field placeholders.

In T360472#9727148, @KStoller-WMF wrote:

Should we provide an example for how the link should be formatted?

@Sgs is the 'Destination page' field using Lookup? If it does then I don't think it is necessary to provide examples since admins can search through suggested results, but feel free to disagree.

Yes it is, agreed.

Sgs moved this task from Doing to Blocked / Needs Work on the Growth-Team (Sprint 12 (Growth Team)) board.Sat, Apr 20, 12:38 PM

This is now blocked on the support for enumerations which will be tackled in T362685

Sgs triaged this task as High priority.Sat, Apr 20, 12:40 PM

Change #1021465 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] [refactor] Factor out ui subschema construction

https://gerrit.wikimedia.org/r/1021465

Change #1017302 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Editor: add control for array type

https://gerrit.wikimedia.org/r/1017302

Sgs mentioned this in T357708: Namespaces selector control.Tue, Apr 23, 11:12 AM

Urbanecm_WMF mentioned this in T363414: Community configuration: Add tests finding invalid configuration variables used.Wed, Apr 24, 9:00 PM

Change #1017256 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Config: add partial HelpPanel schema

https://gerrit.wikimedia.org/r/1017256

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.3; 2024-04-30); removed MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Wed, Apr 24, 10:00 PM

Sgs updated the task description. (Show Details)Thu, Apr 25, 9:59 AM

Sgs moved this task from Blocked / Needs Work to Doing on the Growth-Team (Sprint 12 (Growth Team)) board.

Sgs moved this task from Doing to Blocked / Needs Work on the Growth-Team (Sprint 12 (Growth Team)) board.

Urbanecm_WMF mentioned this in T363457: Community configuration: Add support for autocomputed properties.Thu, Apr 25, 10:28 AM

Urbanecm_WMF removed a project: Patch-For-Review.Fri, Apr 26, 1:12 PM

Sgs moved this task from Blocked / Needs Work to Doing on the Growth-Team (Sprint 12 (Growth Team)) board.Mon, Apr 29, 3:52 PM

Sgs mentioned this in T355317: Community configuration 2.0: migrate Special:EditGrowthConfig.Mon, Apr 29, 5:19 PM

Sgs moved this task from Doing to Code Review on the Growth-Team (Sprint 12 (Growth Team)) board.Tue, Apr 30, 11:20 AM

Sgs updated the task description. (Show Details)

@Sgs I think this still misses the variables that depend on the enum. Depending on whether we want to do that here or in a follow-up, this should probably be in Doing or QA. In either case, I do not see any patch to review that'd be linked to this task (or that'd be pending patches), so I am moving this to Doing for now. However, feel free to move it further as appropriate (incl. back to CR if I failed to see a pending patch here).

Sgs moved this task from Doing to QA on the Growth-Team (Sprint 12 (Growth Team)) board.Tue, Apr 30, 11:44 AM

Sgs moved this task from QA to Doing on the Growth-Team (Sprint 12 (Growth Team)) board.Tue, Apr 30, 3:42 PM

Sgs moved this task from Sprint 12 (Growth Team) to Sprint 13 (Growth Team) on the Growth-Team board.Tue, Apr 30, 5:02 PM

Sgs edited projects, added Growth-Team (Sprint 13 (Growth Team)); removed Growth-Team (Sprint 12 (Growth Team)).

Restricted Application edited projects, added Growth-Team; removed Growth-Team (Sprint 13 (Growth Team)). · View Herald TranscriptTue, Apr 30, 5:02 PM

Sgs moved this task from Inbox to Sprint 13 (Growth Team) on the Growth-Team board.Tue, Apr 30, 5:04 PM

Sgs edited projects, added Growth-Team (Sprint 13 (Growth Team)); removed Growth-Team.

JFernandez-WMF closed subtask T357708: Namespaces selector control as Resolved.Tue, Apr 30, 5:04 PM

Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 13 (Growth Team)) board.Tue, Apr 30, 5:04 PM

In T360472#9757310, @Urbanecm_WMF wrote:

@Sgs I think this still misses the variables that depend on the enum. Depending on whether we want to do that here or in a follow-up, this should probably be in Doing or QA. In either case, I do not see any patch to review that'd be linked to this task (or that'd be pending patches), so I am moving this to Doing for now. However, feel free to move it further as appropriate (incl. back to CR if I failed to see a pending patch here).

Agreed, it was an oversight from my side, thanks for the catch. Working on it :)

	F47353401: Screenshot 2024-04-18 at 17.35.16.png
	Thu, Apr 18, 3:36 PM

Growth features: Migrate Help panel settings from Special:EditGrowthConfig to Community configuration 2.0Open, HighPublic3 Estimated Story PointsActions