Page MenuHomePhabricator
Create Task
Maniphest T362685

Control for JSON-schema enums
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The Special:EditGrowthConfig contains a control for choosing Where should questions from the help panel be directed? which offers two options: Mentor talk pages and Help desk. The selection is then stored as a boolean, values are true and false respectively.
We need a new control implemented in Vue as a replacement that would display the same but store the data as an string rather than a boolean.

Config property: GEHelpPanelAskMentor

Data schema

"GEHelpPanelAskMentor": {
  "type": "string",
   "enum": ["mentor-talk-page", "help-desk-page"]
  },

Existing implementation:

Screenshot 2024-04-16 at 17.45.27.png (214×1 px, 33 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Treat enum mismatches as a Validation warning on readingmediawiki/extensions/CommunityConfigurationmaster+29 -1
Add support for ask-mentor and post-on-top community config enumsmediawiki/extensions/GrowthExperimentsmaster+25 -0
Add support for enumsmediawiki/extensions/CommunityConfigurationmaster+188 -1
Customize query in gerrit

Related Objects

Event Timeline

Sgs created this task.Apr 16 2024, 3:45 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 16 2024, 3:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sgs triaged this task as High priority.Apr 16 2024, 3:46 PM
Sgs moved this task from Inbox to Up Next (estimated tasks) on the Growth-Team board.Apr 16 2024, 3:50 PM
Sgs mentioned this in T362044: Community configuration: Decision about how to display the boolean controls in Special:CommunityConfiguration/Mentorship.Apr 16 2024, 4:00 PM
KStoller-WMF set the point value for this task to 3.Apr 16 2024, 4:10 PM
KStoller-WMF moved this task from Up Next (estimated tasks) to Sprint 12 (Growth Team) on the Growth-Team board.Apr 16 2024, 4:41 PM
KStoller-WMF edited projects, added Growth-Team (Sprint 12 (Growth Team)); removed Growth-Team.
Sgs mentioned this in T360472: Growth features: Migrate Help panel settings from Special:EditGrowthConfig to Community configuration 2.0.Apr 20 2024, 12:40 PM
Michael claimed this task.Apr 29 2024, 10:13 AM
Michael moved this task from Incoming to Doing on the Growth-Team (Sprint 12 (Growth Team)) board.
Restricted Application added a project: User-Michael. · View Herald TranscriptApr 29 2024, 10:13 AM
gerritbot added a comment.Apr 29 2024, 10:56 AM

Change #1025301 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/CommunityConfiguration@master] Add support for enums

https://gerrit.wikimedia.org/r/1025301

gerritbot added a project: Patch-For-Review.Apr 29 2024, 10:56 AM
Michael moved this task from Doing to Code Review on the Growth-Team (Sprint 12 (Growth Team)) board.Apr 29 2024, 2:48 PM
Sgs mentioned this in T355317: Community configuration 2.0: migrate Special:EditGrowthConfig.Apr 29 2024, 5:22 PM
CodeReviewBot added a comment.Apr 29 2024, 6:28 PM

migr opened https://gitlab.wikimedia.org/repos/growth/community-configuration-example/-/merge_requests/16

Add examples showing the new enum control

gerritbot added a comment.Apr 29 2024, 7:32 PM

Change #1025451 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Add support for ask-mentor and post-on-top community config enums

https://gerrit.wikimedia.org/r/1025451

gerritbot added a comment.Apr 30 2024, 11:45 AM

Change #1025301 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Add support for enums

https://gerrit.wikimedia.org/r/1025301

Michael mentioned this in rECOMa4ccfc921a55: Add support for enums.Apr 30 2024, 11:45 AM
gerritbot added a comment.Apr 30 2024, 12:00 PM

Change #1025451 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add support for ask-mentor and post-on-top community config enums

https://gerrit.wikimedia.org/r/1025451

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).Apr 30 2024, 12:00 PM
Michael added a comment.Apr 30 2024, 12:38 PM

Things hat still need to be done here, I think:

  • actually make the two radio fields in GrowthExperiments HelpPanel config do something
  • make a config having a value that is not in the enum into a validation warning instead of a fatal error on reading
gerritbot added a comment.Apr 30 2024, 12:56 PM

Change #1025769 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/CommunityConfiguration@master] Treat enum mismatches as a Validation warning on reading

https://gerrit.wikimedia.org/r/1025769

Michael moved this task from Sprint 12 (Growth Team) to Sprint 13 (Growth Team) on the Growth-Team board.Apr 30 2024, 5:51 PM
Michael edited projects, added Growth-Team (Sprint 13 (Growth Team)); removed Growth-Team (Sprint 12 (Growth Team)).
Michael moved this task from Incoming to Code Review on the Growth-Team (Sprint 13 (Growth Team)) board.
gerritbot added a comment.Apr 30 2024, 7:20 PM

Change #1025769 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Treat enum mismatches as a Validation warning on reading

https://gerrit.wikimedia.org/r/1025769

Michael mentioned this in rECOMf7f89369e699: Treat enum mismatches as a Validation warning on reading.Apr 30 2024, 7:20 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 13 (Growth Team)) board.May 2 2024, 10:21 PM
Urbanecm_WMF subscribed.
In T362685#9757542, @Michael wrote:

Things hat still need to be done here, I think:

  • actually make the two radio fields in GrowthExperiments HelpPanel config do something

This is not done, but also doesn't really fit into this task – the goal here was to create an enum control, which works and saves the expected change in the JSON config. That config is not processed properly in GrowthExperiments as of now, but that's not really directly related to the enum control itself – that one is working as expected :). Filled T364053: Help panel does not process `GEHelpPanelPostOnTop` correctly when CommunityConfiguration extension is used for fixing the Help panel.

  • make a config having a value that is not in the enum into a validation warning instead of a fatal error on reading

This is done.

Since both of those items appear to be done, and there is no patch to review, moving to QA.

CodeReviewBot added a comment.May 14 2024, 1:02 PM

urbanecm merged https://gitlab.wikimedia.org/repos/growth/community-configuration-example/-/merge_requests/16

Add examples showing the new enum control

Maintenance_bot removed a project: Patch-For-Review.May 14 2024, 1:31 PM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 14 (Growth Team)); removed Growth-Team (Sprint 13 (Growth Team)).May 14 2024, 4:12 PM
Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 14 (Growth Team)) board.
Michael added a comment.May 15 2024, 8:33 AM

This should now be simple to try out in the CommunityConfiguratinExample extension.

Urbanecm_WMF edited projects, added Growth-Team (Sprint 15 (Growth Team)); removed Growth-Team (Sprint 14 (Growth Team)).May 28 2024, 4:04 PM
Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 15 (Growth Team)) board.
Urbanecm_WMF edited projects, added Growth-Team (Sprint 16 (Growth Team)); removed Growth-Team (Sprint 15 (Growth Team)).Jun 11 2024, 4:37 PM
Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 16 (Growth Team)) board.
Urbanecm_WMF closed this task as Resolved.Jun 12 2024, 3:36 PM

Transfered between QA columns for a couple of sprints => resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits