Non-codex legacy MW message box related styles are not being applied on Vector 2022
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	abi_
	Mar 21 2024, 1:35 PM

Description

Steps to replicate the issue (include links if applicable):

Visit: https://translatewiki.net/wiki/Translating:Wikimedia_Grants_Review?useskin=vector-2022

What happens?:
The error message:

Support for this project has been discontinued.

Is not styled in anyway

What should have happened instead?:
The error message should appear in an "error box" given that it has the mw-message-box mw-message-box-error classes.

Software version (skip for WMF-hosted wikis like Wikipedia):
MediaWiki 1.42.0-wmf.23
Vector 1.42.0-wmf.23

Other information (browser name/version, screenshots, etc.):

Works as expected with Timeless theme. See: https://translatewiki.net/wiki/Translating:Wikimedia_Grants_Review?useskin=timeless

And on legacy vector: https://translatewiki.net/wiki/Translating:Wikimedia_Grants_Review?useskin=vector

Details

	Subject	Repo	Branch	Lines +/-
	Support legacy message box styles markup in JavaScript	mediawiki/skins/Vector	wmf/1.42.0-wmf.23	+19 -1
	Support legacy message box styles markup in JavaScript	mediawiki/skins/Vector	master	+19 -1

Customize query in gerrit

Event Timeline

abi_ created this task.Mar 21 2024, 1:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2024, 1:35 PM

abi_ triaged this task as High priority.Mar 21 2024, 1:35 PM

abi_ moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2024-January-March) board.

Jdlrobson renamed this task from MW message box related styles are not being applied on Vector 2022 to Non-codex legacy MW message box related styles are not being applied on Vector 2022.Mar 21 2024, 2:49 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog.

Change #1013342 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Support legacy message box styles markup in JavaScript

https://gerrit.wikimedia.org/r/1013342

gerritbot added a project: Patch-For-Review.Mar 21 2024, 5:01 PM

Change #1013255 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.42.0-wmf.23] Support legacy message box styles markup in JavaScript

https://gerrit.wikimedia.org/r/1013255

Change #1013342 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Support legacy message box styles markup in JavaScript

https://gerrit.wikimedia.org/r/1013342

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 21 2024, 8:00 PM

Change #1013255 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.42.0-wmf.23] Support legacy message box styles markup in JavaScript

https://gerrit.wikimedia.org/r/1013255

Mentioned in SAL (#wikimedia-operations) [2024-03-21T20:27:53Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:1013255|Support legacy message box styles markup in JavaScript (T360633)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-21T20:45:32Z] <cjming@deploy1002> cjming and jdlrobson: Backport for [[gerrit:1013255|Support legacy message box styles markup in JavaScript (T360633)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.23; 2024-03-19); removed MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 21 2024, 9:00 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-21T21:03:01Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1013255|Support legacy message box styles markup in JavaScript (T360633)]] (duration: 35m 07s)

@Jdrewniak backported a fix today. It seems to have addressed the issue on WMF production. Please backport the same patch to translatewiki and let us know if you are still seeing problems.

Nikerabbit removed a project: Patch-For-Review.Apr 2 2024, 11:09 AM

Nikerabbit moved this task from Priority: Localization infrastructure to Check after deployment on the Language-Team (Language-2024-January-March) board.

Pginer-WMF edited projects, added Language-Team (Language-2024-April-June); removed Language-Team (Language-2024-January-March).Apr 2 2024, 3:21 PM

Pginer-WMF moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2024-April-June) board.

abi_ added a project: Localization Infrastructure FY2023-24.Thu, May 2, 4:16 AM

abi_ set the point value for this task to 1.