Page MenuHomePhabricator
Create Task
Maniphest T360698

Use jobs to fetch scores and then attempt reverts
Closed, ResolvedPublic
Actions

Description

Since we determined that we shouldn't depend on ORES in T359050: Investigate hard ORES dependency for AutoModerator pilot, we should run our score fetching and revert code from jobs.
We can use ORES as a template since it is already working well at scale:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ORES/+/refs/heads/master/includes/Services/FetchScoreJob.php

Note that ORES fetches the score from a job and then runs a hook that provides the score. If we create a near-identical job + hook, it will make implementing ORES as a soft dependency (to avoid requesting the same score twice) an easier optimization in the future. In this arrangement, our revert code would be run from an implementation of our hook that provides the score.

Details

SubjectRepoBranchLines +/-
Use job to fetch scoresmediawiki/extensions/AutoModeratormaster+612 -147
Cleanup FetchRevScoreJob return logic and messagesmediawiki/extensions/AutoModeratormaster+17 -12
Don't tag revisions to track rev check statusmediawiki/extensions/AutoModeratormaster+1 -44
Use jobs to fetch scores and then attempt reverts:mediawiki/extensions/AutoModeratormaster+213 -78
Customize query in gerrit

Related Objects
Search...

Event Timeline

jsn.sherman created this task.Mar 21 2024, 7:17 PM
Samwalton9-WMF moved this task from Inbox to Epics on the Moderator-Tools-Team board.Mar 25 2024, 5:42 PM
Samwalton9-WMF removed a project: Epic.
Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.Mar 26 2024, 3:52 PM
Scardenasmolinar changed the task status from Open to In Progress.Mar 30 2024, 1:03 AM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Apr 5 2024, 12:24 AM
This comment was removed by Scardenasmolinar.
Scardenasmolinar moved this task from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.Apr 5 2024, 12:24 AM
gerritbot added a comment.Apr 10 2024, 3:07 AM

Change #1018395 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@master] Use job to fetch scores

https://gerrit.wikimedia.org/r/1018395

gerritbot added a project: Patch-For-Review.Apr 10 2024, 3:07 AM
Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Apr 13 2024, 1:51 AM
Samwalton9-WMF moved this task from Backlog to Reverting on the Automoderator board.Apr 17 2024, 9:00 AM
jsn.sherman moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Apr 18 2024, 2:18 PM
Scardenasmolinar moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Apr 24 2024, 1:31 AM
gerritbot added a comment.Apr 24 2024, 11:01 PM

Change #1018395 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Use job to fetch scores

https://gerrit.wikimedia.org/r/1018395

Scardenasmolinar mentioned this in rEAMO452e2d2b30dc: Use job to fetch scores.Apr 24 2024, 11:02 PM
Scardenasmolinar moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.Apr 24 2024, 11:03 PM
Samwalton9-WMF closed this task as Resolved.Apr 25 2024, 4:08 PM

We have some followups here, @jsn.sherman to document :)

jsn.sherman mentioned this in T363592: SPIKE: Verify revision check jobs are logging errors and getting retried as desired [16HRS].Apr 26 2024, 4:51 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 6:08 PM
jsn.sherman reopened this task as Open.May 1 2024, 1:42 PM
jsn.sherman removed Scardenasmolinar as the assignee of this task.
jsn.sherman moved this task from Done to Ready on the Moderator-Tools-Team (Kanban) board.

Reopening this for the followup rather than authoring a new task:
Per T363592#9758945, we should do an early "successful" return in the job when receive a 422 response from the api. 422 indicates that a revision is not scorable, so we want to mark the job as a success to prevent retries. We should do the same thing when a revision is not found in LiftWingClient.php#122. We don't need to create http responses in our client the way we currently are, since there is no consumer, so we can simplify/cleanup the liftwing client returns.

jsn.sherman triaged this task as High priority.May 1 2024, 5:10 PM
Kgraessle claimed this task.May 1 2024, 7:51 PM
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.May 3 2024, 9:15 PM

Change #1027021 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/AutoModerator@master] [WIP]: Use jobs to fetch scores and then attempt reverts: Early Return from Job for 4xx status codes so as to not kick job off again.

https://gerrit.wikimedia.org/r/1027021

gerritbot added a project: Patch-For-Review.May 3 2024, 9:15 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.May 3 2024, 9:56 PM
jsn.sherman moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.May 7 2024, 1:55 PM
Kgraessle moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.May 7 2024, 11:08 PM
Kgraessle moved this task from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.May 8 2024, 1:14 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.May 8 2024, 1:57 PM
jsn.sherman moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.May 9 2024, 1:10 PM
gerritbot added a comment.May 9 2024, 1:17 PM

Change #1027021 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Use jobs to fetch scores and then attempt reverts:

https://gerrit.wikimedia.org/r/1027021

Kgraessle mentioned this in rEAMO096d283e0ed1: Use jobs to fetch scores and then attempt reverts:.May 9 2024, 1:19 PM
Maintenance_bot removed a project: Patch-For-Review.May 9 2024, 1:31 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 9 2024, 2:00 PM
gerritbot added a comment.May 9 2024, 3:36 PM

Change #1029611 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/AutoModerator@master] Don't tag revisions to track rev check status

https://gerrit.wikimedia.org/r/1029611

gerritbot added a project: Patch-For-Review.May 9 2024, 3:36 PM
gerritbot added a comment.May 9 2024, 4:08 PM

Change #1029617 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/AutoModerator@master] Cleanup FetchRevScoreJob return logic and messages

https://gerrit.wikimedia.org/r/1029617

jsn.sherman claimed this task.May 9 2024, 4:09 PM
jsn.sherman moved this task from Done to Eng review on the Moderator-Tools-Team (Kanban) board.
jsn.sherman added a subscriber: Kgraessle.

@Kgraessle I have a couple of followup patches ready for review!

Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.May 9 2024, 6:32 PM
gerritbot added a comment.May 9 2024, 10:49 PM

Change #1029611 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Don't tag revisions to track rev check status

https://gerrit.wikimedia.org/r/1029611

gerritbot added a comment.May 9 2024, 10:50 PM

Change #1029617 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Cleanup FetchRevScoreJob return logic and messages

https://gerrit.wikimedia.org/r/1029617

jsn.sherman mentioned this in rEAMO21cbccb1c607: Don't tag revisions to track rev check status.May 9 2024, 10:50 PM
jsn.sherman mentioned this in rEAMO54d3a6df0671: Cleanup FetchRevScoreJob return logic and messages.
Maintenance_bot removed a project: Patch-For-Review.May 9 2024, 11:31 PM
jsn.sherman moved this task from Reviewed (waiting for changes) to Done on the Moderator-Tools-Team (Kanban) board.May 10 2024, 5:49 PM
Samwalton9-WMF closed this task as Resolved.May 16 2024, 4:11 PM
thcipriani mentioned this in T366294: Error: Call to a member function getSlot() on null.May 30 2024, 3:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits