Error: Call to a member function getSlot() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	thcipriani
	May 30 2024, 3:18 PM

Description

Error

service.version: 1.43.0-wmf.7
trace.id: 769026eb-6487-44bc-800c-adb50a3c1fd8
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Error: Call to a member function getSlot() on null

error.stack_trace

from /srv/mediawiki/php-1.43.0-wmf.7/extensions/AutoModerator/src/Services/AutoModeratorFetchRevScoreJob.php(106)
#0 /srv/mediawiki/php-1.43.0-wmf.7/extensions/EventBus/includes/JobExecutor.php(80): AutoModerator\Services\AutoModeratorFetchRevScoreJob->run()
#1 /srv/mediawiki/rpc/RunSingleJob.php(60): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#2 {main}

Notes

Seems to have started with wmf.6
All errors coming from jobrunners, limited to testwiki only
Possibly related to T360698: Use jobs to fetch scores and then attempt reverts(?)

Details

Request URL: https://mw-jobrunner.discovery.wmnet/rpc/RunSingleJob.php

	Subject	Repo	Branch	Lines +/-
	Error: Call to a member function getSlot() on null	mediawiki/extensions/AutoModerator	master	+74 -7

Customize query in gerrit

Related Objects

Mentioned In: rEAMO9367e6bba549: Error: Call to a member function getSlot() on null
Mentioned Here: T360698: Use jobs to fetch scores and then attempt reverts

Event Timeline

thcipriani created this task.May 30 2024, 3:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2024, 3:18 PM

thcipriani moved this task from Untriaged to May 2024 on the Wikimedia-production-error board.May 30 2024, 3:19 PM

jsn.sherman changed the task status from Open to In Progress.May 30 2024, 3:30 PM

jsn.sherman claimed this task.

jsn.sherman edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.

jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

@Samwalton9-WMF can you disable AutoModerator on testwiki at https://test.wikipedia.org/wiki/MediaWiki:AutoModeratorConfig.json ? I still haven't been granted interface admin there.

Noting that we've found the data types for the job parameters differ between local dev (mysql queue) beta cluster, and production. We've been tweaking how we handle parameters to try to deal with that, but don't have a great way to test other than firing a change into production and seeing what happens. My understanding is that since the job runner is separate from the debug host, we really only see what happens after a full sync.

In T366294#9847160, @jsn.sherman wrote:

@Samwalton9-WMF can you disable AutoModerator on testwiki at https://test.wikipedia.org/wiki/MediaWiki:AutoModeratorConfig.json ? I still haven't been granted interface admin there.

Done! @Trizek-WMF might be able to help you get that request moved forward.

Change #1037563 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/AutoModerator@master] Error: Call to a member function getSlot() on null

https://gerrit.wikimedia.org/r/1037563

gerritbot added a project: Patch-For-Review.May 30 2024, 4:02 PM

Okay, I've got a breakfix patch that guards against the error and logs the rev id. We can then sort out why the revision that triggered the job doesn't seem to exist.

I notice that pretty much all of these errors are happening in non-main namespaces. We check namespace inside the job, but we could also decide not to fire the job at all in non-main namespaces.

Scardenasmolinar moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.May 30 2024, 6:54 PM

Change #1037563 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Error: Call to a member function getSlot() on null

https://gerrit.wikimedia.org/r/1037563

jsn.sherman mentioned this in rEAMO9367e6bba549: Error: Call to a member function getSlot() on null.May 30 2024, 6:55 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).May 30 2024, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 30 2024, 7:31 PM

In T366294#9847263, @Samwalton9-WMF wrote:

@Trizek-WMF might be able to help you get that request moved forward.

Done. :)

jsn.sherman closed this task as Resolved.Jun 10 2024, 2:36 PM

Error: Call to a member function getSlot() on nullClosed, ResolvedPublicPRODUCTION ERRORActions