Page MenuHomePhabricator

Remove operators and functions from abusefilter-edit-builder-* messages
Open, Needs TriagePublicBUG REPORT

Description

Many translatable messages whose keys are abusefilter-edit-builder-* include the operator itself within the message. This is problematic for several reasons:

  1. Some of those operators are incorrectly identified by CI as HTML that has to be manually reviewed in translations (see T358384).
  2. By their nature, they are identical in all the languages, so copying each of them is a waste of translators' time.
  3. In RTL languages, some of them may be displayed incorrectly, especially those that include characters like < and !.

There are workarounds for each of these issues by itself, but given that there are several of them, it would be nice to fix them thoroughly.

A simple solution is to remove the explicit functions and operators from the translatable messages, and to add them automatically in the code. Each message would have ($1) in the end, and the $1 would have the operator or the function wrapped in bidi isolation (they can't use <span dir="ltr"> because they are used in <option>).

Event Timeline

Change #1014119 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/AbuseFilter@master] Reorder messages that describe operators

https://gerrit.wikimedia.org/r/1014119

Change #1014119 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Reorder messages that describe operators

https://gerrit.wikimedia.org/r/1014119