Page MenuHomePhabricator
Create Task
Maniphest T362019

CannotCreateActorException when undeleting a page with IP contributors, with temporary accounts enabled
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Steps to reproduce

  1. With $wgAutoCreateTempUser['enabled'] = false, make a logged out edit to a page
  2. Log in as an admin and delete the page
  3. Set $wgAutoCreateTempUser['enabled'] = true
  4. Try to undelete the page

Expected: the page is successfully undeleted
Actual: CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled

Backtrace:

from /var/www/html/mediawiki/core/includes/user/ActorStore.php(638)
#0 /var/www/html/mediawiki/core/includes/user/ActorStore.php(415): MediaWiki\User\ActorStore->validateActorForInsertion()
#1 /var/www/html/mediawiki/core/includes/Revision/RevisionStore.php(875): MediaWiki\User\ActorStore->acquireActorId()
#2 /var/www/html/mediawiki/core/includes/Revision/RevisionStore.php(760): MediaWiki\Revision\RevisionStore->getBaseRevisionRow()
#3 /var/www/html/mediawiki/core/includes/Revision/RevisionStore.php(626): MediaWiki\Revision\RevisionStore->insertRevisionRowOn()
#4 /var/www/html/mediawiki/core/includes/Revision/RevisionStore.php(477): MediaWiki\Revision\RevisionStore->insertRevisionInternal()
#5 /var/www/html/mediawiki/core/includes/libs/rdbms/database/Database.php(2300): MediaWiki\Revision\RevisionStore->MediaWiki\Revision\{closure}()
#6 /var/www/html/mediawiki/core/includes/libs/rdbms/database/DBConnRef.php(119): Wikimedia\Rdbms\Database->doAtomicSection()
#7 /var/www/html/mediawiki/core/includes/libs/rdbms/database/DBConnRef.php(672): Wikimedia\Rdbms\DBConnRef->__call()
#8 /var/www/html/mediawiki/core/includes/Revision/RevisionStore.php(485): Wikimedia\Rdbms\DBConnRef->doAtomicSection()
#9 /var/www/html/mediawiki/core/includes/page/UndeletePage.php(620): MediaWiki\Revision\RevisionStore->insertRevisionOn()
#10 /var/www/html/mediawiki/core/includes/page/UndeletePage.php(326): MediaWiki\Page\UndeletePage->undeleteRevisions()
#11 /var/www/html/mediawiki/core/includes/page/UndeletePage.php(259): MediaWiki\Page\UndeletePage->undeleteUnsafe()
#12 /var/www/html/mediawiki/core/includes/specials/SpecialUndelete.php(1628): MediaWiki\Page\UndeletePage->undeleteIfAllowed()
#13 /var/www/html/mediawiki/core/includes/specials/SpecialUndelete.php(391): MediaWiki\Specials\SpecialUndelete->undelete()
#14 /var/www/html/mediawiki/core/includes/specialpage/SpecialPage.php(694): MediaWiki\Specials\SpecialUndelete->execute()
#15 /var/www/html/mediawiki/core/includes/specialpage/SpecialPageFactory.php(1669): MediaWiki\SpecialPage\SpecialPage->run()
#16 /var/www/html/mediawiki/core/includes/actions/ActionEntryPoint.php(504): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#17 /var/www/html/mediawiki/core/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#18 /var/www/html/mediawiki/core/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#19 /var/www/html/mediawiki/core/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#20 {main}

Details

SubjectRepoBranchLines +/-
Allow undeletion of IP revisions when temp accounts are enabledmediawiki/coremaster+52 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Apr 7 2024, 8:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2024, 8:35 AM
Tchanders added a comment.Apr 7 2024, 8:43 AM

This could use the same solution as importing, where the actor store is allowed to create IP actors (T354207).

Like import, undelete won't try to create a new IP actor that has never done anything before, so bypassing this error should be safe.

Tchanders added a parent task: T331637: Update features in MediaWiki core for IP Masking.Apr 7 2024, 8:43 AM
Dreamy_Jazz claimed this task.May 22 2024, 4:33 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)); removed Trust and Safety Product Sprint.
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.
gerritbot added a comment.May 22 2024, 4:55 PM

Change #1034985 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Allow undeletion of IP revisions when temp accounts are enabled

https://gerrit.wikimedia.org/r/1034985

gerritbot added a project: Patch-For-Review.May 22 2024, 4:55 PM
Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 22 2024, 8:22 PM
gerritbot added a comment.May 23 2024, 2:37 PM

Change #1034985 merged by jenkins-bot:

[mediawiki/core@master] Allow undeletion of IP revisions when temp accounts are enabled

https://gerrit.wikimedia.org/r/1034985

Maintenance_bot removed a project: Patch-For-Review.May 23 2024, 3:32 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 23 2024, 3:43 PM
dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 24 2024, 12:40 PM
dom_walden subscribed.

I tested undeleting pages with IP edits on my local wiki, enwiki beta and dewiki beta.

In case of regression, I also tested importing pages with IP edits on dewiki beta.

Test environments:

kostajh closed this task as Resolved.May 24 2024, 1:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits