Page MenuHomePhabricator

Use standard deletion tag user talk message templates instead of custom ones
Open, Needs TriagePublic

Assigned To
None
Authored By
Novem_Linguae
Apr 14 2024, 9:00 AM
Referenced Files
F46510507: image.png
Apr 14 2024, 9:00 AM
F46510233: image.png
Apr 14 2024, 9:00 AM
Tokens
"Like" token, awarded by Pppery.

Description

2025 todo list

  • change the majority of {{XYZ-NPF}} templates to {{Db-XYZ}} templates
  • change {{Redirnone-warn-NPF}} (CSD G8) to not notify at all. this is why {{Db-g8-notice}} doesn't exist... because it is not standard to notify for this.
  • change {{Db-author-notice-NPF}} (CSD G7) to not notify at all. this is why {{Db-g7-notice}} doesn't exist... because it is not standard to notify for this.
  • change {{rfd-NPF}}. will need code changes to migrate
  • add support for passing CSD codes to {{Db-notice-multiple}}. this should be easy because we already do this when tagging the article with e.g. {{Db-multiple|G14|G15}}, so the code is capable of outputting the necessary params already. just needs a small modification
  • TFD all the {{XYZ-NPF}} templates
  • if talkpagenotiftopictitle becomes completely unused by any JSON in the PageTriage code, we should delete that codepath to reduce complexity
  • remove message keys containing *-notify-* once they are no longer used, especially *-notify-topic-title

Original ticket

Currently, when tagging for deletion using the Page Curation toolbar, PageTriage leaves a user talk message to the creator of the page, and places custom templates as the message.

For example, placing a CSD A7 leaves this template on the user talk of the creator:

https://en.wikipedia.org/wiki/Template:Db-significance-notice-NPF

image.png (1,476×367 px, 48 KB)

I think the original intent of these was to make nicer/friendlier messages than the defaults, but this has the unfortunate side effect of duplicating work. Now there are 2 of every CSD user talk message template.

This ticket is to think about switching all of these back to the normal defaults, such as...

https://en.wikipedia.org/wiki/Template:Db-significance-notice

image.png (1,523×678 px, 158 KB)

The switch itself wouldn't be too hard. Would just need to update the file modules/ext.pageTriageDefaultTagsOptions/ext.pageTriageDefaultDeletionTagsOptions.js, specifically the lines containing the word talkpagenotiftpl (talk page notification template).

Consensus is being discussed at https://en.wikipedia.org/wiki/Wikipedia_talk:New_pages_patrol/Reviewers#Attention

  • change all the talkpagenotiftpl values
  • see if there's any parameters getting passed to all of the templates. if so, makes sure they are correct
  • do any of the templates take custom parameters? if so make sure we don't break that
  • do the old and new templates handle headings the same way? if one includes headings and the other doesn't, or vice versa, would need to modify some code
  • do the old and new templates handle signatures the same way? if one includes headings and the other doesn't, or vice versa, would need to modify some code

The standard template appears to be {{subst:db-csd-notice-custom|1=Article name|2=X#}} for single, and {{subst:db-notice-multiple|Page title|G11|G12|etc.}} for multiple.

Event Timeline

Change #1221112 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Use community-specific notice templates over NPF ones

https://gerrit.wikimedia.org/r/1221112

Change #1221112 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Use community-specific notice templates over NPF ones

https://gerrit.wikimedia.org/r/1221112