Page MenuHomePhabricator
Create Task
Maniphest T366926

Removing 'topictitle' does not send the message
Open, In Progress, MediumPublic3 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Remove "talkpagenotiftopictitle" parameter from any deletion tag in modules/ext.pageTriage.tagData/deletionTags.json file
  • Now, try nominating an article with that CSD tag using the curation tool.

What happens?:
This completely ignores the "talkpagenotiftpl" parameter and does not send any notification message to the creator.

What should have happened instead?:
When the 'talkpagenotiftopictitle' parameter is not used for a tag, the curation tool should respect the 'talkpagenotiftpl' parameter and send a message to the creator.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Removing 'topictitle' does not send the messagemediawiki/extensions/PageTriagemaster+20 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

DreamRimmer created this task.Fri, Jun 7, 4:22 PM
jsn.sherman triaged this task as Medium priority.Mon, Jun 10, 3:26 PM
jsn.sherman moved this task from Inbox to Triaged on the Moderator-Tools-Team board.
jsn.sherman moved this task from Triaged to To be estimated on the Moderator-Tools-Team board.Mon, Jun 10, 4:08 PM
jsn.sherman set the point value for this task to 3.Tue, Jun 11, 3:27 PM
jsn.sherman moved this task from To be estimated to Up next on the Moderator-Tools-Team board.
jsn.sherman moved this task from Up next to Kanban on the Moderator-Tools-Team board.Tue, Jun 11, 4:12 PM
jsn.sherman edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.Wed, Jun 12, 4:05 PM
Kgraessle updated Other Assignee, added: Kgraessle.
Scardenasmolinar assigned this task to Kgraessle.Wed, Jun 12, 4:18 PM
Scardenasmolinar updated Other Assignee, removed: Kgraessle.
gerritbot added a comment.Wed, Jun 12, 4:43 PM

Change #1042313 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PageTriage@master] Removing 'topictitle' does not send the message

https://gerrit.wikimedia.org/r/1042313

gerritbot added a project: Patch-For-Review.Wed, Jun 12, 4:43 PM
Kgraessle moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Wed, Jun 12, 4:45 PM
Kgraessle moved this task from Code review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Thu, Jun 13, 1:44 PM
Scardenasmolinar moved this task from Reviewed (waiting for changes) to Code review on the Moderator-Tools-Team (Kanban) board.Thu, Jun 13, 8:22 PM
Scardenasmolinar moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Fri, Jun 21, 3:05 AM
gerritbot added a comment.Fri, Jun 21, 3:30 AM

Change #1042313 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Removing 'topictitle' does not send the message

https://gerrit.wikimedia.org/r/1042313

Maintenance_bot removed a project: Patch-For-Review.Fri, Jun 21, 3:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Fri, Jun 21, 4:00 AM
DreamRimmer closed this task as Resolved.Fri, Jun 21, 4:01 AM
Scardenasmolinar reopened this task as In Progress.Fri, Jun 21, 4:04 AM
Scardenasmolinar subscribed.

Hi, @DreamRimmer! I am going to unresolve this until next week's train where we can test that the bug is not occurring anymore. Unless you can test it on Beta and you are confident that the bug fix works, you can mark it as resolved again. Thanks for catching this bug!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL