Wikipedia Preview Change icon adding a new preview set
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	GMikesell-WMF
	Apr 26 2024, 5:49 PM

Description

Steps to replicate the issue (include links if applicable):
When I click on the Change Icon, it jumps to the beginning of the paragraph.

Select the word "association"
Click the Wikipedia Preview icon and select "Association Football"
Wikipedia preview pops up for Association Football and I selected the "Change" icon
Type any word (ex. dog breed) and click on it for the change for the new Wikipedia Preview link

What happens?:

It then jumps to the beginning of the paragraph acting like it's a new Wikipedia preview word when it should have just changed the link for "association".

What should have happened instead?:

Stay with the word selected (ex. association) and just have a different link for the Wikipedia preview

Other information (browser name/version, screenshots, etc.):
Environment: WordPress Dev- 6.5; Wikipreview: 1.12.0; Commit: 72f4c09a097ddeb58e96d82e411a53cb43c77a10, Fri Apr 5 12:38:09 2024 -0400
OS: macOS Sonoma 14.2
Browser: Chrome 123

Task Description:

QA Results - WordPress Dev

AC	Status	Details
1	✅	T363600#9791652

Related Objects

Mentioned In: T361827: Support Wordpress 6.5

Event Timeline

GMikesell-WMF created this task.Apr 26 2024, 5:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2024, 5:49 PM

GMikesell-WMF mentioned this in T361827: Support Wordpress 6.5.Apr 26 2024, 10:59 PM

SBisson moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.Apr 30 2024, 2:05 PM

eamedina claimed this task.Apr 30 2024, 3:13 PM

eamedina moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

SBisson triaged this task as Medium priority.May 1 2024, 12:53 AM

eamedina moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.May 8 2024, 1:17 AM

PR under review - https://github.com/wikimedia/wikipediapreview-wordpress/pull/116

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.May 10 2024, 1:22 PM

@eamedina I'm still coming across the same issue as seen in the gif below.

Status: ❌ FAIL
Environment: WordPress Dev- 6.5.3; Wikipreview: 1.10.0; Commit: d4cbaf60aaef02c00441354c9a3704a6c921410f, Tue May 7 21:44:02 2024 +0800
OS: macOS Sonoma 14.4.1
Browser: Chrome 124
Skins.N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:10018/wp-admin/post.php?post=27&action=edit

❌AC1: https://phabricator.wikimedia.org/T363600

2024-05-10_15-19-40 (1).gif (1×2 px, 2 MB)

GMikesell-WMF updated the task description. (Show Details)May 10 2024, 10:25 PM

@eamedina The Change icon works as designed as seen in the video below now. It no longer jumps to the beginning of the paragraph when changing the link. I will move this to Design sign-off. Thanks for all your work!

Status: ✅PASS
Environment: WordPress Dev- 6.5.3; Wikipreview: 1.10.0; Commit: 56c2041c49a156009eed6ca0c4b642d73036b040, Thu May 9 22:07:30 2024 -0400
OS: macOS Sonoma 14.4.1
Browser: Chrome 124, Firefox 125, Safari 17.4.1
Skins.N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:10018/wp-admin/post.php?post=27&action=edit

✅AC1: https://phabricator.wikimedia.org/T363600

GMikesell-WMF updated the task description. (Show Details)May 13 2024, 6:23 PM

GMikesell-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.May 20 2024, 6:41 AM

PWaigi-WMF closed this task as Resolved.May 23 2024, 12:30 PM

Wikipedia Preview Change icon adding a new preview setClosed, ResolvedPublicBUG REPORTActions

Description

QA Results - WordPress Dev

Related Objects

Event Timeline

Wikipedia Preview Change icon adding a new preview set
Closed, ResolvedPublicBUG REPORT
Actions