Page MenuHomePhabricator
Create Task
Maniphest T363942

Commons view search field not displaying within Image Recs
Open, LowPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Open "add an image"
    • Open image file name to view Commons listing
    • Search

What happens?:
Search bar is not visible

IMG_6149.PNG (2×1 px, 60 KB)

What should have happened instead?:
Functionality matches elsewhere in the app (search bar is visible and focused):

IMG_6148.PNG (2×1 px, 211 KB)

Engineering Notes

The app contains a mixture of custom navigation bars (added manually in the base superclass ViewController.swift) and system navigation bars. We usually try to use the default system navigation bar if possible, unless some special behavior is needed where we resort to hiding the system bar and using the custom bar. It is likely that this bug is the result of a missing call to hide or show the system navigation bar:

navigationController?.setNavigationBarHidden(false or true, animated: false).

Related Objects
Search...

Event Timeline

HNordeenWMF created this task.Wed, May 1, 8:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, May 1, 8:44 PM
HNordeenWMF mentioned this in T358913: [S] Open Image's Commons page in Webview for Image Recs.Wed, May 1, 8:45 PM
HNordeenWMF mentioned this in T364157: [Sub Epic] Clean up tasks for Image Recs V2.Fri, May 3, 5:04 PM
HNordeenWMF edited parent tasks, added: T364157: [Sub Epic] Clean up tasks for Image Recs V2; removed: T358913: [S] Open Image's Commons page in Webview for Image Recs.Fri, May 3, 5:06 PM
Tsevener added a project: good first task.Tue, May 7, 7:52 PM
Restricted Application added a comment. · View Herald TranscriptTue, May 7, 7:52 PM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

JTannerWMF triaged this task as Low priority.Tue, May 7, 7:53 PM
JTannerWMF moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
Tsevener updated the task description. (Show Details)Tue, May 7, 8:58 PM
varaniOS claimed this task.Fri, May 17, 9:20 PM
varaniOS added a comment.Fri, May 17, 9:23 PM

Hi all! First timer here, love the app and just found today it is open-sourced (of course!) :)

Opened this PR with the fix for this issue.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL