Page MenuHomePhabricator

Adjust spacing on special:AllEvents
Open, Needs TriagePublic

Description

increase spacing between each event item and also between the Meeting type and Organizer, to match designs here:
Figma

Event Timeline

Change #1030058 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Add spacing to match designs on Special:AllEvents

https://gerrit.wikimedia.org/r/1030058

Decision from today's design + engineering meeting: we will use the same spacing (@spacing-125 = 20px) on both desktop and mobile between the day and the rest of the card, to avoid excessive blank space as can be seen in F51815230 and F51815313.

Change #1030058 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add spacing to match designs on Special:AllEvents

https://gerrit.wikimedia.org/r/1030058

@MHorsey-WMF the figma file linked in the task description has the Meeting type and Organizer on separate lines. I think the spacing issues that existed between Meeting type and Organizer might just be solved by a different layout now?

@MHorsey-WMF the figma file linked in the task description has the Meeting type and Organizer on separate lines. I think the spacing issues that existed between Meeting type and Organizer might just be solved by a different layout now?

That seems to be for the new version with multiple organizers that we will implement in T363863. I've asked about it in T363863#9831293, but either way, I don't think it should affect this task.

@MHorsey-WMF the figma file linked in the task description has the Meeting type and Organizer on separate lines. I think the spacing issues that existed between Meeting type and Organizer might just be solved by a different layout now?

That seems to be for the new version with multiple organizers that we will implement in T363863. I've asked about it in T363863#9831293, but either way, I don't think it should affect this task.

Okay, I am going to send this to design sign off then.