Page MenuHomePhabricator
Create Task
Maniphest T364621

Represent the selected topic and language pair as URL parameters
Open, HighPublic
Actions

Assigned To
ngkountas
Authored By
Pginer-WMF
May 10 2024, 12:22 PM
Tags
Referenced Files
F54961800: Screenshot 2024-06-06 at 11.21.37.png
Thu, Jun 6, 9:22 AM
F54901914: Screenshot 2024-06-03 at 14.19.54.png
Mon, Jun 3, 12:20 PM
F54428173: mint_mvp_auto_trans_translate_link.webm
Mon, May 27, 4:21 AM
Subscribers
Aklapper
EChukwukere-WMF
EditingPencil
ngkountas
Pginer-WMF
UOzurumba

Description

As part of MinT for Wikipedia Readers MVP (T359072) access is provided to machie translated version of the content. This can be used in very different contexts, and we want to support users to share translations, link to them in wiki pages or integrate them in external tools.

Currently it is not possible to link to a specific translation since the different aspects of the translation are not reflected in the URL. This ticket proposes to support users to link to the Confirm (T359512) or the Translation View (T359801) directly. by provide URL parameters.

Proposed parameters:

  • topic/page. The page to translate. We can decide how much to the current search flexibility we can expose and how much we want the parameter to align with the one used in Content Translation ("page") or differ from it if it ("topic") works differently.
  • from. Language code of the source language. If missing or invalid, destination will be the Confirm step for the user to select one.
  • to. Language code of the target language. If missing or invalid, destination will be the Confirm step for the user to select one.
  • confirm. Indicates that the Confirm step will be the destination to allow users to make final adjustments before reaching the translated content.

Details

SubjectRepoBranchLines +/-
MinT: Remove display URL parammediawiki/extensions/ContentTranslationmaster+5 -7
MinT: Simplify pageSearchResult sourceTitle gettermediawiki/extensions/ContentTranslationmaster+3 -4
MinT MVP: Redirect to confirm/translation page based on URL paramsmediawiki/extensions/ContentTranslationmaster+64 -3
MinT MVP: Add URL paramsmediawiki/extensions/ContentTranslationmaster+40 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF triaged this task as High priority.May 10 2024, 12:22 PM
Pginer-WMF created this task.
Pginer-WMF moved this task from Backlog to Product integration on the MinT board.
Pginer-WMF moved this task from Quarter Backlog to Priority: Translation on the Language-Team (Language-2024-April-June) board.
ngkountas claimed this task.May 13 2024, 6:11 PM
gerritbot added a comment.May 13 2024, 6:11 PM

Change #1031037 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] MinT MVP: Add URL params

https://gerrit.wikimedia.org/r/1031037

gerritbot added a project: Patch-For-Review.May 13 2024, 6:11 PM

Change #1031038 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] MinT MVP: Redirect to confirm/translation page based on URL params

https://gerrit.wikimedia.org/r/1031038

ngkountas moved this task from Priority: Translation to In Review on the Language-Team (Language-2024-April-June) board.May 13 2024, 6:11 PM
gerritbot added a comment.May 14 2024, 5:27 AM

Change #1031037 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] MinT MVP: Add URL params

https://gerrit.wikimedia.org/r/1031037

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 14 2024, 6:00 AM
gerritbot added a comment.May 15 2024, 6:56 AM

Change #1031038 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] MinT MVP: Redirect to confirm/translation page based on URL params

https://gerrit.wikimedia.org/r/1031038

Maintenance_bot removed a project: Patch-For-Review.May 15 2024, 7:30 AM
ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2024-April-June) board.Wed, May 15, 10:21 AM
Pginer-WMF added a parent task: T359801: MinT MVP: Translation view.Tue, May 21, 3:42 PM
ngkountas moved this task from Check after deployment to Needs QA on the Language-Team (Language-2024-April-June) board.Wed, May 22, 8:34 AM
EChukwukere-WMF subscribed.Mon, May 27, 4:21 AM

@ngkountas I did test but I want to make sure my approach is correct. This is to get to the confirm translation page by not searching for the article but using a link to the page ?

see video below:

EChukwukere-WMF moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2024-April-June) board.Mon, May 27, 4:21 AM
ngkountas added a comment.Thu, May 30, 10:21 AM

As indicated by the screencast above, the following URL parameters are being set when an article is selected inside the search screen:

  • page (title of the page in display language)
  • from (source language of the translation)
  • to (target language of the translation)
  • display (language in which the search result is being displayed. Also the language in which the page title is provided in the URL)
  • step (the current step - can be either "confirm" or "translation")

Based on the above, I believe we can close this task as done.

ngkountas moved this task from Pending input for QA to Done on the Language-Team (Language-2024-April-June) board.Thu, May 30, 10:22 AM
EChukwukere-WMF added a comment.Fri, May 31, 5:08 AM

Thanks for confirming @ngkountas !

Pginer-WMF added a comment.Mon, Jun 3, 12:20 PM
In T364621#9845813, @ngkountas wrote:
  • page (title of the page in display language)
  • display (language in which the search result is being displayed. Also the language in which the page title is provided in the URL)

I'm curious about the use of the display language. If I understand this correctly, the display parameter is basically indicating which language is used for the search of the topic. For example, in the URL below the term "Sonne" is searched in German to find the article about the Sun, and the French version of it is used to show an automatic translation into Japanese:

https://en.m.wikipedia.org/wiki/Special:AutomaticTranslation?page=Sonne&from=fr&to=ja&display=de&step=confirm

Am I interpreting the above correctly? The "display" name was a bit confusing since nothing is displayed in that language. So I wanted to double-check it is working as I was interpreting.

Taking the above example, and changing the to parameter to German, results in an empty page: https://en.m.wikipedia.org/wiki/Special:AutomaticTranslation?page=Sonne&from=de&to=ja&display=de&step=confirm

Screenshot 2024-06-03 at 14.19.54.png (787×1 px, 185 KB)

I would expect the display parameter to be optional, taking the value of the from language as a fallback when display is not provided. Not sure if that was intended in the implementation since I could not check it as per the baove.

gerritbot added a comment.Wed, Jun 5, 5:09 PM

Change #1039254 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] MinT: Make display URL param optional for redirection to "confirm" step

https://gerrit.wikimedia.org/r/1039254

gerritbot added a project: Patch-For-Review.Wed, Jun 5, 5:09 PM
ngkountas moved this task from Done to In Review on the Language-Team (Language-2024-April-June) board.Thu, Jun 6, 8:11 AM
Pginer-WMF added a comment.EditedThu, Jun 6, 9:22 AM

I found some cases where reaching the Translation view through the UI results in an URL that when reloading the browser page shows a blank page with JS errors. For example: https://ca.m.wikipedia.org/wiki/Special:AutomaticTranslation?page=Plants+in+space&from=en&to=ca&display=en&step=translation

Screenshot 2024-06-06 at 11.21.37.png (711×1 px, 159 KB)

ngkountas added a comment.Thu, Jun 6, 12:45 PM

@Pginer-WMF this happens when "display" language is the same as the source language. I have submitted a patch that fixes this case, but even more I have submitted another patch (linked to this task), that entirely removes the "display" language, since as you observed, it's not used anywhere, and we can just rely on the source language and title.

gerritbot added a comment.Thu, Jun 6, 3:51 PM

Change #1039252 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] MinT: Simplify pageSearchResult sourceTitle getter

https://gerrit.wikimedia.org/r/1039252

gerritbot added a comment.Fri, Jun 7, 4:18 AM

Change #1039252 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] MinT: Simplify pageSearchResult sourceTitle getter

https://gerrit.wikimedia.org/r/1039252

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.9; 2024-06-11); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).Fri, Jun 7, 5:00 AM
gerritbot added a comment.Fri, Jun 7, 5:54 AM

Change #1039254 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] MinT: Remove display URL param

https://gerrit.wikimedia.org/r/1039254

Maintenance_bot removed a project: Patch-For-Review.Fri, Jun 7, 6:30 AM
ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2024-April-June) board.Thu, Jun 13, 10:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL