Page MenuHomePhabricator
Create Task
Maniphest T365191

Marking a page for translation "removed priority languages" even if there never were any
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Mark a page for translation

What happens?:

It says "foo removed priority languages from translatable page bar" even if there never were any priority languages

What should have happened instead?:

No such log entry

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

https://www.mediawiki.org/w/index.php?title=Special:Log&page=Template%3AOnWikimedia

Details

SubjectRepoBranchLines +/-
TranslatablePageMarker: Fix check to detect metadata changemediawiki/extensions/Translatemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Pppery created this task.May 16 2024, 6:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2024, 6:39 PM
Justman10000 subscribed.May 17 2024, 1:14 PM

That's right, I noticed that too! I was already wondering

Nikerabbit added subscribers: abi_, Nikerabbit.May 17 2024, 1:18 PM

@abi_ we didn't run the cleanup script yet, did we?

Pols12 added a project: Regression.May 19 2024, 6:18 PM
Pols12 subscribed.

For reference:
Regression from MW-1.43-notes (1.43.0-wmf.5; 2024-05-14) (see logs).
Due to e5488062 for T362811.

abi_ added a comment.May 20 2024, 4:43 AM
In T365191#9808629, @Nikerabbit wrote:

@abi_ we didn't run the cleanup script yet, did we?

No, not yet. I'll start running them today.

gerritbot added a comment.May 20 2024, 6:40 AM

Change #1033868 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Fix check to detect metaata change

https://gerrit.wikimedia.org/r/1033868

gerritbot added a project: Patch-For-Review.May 20 2024, 6:40 AM
abi_ claimed this task.May 20 2024, 6:42 AM
abi_ triaged this task as Medium priority.
abi_ moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.
abi_ added projects: Language-Team (Language-2024-April-June), Localization Infrastructure FY2023-24, Unplanned-Sprint-Work.
abi_ set the point value for this task to 1.
In T365191#9811651, @abi_ wrote:
In T365191#9808629, @Nikerabbit wrote:

@abi_ we didn't run the cleanup script yet, did we?

No, not yet. I'll start running them today.

Just a note that this issue is not a result of not running that script.

abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2024-April-June) board.May 20 2024, 9:51 AM
gerritbot added a comment.May 20 2024, 1:24 PM

Change #1033868 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Fix check to detect metadata change

https://gerrit.wikimedia.org/r/1033868

Maintenance_bot removed a project: Patch-For-Review.May 20 2024, 1:32 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 20 2024, 2:00 PM
abi_ closed this task as Resolved.May 22 2024, 5:12 AM
abi_ moved this task from In Review to Done on the Language-Team (Language-2024-April-June) board.

Looking at https://www.mediawiki.org/wiki/Special:Log?type=pagetranslation&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers&wpFormIdentifier=logeventslist; after the latest deployment, I don't see any more instances of the an incorrect log entry mentioning removal of priority languages.

image.png (1×1 px, 366 KB)

Nikerabbit moved this task from Backlog to Translatable pages (LH1) on the Localization Infrastructure FY2023-24 board.Thu, May 30, 12:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL