Page MenuHomePhabricator

Archive the service-scaffold-node and service-scaffold-golang libraries
Open, Needs TriagePublicRequest

Description

Reason
service-scaffold-golang and service-scaffold-node were attempts to replace service-template-node.

They had some work in 2021/2022, but are incomplete, have been completely broken and unusable, with commits force-merged right from the start – even the patch adding CI to the node repo. They depend on npm packages etc. that don't exist, so fail even to build (and if you comment those out still breaks with other issues), and has had no development since the brief run back then. It causes confusion and leads to people trying to fix it – T365063: mediawiki/services/service-scaffold-node CI is broken. Let's just drop it.

To-do list

Event Timeline

Change #1034549 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/service-scaffold-node@main] Empty repo

https://gerrit.wikimedia.org/r/1034549

Sounds good to me. service-scaffold-node was started to turn service-template-node into a group of libraries and is basically superseded by my effort to replace service-runner (T360924) which is mostly completed

Change #1035057 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Archive mediawiki/services/service-scaffold-{node,golang}

https://gerrit.wikimedia.org/r/1035057

Change #1035058 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Drop {trigger-,}service-scaffold-node-test, unused

https://gerrit.wikimedia.org/r/1035058

Change #1034549 merged by Jforrester:

[mediawiki/services/service-scaffold-node@main] Empty repo

https://gerrit.wikimedia.org/r/1034549

Change #1035060 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/service-scaffold-golang@master] Empty repo

https://gerrit.wikimedia.org/r/1035060

Change #1035060 merged by Jforrester:

[mediawiki/services/service-scaffold-golang@master] Empty repo

https://gerrit.wikimedia.org/r/1035060

Change #1035057 merged by jenkins-bot:

[integration/config@master] Zuul: Archive mediawiki/services/service-scaffold-{node,golang}

https://gerrit.wikimedia.org/r/1035057

Mentioned in SAL (#wikimedia-releng) [2024-05-22T23:02:35Z] <James_F> Zuul: Archive mediawiki/services/service-scaffold-{node,golang} for T365512

Change #1035058 merged by jenkins-bot:

[integration/config@master] jjb: Drop {trigger-,}service-scaffold-node-pipeline-test, now unused

https://gerrit.wikimedia.org/r/1035058

@Nikerabbit Yea, I meant to tag you for visibility, I don't think there is any action to take on your end outside of awareness. We had talked about this ticket in our team meeting and Daniel mentioned that language team should be aware of node scaffold changes. It is on our radar column.

Final step needs a gerrit admin.

Getting rid of service-scaffold-node also means we should get rid of servicelib-node since it was created for service-scaffold node (this is the reason why service-scaffold node depends on packages that don't exist. This project never finished)