Page MenuHomePhabricator

Update Revision Tags and stop using edit summaries batch 1
Closed, ResolvedPublic

Description

Background
We need to migrate from using edit summaries for data to using tags. This must be done in phases to ensure we do not overburden our servers. This is 1/3 tasks. The Android team is responsible for deploying the tags of this particular ticket. iOS will need to switch over to the tags and stop using the edit summary for the task to be considered complete.

Task
Implement lines 3-10 from spreadsheet.

Requirements

  • Android team Deploy Tags
  • Android team stop using edit summaries for these set of tags
  • iOS stop using edit summaries for these set of tags
  • MediaWiki page is updated to include tags (@SNowick_WMF)

Event Timeline

JTannerWMF triaged this task as High priority.
JTannerWMF set Due Date to Jun 19 2024, 4:00 AM.
JTannerWMF added a subscriber: SNowick_WMF.
cooltey subscribed.

Change #1041791 had a related patch set uploaded (by Dbrant; author: Dbrant):

[mediawiki/extensions/MobileApp@master] [WIP] Add API parameter for proxying tags to add to edits.

https://gerrit.wikimedia.org/r/1041791

Change #1041791 merged by jenkins-bot:

[mediawiki/extensions/MobileApp@master] Add API parameter for proxying tags to add to edits.

https://gerrit.wikimedia.org/r/1041791

Change #1046801 had a related patch set uploaded (by Dbrant; author: Dbrant):

[mediawiki/extensions/MobileApp@master] Add i18n messages for new tags.

https://gerrit.wikimedia.org/r/1046801

Change #1046801 merged by Cooltey:

[mediawiki/extensions/MobileApp@master] Add i18n messages for new tags.

https://gerrit.wikimedia.org/r/1046801

@cooltey This is now ready to be picked up. The initial batch of tags is now available and usable on testwiki.

The new tags can now be appended to any of the API calls that we make, by adding an optional parameter called matags=... with a comma-separated list of tags.
So for example, when calling action=edit to add a description to an article from Suggested Edits, you can add &matags=app-suggestededit,app-description-add, and so on.

JTannerWMF changed Due Date from Jun 19 2024, 4:00 AM to Jun 27 2024, 4:00 AM.Jun 25 2024, 9:24 PM

Hi @SNowick_WMF

Just found the following three edit summaries that are not documented in the spreadsheet, do we want to include those as well?

Direct reply from the Notification bar
#directreply-1.0    // This is not being implemented but maybe will be implemented in the future

Machine-generated article descriptions
#machine-suggestion
#machine-suggestion-modified

And just FYI, I cannot find any usage of #app-desc-change, which will be replaced by the edit tag app-description-change.

@Dbrant The only thing that's a little funky from my testing is changing a wikidata description, but I tested this against Test Wikidata so that could be why if something isn't deployed there yet.

I faked an update to these items from our article description update page (i.e. not a suggested edits flow).

https://test.wikidata.org/w/index.php?title=Q168439&action=history
https://test.wikidata.org/w/index.php?title=Q2027&action=history

I'm certain I didn't add that Suggested Edits edit tag - is that being automatically added by the extension somehow?

@Dbrant The only thing that's a little funky from my testing is changing a wikidata description, but I tested this against Test Wikidata so that could be why if something isn't deployed there yet.
I faked an update to these items from our article description update page (i.e. not a suggested edits flow).
I'm certain I didn't add that Suggested Edits edit tag - is that being automatically added by the extension somehow?

Ah yes, it looks like the Suggested Edits edit is an unrelated tag that gets added by the WikimediaEditorTasks extension.
This shouldn't be a concern for our current work, but we should probably make a decision to take ownership of that extension, and decide its future (I'll add an agenda item).

New tags on iOS:

'app-undo',
'app-rollback',
'app-description-add',
'app-description-change'

@ABorbaWMF To test for iOS, please undo and rollback edits via our diff screen. Confirm the edit on Desktop no longer appends a hashtag to the edit summary, and instead adds the applicable edit tag.

The same is needed for both updating and adding an article description, but those are more difficult for me to test on Test Wiki (Test Wiki doesn't show an "Add article description" callout, so you can only change existing descriptions). It may be better to wait until the server-side changes are deployed across Wikis before testing those. Note you will need to test adding and changing a description, on both EN and non-EN Wikis.

It may be better to wait until the server-side changes are deployed across Wikis before testing those.

@ABorbaWMF FYI, server-side changes are now deployed across Wikis.

Looks fixed to me based on testing a bit on Test.wiki and adding some descriptions on en.wiki on 7.5.4 (3671)

HNordeenWMF subscribed.

Added & updated a description on en wiki:

Screenshot 2024-07-02 at 12.49.52 PM.png (196×2 px, 108 KB)

Undo & rollback on test wiki:
Screenshot 2024-07-02 at 12.50.07 PM.png (106×1 px, 54 KB)

Screenshot 2024-07-02 at 12.50.20 PM.png (90×2 px, 54 KB)

Yes I think so. I'm having trouble with an edit not showing up in edit history on test.wiki, but the edit worked. I did some testing on en.wiki as well. Looks good on 2.7.50493-beta-2024-07-01

HNordeenWMF reopened this task as Open.EditedJul 8 2024, 3:52 PM

Sorry for resolving early.
@SNowick_WMF is the media wiki page updated to include these tags?

Don't worry I can close this one since its Android led @HNordeenWMF , feel free to take the lead on Batch 2.

Validating we are seeing the following revision tag values in Enwiki revision edit data as of 2024-07-18.

Android:
app-suggestededit
app-description-add
app-description-change
app-description-translate
app-undo
app-rollback

iOS:
app-description-add
app-description-change
app-full-source
app-section-source
app-undo
app-rollback