Vector 2022: VisualEditor toolbar and overlays should appear in night theme
Open, HighPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Wed, Jun 5, 6:15 PM

Description

Background

VisualEditor toolbar and overlays currently appears in the light theme. This is done via a rule inside the Vector skin. Removing this uncovers over issues. I cannot see a short term fix using invert that can be applied here, given VisualEditor itself is embedded in the page.

User story

As a reader I want my editor in night theme.

Requirements

OOUI has support for night theme.
T365764 has been fixed.

Acceptance criteria

Fix all issues defined in the scope section that result from enabling OOUI's night theme are fixed.
The notheme class is removed from Vector and VisualEditor is opted into night theme with a note that we have approval from Olga/Editing team that this is "shippable".
Fixing any issues with input elements which are using light theme e.g. musical notation/add code/chemical formulation are out of scope for this ticket - as they require changes in other extensions.

NOTE: If we do find another major issue that is not documented here, we will create another ticket and descope AC 2.

Scope

Fix the omega menu

Fix unreadable warning text in citation, template workflows

Screenshot 2024-06-12 at 4.36.37 PM.png (600×1 px, 125 KB)

Screenshot 2024-06-12 at 4.38.23 PM.png (466×1 px, 53 KB)

Fix gallery caption

Screenshot 2024-06-12 at 4.39.45 PM.png (854×1 px, 95 KB)

Invert images in chemical and math formula areas.

Screenshot 2024-06-12 at 4.41.18 PM.png (286×1 px, 41 KB)

Out of scope

T367373
T365311 (T367371)

Communication criteria - does this need an announcement or discussion?

N/A

Rollback plan

N/A

This task was created by Version 1.0.0 of the Web team task template using phabulous

Details

	Subject	Repo	Branch	Lines +/-
	Remove OOUI overrides	mediawiki/skins/Vector	master	+3 -21
	Enable night mode in VisualEditor	mediawiki/skins/Vector	master	+3 -21

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		Jdrewniak	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Open		Jdrewniak	T341632 [EPIC] Palette customizations and dark mode
Open		None	T367150 Deploy dark mode to logged-out users on the Vector2022 skin
Resolved		ovasileva	T366738 ULS should have a dark theme
Open		None	T365509 [GOAL] Talk page namespaces should not be excluded from night theme
Open		GMikesell-WMF	T366737 Vector 2022: VisualEditor toolbar and overlays should appear in night theme
Duplicate	BUG REPORT	None	T367371 VisualEditor when using CodeMirror syntax highlighting is unreadable in dark mode

Event Timeline

Jdlrobson created this task.Wed, Jun 5, 6:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jun 5, 6:15 PM

Jdlrobson triaged this task as High priority.Wed, Jun 5, 6:15 PM

Jdlrobson moved this task from Backlog to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.

Jdlrobson claimed this task.Thu, Jun 6, 5:42 PM

Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q4 Sprint 6).

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T365764: [OOUI] Icons: Add support for use in dark mode.Thu, Jun 6, 5:49 PM

Jdlrobson renamed this task from VisualEditor toolbar and overlays should appear in night theme to Vector 2022: VisualEditor toolbar and overlays should appear in night theme.Thu, Jun 6, 6:04 PM

Change #1039804 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: Enable night mode in VisualEditor

https://gerrit.wikimedia.org/r/1039804

gerritbot added a project: Patch-For-Review.Thu, Jun 6, 6:13 PM

Jdlrobson added a subtask: T367371: VisualEditor when using CodeMirror syntax highlighting is unreadable in dark mode.Wed, Jun 12, 11:34 PM

I've scoped this down as much as I possibly can for estimation by prioritizing the broken experiences. It would be nice to get this in before Monday if possible - since this regresses the editor in several places based on how it currently works...

Jdlrobson removed Jdlrobson as the assignee of this task.Wed, Jun 12, 11:48 PM

Jdlrobson mentioned this in T365509: [GOAL] Talk page namespaces should not be excluded from night theme.Thu, Jun 13, 3:50 PM

Jdlrobson added a parent task: T365509: [GOAL] Talk page namespaces should not be excluded from night theme.

Jdlrobson updated the task description. (Show Details)Thu, Jun 13, 6:08 PM

Jdlrobson set the point value for this task to 3.

ovasileva moved this task from Ready for estimation to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Mon, Jun 17, 11:24 AM

ovasileva moved this task from Ready for Development to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

bwang moved this task from Ready for estimation to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Mon, Jun 17, 5:56 PM

Test wiki created on Patch demo by JDrewniak (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7d24f5ac63/w

@Jdlrobson @Jdrewniak assuming it's fine for me to pick this up

Yep! with caveat, we may need to block merging this on T366197 if we discover the scope is not enough to make it "shippable" :-).

Sounds good! Currently struggling to even get the extension set up locally, so we'll cross that bridge when we get to it haha

ovasileva moved this task from Doing to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Tue, Jun 18, 4:24 PM

SToyofuku-WMF removed SToyofuku-WMF as the assignee of this task.Tue, Jun 18, 5:10 PM

Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 20, 4:33 PM

Jdlrobson claimed this task.Thu, Jun 20, 4:43 PM

Once https://phabricator.wikimedia.org/T366197 is merged, we can merge this patch. After this we'll need to QA this change

The VE submodule in Extension:VisualEditor has just been merged https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1048001
So the following patch that removes the .notheme class from VE in Vector is ready to be reviewed now :)
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1039804

Change #1048049 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove OOUI popup from OOUI overrides in order to enable dark mode in echo

https://gerrit.wikimedia.org/r/1048049

Change #1039804 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Enable night mode in VisualEditor

Reason:

Merged into https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1048049?usp=search

https://gerrit.wikimedia.org/r/1039804

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 20, 6:40 PM

Change #1048049 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove OOUI overrides