Page MenuHomePhabricator

Vector 2022: VisualEditor toolbar and overlays should appear in night theme
Open, HighPublic3 Estimated Story Points



VisualEditor toolbar and overlays currently appears in the light theme. This is done via a rule inside the Vector skin. Removing this uncovers over issues. I cannot see a short term fix using invert that can be applied here, given VisualEditor itself is embedded in the page.

User story

As a reader I want my editor in night theme.


  • OOUI has support for night theme.
  • T365764 has been fixed.

Acceptance criteria

  • Fix all issues defined in the scope section that result from enabling OOUI's night theme are fixed.
  • The notheme class is removed from Vector and VisualEditor is opted into night theme with a note that we have approval from Olga/Editing team that this is "shippable".
  • Fixing any issues with input elements which are using light theme e.g. musical notation/add code/chemical formulation are out of scope for this ticket - as they require changes in other extensions.
NOTE: If we do find another major issue that is not documented here, we will create another ticket and descope AC 2.


  • Fix the omega menu

Screenshot 2024-06-12 at 4.36.06 PM.png (354×1 px, 56 KB)

  • Fix unreadable warning text in citation, template workflows

Screenshot 2024-06-12 at 4.36.37 PM.png (600×1 px, 125 KB)

Screenshot 2024-06-12 at 4.38.23 PM.png (466×1 px, 53 KB)

  • Fix gallery caption

Screenshot 2024-06-12 at 4.39.45 PM.png (854×1 px, 95 KB)

  • Invert images in chemical and math formula areas.

Screenshot 2024-06-12 at 4.41.18 PM.png (286×1 px, 41 KB)

Out of scope

Communication criteria - does this need an announcement or discussion?


Rollback plan


This task was created by Version 1.0.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson renamed this task from VisualEditor toolbar and overlays should appear in night theme to Vector 2022: VisualEditor toolbar and overlays should appear in night theme.Thu, Jun 6, 6:04 PM

Change #1039804 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: Enable night mode in VisualEditor

I've scoped this down as much as I possibly can for estimation by prioritizing the broken experiences. It would be nice to get this in before Monday if possible - since this regresses the editor in several places based on how it currently works...

Jdlrobson set the point value for this task to 3.

Test wiki created on Patch demo by JDrewniak (WMF) using patch(es) linked to this task:

Yep! with caveat, we may need to block merging this on T366197 if we discover the scope is not enough to make it "shippable" :-).

Sounds good! Currently struggling to even get the extension set up locally, so we'll cross that bridge when we get to it haha

Once is merged, we can merge this patch. After this we'll need to QA this change

The VE submodule in Extension:VisualEditor has just been merged
So the following patch that removes the .notheme class from VE in Vector is ready to be reviewed now :)

Change #1048049 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove OOUI popup from OOUI overrides in order to enable dark mode in echo

Change #1039804 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Enable night mode in VisualEditor


Merged into

Change #1048049 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove OOUI overrides