Gender cache is not filled (via Thanks\Hooks::generateThankElement)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Tue, Jun 11, 1:01 PM

Description

Similarly to T367172: Watchlist formatter is doing a user edit count database query in every row of the result inspecting Special:Watchlist that has gotten quite slow recently shows that 13% of loading watchlist page is being spent on doing database query: https://performance.wikimedia.org/excimer/profile/0a96d7cc5babe7eb

XhGui says MediaWiki\Cache\GenderCache::doQuery is getting called 97 times in one request: https://performance.wikimedia.org/xhgui/run/symbol?id=6668463540e83c26e289c1da&symbol=MediaWiki%5CCache%5CGenderCache%3A%3AdoQuery the caching seems to be clearly broken.

Stacktrace:

Details

	Subject	Repo	Branch	Lines +/-
	Add BatchLookups on HistoryPager and ChangesList	mediawiki/extensions/Thanks	master	+34 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T341319 RecentChanges: Improve performance of Special:RecentChanges rendering
		Resolved		Umherirrender	T367175 Gender cache is not filled (via Thanks\Hooks::generateThankElement)

Event Timeline

Ladsgroup created this task.Tue, Jun 11, 1:01 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptTue, Jun 11, 1:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ladsgroup triaged this task as Medium priority.Tue, Jun 11, 1:06 PM

Ladsgroup updated the task description. (Show Details)

Ladsgroup moved this task from Triage to In progress on the DBA board.

Ladsgroup mentioned this in T363622: Watchlist times out.Tue, Jun 11, 1:11 PM

Michael moved this task from Inbox to Triaged on the Growth-Team board.Tue, Jun 11, 5:58 PM

Works when the content language distinct gender as LinkBatch prefills the GenderCache. But for languages without gender support the cache must not done any query.

LinkBatch::doGenderQuery skips the gender cache, as gender is not needed to get the namespace prefix of the title. But Thanks is using GenderCache::getGenderOf and that also query on en.

Since 012a387587d56e92542265c4d597806d5c629542 the thanks links seems to show on Special:Watchlist and does this query.

Change #1041764 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Thanks@master] Add BatchLookups on HistoryPager and ChangesList

https://gerrit.wikimedia.org/r/1041764

gerritbot added a project: Patch-For-Review.Tue, Jun 11, 8:04 PM

Change #1041764 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Add BatchLookups on HistoryPager and ChangesList

https://gerrit.wikimedia.org/r/1041764

Umherirrender renamed this task from Gender cache is not caching to Gender cache is not filled (via Thanks\Hooks::generateThankElement).Tue, Jun 11, 9:07 PM

Umherirrender closed this task as Resolved.

Umherirrender claimed this task.

Umherirrender removed a project: Patch-For-Review.

Maintenance_bot moved this task from In progress to Done on the DBA board.Tue, Jun 11, 9:29 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.10; 2024-06-18).Tue, Jun 11, 10:00 PM

matej_suchanek added a parent task: T341319: RecentChanges: Improve performance of Special:RecentChanges rendering .Wed, Jun 12, 10:06 AM