Page MenuHomePhabricator

Cannot save edits in testwiki with VE: mw.editcheck.findAddedContentNeedingReference is not a function
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open any page, existing or not, on testwiki and load VE (quick link)
  • Make any changes
  • Click "Publish changes"
  • Enter summary
  • Click "Publish changes" in the dialog

What happens?:
The dialog just hangs forever and the following error is logged in the console:

oojs.js:867 Uncaught 
TypeError: mw.editcheck.findAddedContentNeedingReference is not a function
    at ve.init.mw.ArticleTarget.save (ve.init.mw.ArticleTarget.js:1555:21)
    at ve.init.mw.ArticleTarget.startSave (ve.init.mw.ArticleTarget.js:1414:7)
    at ve.init.mw.ArticleTarget.onSaveDialogSave (ve.init.mw.ArticleTarget.js:1403:8)
    at OO.EventEmitter.emit (oojs.js:858:12)
    at ve.ui.MWSaveDialog.js:889:9
    at oojs-ui-windows.js:756:33
    at OO.ui.Process.execute (oojs-ui-windows.js:792:39)
    at OO.ui.Dialog.executeAction (oojs-ui-windows.js:2926:41)
    at OO.ui.ProcessDialog.executeAction (oojs-ui-windows.js:3473:59)
    at OO.ui.Dialog.onActionClick (oojs-ui-windows.js:2745:8)

What should have happened instead?:
The edit should go through.

Other information (browser name/version, screenshots, etc.):
Seems to be caused by r1010703, which removed the mw.editcheck.findAddedContentNeedingReference method, which is however still used in ve.init.mw.ArticleTarget.js.

Event Timeline

VPuffetMichel lowered the priority of this task from Unbreak Now! to Needs Triage.Tue, Jun 18, 8:29 PM
VPuffetMichel triaged this task as Unbreak Now! priority.
VPuffetMichel added a project: Editing-team.

Change #1047180 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] findAddedContentNeedingReference was removed accidentally

https://gerrit.wikimedia.org/r/1047180

We accidentally removed mw.editcheck.findAddedContentNeedingReference while refactoring in the edit check API patch. That patch quickly re-exposes the information we need to keep the tagging working.

Change #1047180 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] findAddedContentNeedingReference was removed accidentally

https://gerrit.wikimedia.org/r/1047180

Change #1047188 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.43.0-wmf.10] findAddedContentNeedingReference was removed accidentally

https://gerrit.wikimedia.org/r/1047188

Change #1047188 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.43.0-wmf.10] findAddedContentNeedingReference was removed accidentally

https://gerrit.wikimedia.org/r/1047188

Mentioned in SAL (#wikimedia-operations) [2024-06-18T23:05:31Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:1047077|Use isEnumType in selector and isCustomEnum for creating literals (T367159)]], [[gerrit:1047188|findAddedContentNeedingReference was removed accidentally (T367920)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-18T23:10:15Z] <jforrester@deploy1002> jforrester, kemayo: Backport for [[gerrit:1047077|Use isEnumType in selector and isCustomEnum for creating literals (T367159)]], [[gerrit:1047188|findAddedContentNeedingReference was removed accidentally (T367920)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-18T23:22:47Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:1047077|Use isEnumType in selector and isCustomEnum for creating literals (T367159)]], [[gerrit:1047188|findAddedContentNeedingReference was removed accidentally (T367920)]] (duration: 17m 16s)

Jdforrester-WMF subscribed.

Fix deployed and confirmed working.