Special:Notifications (partially?) broken
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Nikerabbit
	Thu, Jun 20, 10:21 AM

Description

Steps to replicate the issue (include links if applicable):

Visit https://www.mediawiki.org/wiki/Special:Notifications
Open JavaScript console

What happens?:

jquery.js?12e87:3793 Uncaught TypeError: Cannot convert undefined or null to object
    at Function.assign (<anonymous>)
    at new MwEchoUiReadStateButtonSelectWidget (mw.echo.ui.ReadStateButtonSelectWidget.js?7ec51:13:67)
    at new MwEchoUiNotificationsInboxWidget (mw.echo.ui.NotificationsInboxWidget.js?a5fb2:74:32)
    at HTMLDocument.<anonymous> (ext.echo.special.js?40764:35:32)
    at mightThrow (jquery.js?12e87:3489:29)
    at process (jquery.js?12e87:3557:12)

What should have happened instead?:
No error. Notifications should load.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	Fix Special:Notifications	mediawiki/extensions/Echo	wmf/1.43.0-wmf.10	+1 -1
	Fix Special:Notifications	mediawiki/extensions/Echo	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T368102: jquery.textSelection behavior changed when given `undefined` in command options
Mentioned Here: T368102: jquery.textSelection behavior changed when given `undefined` in command options

Event Timeline

Nikerabbit created this task.Thu, Jun 20, 10:21 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptThu, Jun 20, 10:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Nikerabbit added a parent task: T361404: 1.43.0-wmf.10 deployment blockers.Thu, Jun 20, 10:21 AM

Git bisect suggests that this was caused by build: Update eslint-config-wikimedia to 0.28.2 and autofix. Pinging @Esanders. Though I'm not yet sure what exactly in there is the problem.

Yep, caused by this change in particular: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/1043088/2/modules/ui/mw.echo.ui.ReadStateButtonSelectWidget.js

Object.assign fails when the first argument is undefined, but $.extend doesn't.

Should be easy enough to fix.

Change #1047943 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Echo@master] Fix Special:Notifications

https://gerrit.wikimedia.org/r/1047943

gerritbot added a project: Patch-For-Review.Thu, Jun 20, 10:52 AM

Fairly visible bug, but not a train blocker, as wmf.10 is already deployed to all Wikimedia projects.

Urbanecm_WMF assigned this task to Michael.Thu, Jun 20, 11:36 AM

Urbanecm_WMF removed a parent task: T361404: 1.43.0-wmf.10 deployment blockers.

Urbanecm_WMF edited projects, added Growth-Team (Sprint 16 (Growth Team)); removed Growth-Team.

Restricted Application added a project: User-Michael. · View Herald TranscriptThu, Jun 20, 11:36 AM

Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 16 (Growth Team)) board.Thu, Jun 20, 11:37 AM

Change #1047955 had a related patch set uploaded (by Urbanecm; author: Michael Große):

[mediawiki/extensions/Echo@wmf/1.43.0-wmf.10] Fix Special:Notifications

https://gerrit.wikimedia.org/r/1047955

Change #1047943 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Fix Special:Notifications

https://gerrit.wikimedia.org/r/1047943

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Thu, Jun 20, 1:00 PM

Special:Notificaitons page is fixed on beta.

Change #1047955 merged by jenkins-bot:

[mediawiki/extensions/Echo@wmf/1.43.0-wmf.10] Fix Special:Notifications

https://gerrit.wikimedia.org/r/1047955

Mentioned in SAL (#wikimedia-operations) [2024-06-20T16:05:56Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap: Backport for [[gerrit:1047955|Fix Special:Notifications (T368029)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-20T16:10:23Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 lucaswerkmeister-wmde, urbanecm: Backport for [[gerrit:1047955|Fix Special:Notifications (T368029)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-20T16:18:17Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1047955|Fix Special:Notifications (T368029)]] (duration: 12m 21s)