Personally, I prefer option 1, because it leaves the admin in control. If the admin wants to enter a page that does not exist yet, they should be able to do so (they can do that anyway by a manual edit, and I don't see why the UI should mask that approach). If we're afraid that the admin might do so by accident (and introduce typos), we might want to introduce a warning for that scenario, but it doesn't look like something that should be fundamentally impossible.

While it is true that non-existing pages might not always be what the client extension anticipates, it is a situation each extension needs to safeguard against anyway. This is because we store page titles as strings (as opposed to the page IDs), which means the configuration does not follow page renames. So, I do not consider this to be a problem any of those options could solve – rather, having a non-existent page is something that can happen at any point, without the configuration ever changing.

In addition to adding (very limited) support for deleted pages, option 1 also enables the admins to use links that are known (to MediaWiki) but non-existing. For example, avk.wikipedia uses mw:Special:MyLanguage/Help:VisualEditor/User guide as part of their links. As of now, CommunityConfiguration only allows those links to be replaced with a local one – any attempts to change the external link (at MediaWiki.org) will lead to an accidental blanking, unless someone edits the JSON directly.

That being said...I'm curious what do others think about this. @Michael @Sgs @KStoller-WMF @Trizek-WMF @Pppery, do you have any opinion on what solution we should take here?

I wonder if adding required support both on the server and client would not be good enough until the upstream T362650: Lookup: address usability issues is done. Where required on the client should sensibly mean: "having actually selected something" and not accept an empty string.

That being said, I think I prefer both option 2 and option 3. That is, as I wrote on that task, my intuitively preferred outcome would be a combination of "automatically highlight the first menu item to be selected on focus lost" + "Lookup looks different if 1) actively being edited without selection, 2) with selected item, 3) with input but no selected item and no focus anymore".

In T371228#10022317, @Michael wrote:

I wonder if adding required support both on the server and client would not be good enough until the upstream T362650: Lookup: address usability issues is done. Where required on the client should sensibly mean: "having actually selected something" and not accept an empty string.

Maybe I'm missing something, but I do not understand how would required support fix the problem. In the F56763482 video, the editor produced the following blob for the link:

{
	"title": "",
	"text": "Write a Wikipedia article using the right style",
	"id": "EditingHelp"
}

In this blob, all of the three keys are present (title, text and id), but one of them (title) does not have the expected value. Since we now have array management in the editor, it might make sense to set minimum-length of the title to 1, requiring it to be non-empty. That might be an acceptable stop-gap solution if we want to rely on the solution provided by upstream/DST.

In T371228#10022356, @Urbanecm_WMF wrote:

In T371228#10022317, @Michael wrote:

I wonder if adding required support both on the server and client would not be good enough until the upstream T362650: Lookup: address usability issues is done. Where required on the client should sensibly mean: "having actually selected something" and not accept an empty string.

Maybe I'm missing something, but I do not understand how would required support fix the problem. In the F56763482 video, the editor produced the following blob for the link:

{
	"title": "",
	"text": "Write a Wikipedia article using the right style",
	"id": "EditingHelp"
}

In this blob, all of the three keys are present (title, text and id), but one of them (title) does not have the expected value. Since we now have array management in the editor, it might make sense to set minimum-length of the title to 1, requiring it to be non-empty. That might be an acceptable stop-gap solution if we want to rely on the solution provided by upstream/DST.

Emphasizing the following:

Where required on the client should sensibly mean: "having actually selected something" and not accept an empty string.

That being said, with respect to server-side configuration, I agree with:

it might make sense to set minimum-length of the title to 1

However, I did not actually manage to make that work in practice. Is it somewhere documented how

					self::REF => [
						'class' => MediaWikiDefinitions::class, 'field' => 'PageTitle'
					]

actually works, in detail?

I don't understand how the accident happened, but I feel that any solution that both:

• asks the user to check on the page title when the target is changed,
• keeps whatever is in the label field (even if wrong).

would be fine.

The goal is to prevent new accidents.

We can also rely on admins knowing that a page title and a label aren't the same thing; plus they are supposed to match.

In T371228#10022407, @Michael wrote:

Is it somewhere documented how

					self::REF => [
						'class' => MediaWikiDefinitions::class, 'field' => 'PageTitle'
					]

actually works, in detail?

It wasn't, but I added some details to https://www.mediawiki.org/wiki/Extension:CommunityConfiguration/Technical_documentation#Building_the_schema. I'm happy to expand what I wrote based on your feedback.

What happened was that I was reordering the help links, and changed my mind about what order to put them in several times. Since there's no way to reorder elements in the CommunityConfiguration UI, I did that by copying and pasting the title from one help link to another.

Probably any of the options would have kept me from making that mistake, but Option 1 was how I expected the form to work - the UI makes it look like just a text field with no communication that it isn't anywhere. And the UI pattern of a text with an optional dropdown is seen in many other places, like the Special:Contributions form, whereas since I have never needed to use partial blocks anywhere (as an enwiki admin I promised to stay away from blocking, and I never was a fan of partial blocks' existence in the first place) I never knew how that worked.

Based on Pppery's feedback, and given that the Community Configuration form is only edited by highly trusted editors, it seems like option 1 is a reasonable approach.

@Urbanecm_WMF - Just so I'm clear, is the hope that Growth deploys a short term improvement for the Community Configuration form, but that long-term the underlying component issue is being addressed by Design Systems?
T362650: Lookup: address usability issues

In T371228#10025650, @KStoller-WMF wrote:

@Urbanecm_WMF - Just so I'm clear, is the hope that Growth deploys a short term improvement for the Community Configuration form, but that long-term the underlying component issue is being addressed by Design Systems?
T362650: Lookup: address usability issues

We don't really know :). This task's purpose is to figure out what we want to happen on our end (what's the desired approach at the end). It looks like DST is in initial stages of figuring out what to change (if anything). It would probably be helpful to chime in on that conversation, and figure out whether any changes are to be expected from DST, and if so, whether we need to change anything on our end as well.

Would you be able to help with figuring that out, or would it be preferable if an engineer did something to move things forward here?

Mentioned in SAL (#wikimedia-operations) [2024-08-28T12:19:50Z] <MichaelG_WMF> T371228 running mwscript --wiki testwiki ./extensions/CommunityConfiguration/maintenance/setVersionData.php HelpPanel 1.0.0

Mentioned in SAL (#wikimedia-operations) [2024-08-28T12:23:49Z] <MichaelG_WMF> T371228 running foreachwikiindblist growthexperiments ./extensions/CommunityConfiguration/maintenance/setVersionData.php HelpPanel 1.0.0

Change #1057222 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(help panel schema): Require title and text keys to be present

https://gerrit.wikimedia.org/r/1057222