Page MenuHomePhabricator

Provide a centralized solution for links in colored tables in dark mode
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

Many projects have added a CSS rule that detects a background color applied via an inline style and changes links in those tables to black with an underline. Since this has proved useful and popular this rule should be upstreamed so all projects can use it. This will speed up roll out of dark mode to anons on various projects.

User story

AS an anon user on a wiki with few technical editors, I want dark mode quicker!

Requirements

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Sign off

QA Results - PROD

ACStatusDetails
1Pass per T371411#10142447

Event Timeline

Jdlrobson renamed this task from Provide a centralized solution for links in colored tables to Provide a centralized solution for links in colored tables in dark mode.Jul 30 2024, 7:21 PM
Jdlrobson triaged this task as High priority.

Change #1068884 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/WikimediaMessages@master] Improve dark mode link styling in tables, infobox

https://gerrit.wikimedia.org/r/1068884

Change #1068884 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Improve dark mode link styling in tables, infobox

https://gerrit.wikimedia.org/r/1068884

@Izno this is live in case you didn't see. It has support for mw-selflink and more. I'd recommend dropping those styles in https://en.wikipedia.org/w/index.php?title=MediaWiki:Vector-2022.css and https://en.wikipedia.org/w/index.php?title=MediaWiki:Minerva.css

Not totally certain if you're proposing removing the entirety in the local or just the blocks that somewhat cleanly correspond to the upstream. Downstream has some color alterations that support both self links and new links (both of the latter I added a day or three ago).

@Izno yes removing the code in Minerva.css and Vector-2022.css - it is being overridden.

WikimediaMessage messages code for reference: https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/blob/master/modules/ext.wikimediamessages.styles/theme-night.less#L13C1-L28C2

The new selector doesn't target infobox and navboxes. It does still override red links in tables to black (but I'm not 100% attached to that - it's just a choice between inaccessible red links or styling them differently in an unfamiliar way - e.g. italized).

Jdlrobson updated Other Assignee, added: bwang.

Change #1071709 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaMessages@master] Apply link color change to tables styled via style tags as well

https://gerrit.wikimedia.org/r/1071709

Jdlrobson updated Other Assignee, added: Jdlrobson; removed: bwang.

Change #1071709 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Apply link to tables styled via style tags as well and distinguish red links

https://gerrit.wikimedia.org/r/1071709

Jdlrobson added a subscriber: bwang.

Hey @Edtadros I can take QA on this one in production.

@Izno for reference this is the only CSS you should need now (https://es.wikipedia.org/wiki/MediaWiki:Vector-2022.css). I'll make sure to tidy up wikis after the deploy Thursday per the sign off step I've added to this task.

All done here. Wikis have been updated to reflect the new code.