Page MenuHomePhabricator
Create Task
Maniphest T372077

Logstash: Cannot read properties of undefined (reading 'source')
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Description

Around 260 instances in past 24 hrs

Single document - https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-default-1-7.0.0-1-2024.08.08?id=xCrAMpEB0bw1V4rv0qYG

stack trace

	at setup  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:490:850
at jt  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:872:309
at https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:907:358
at https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:907:514
at M  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:907:537
at F  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:905:898
at v  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:903:38
at Z  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:913:978
at mount  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:895:219
at t.mount  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.CodeMirror.v6.lib%7Cext.cx.entrypoints.newbytranslation%7Cjquery%2Coojs-ui-core%2Cvue%7Cjquery.ui%7Cmw.cx.util%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=c7scr:995:871

Details

SubjectRepoBranchLines +/-
CX NewByTranslationPopup: Add check to avoid "TypeError"mediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Event Timeline

bwang created this task.Aug 8 2024, 4:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2024, 4:41 PM
Izno added a project: Wikimedia-Logstash.Aug 8 2024, 5:08 PM
Aklapper removed a project: Wikimedia-Logstash.Aug 11 2024, 1:13 PM
Aklapper added a subscriber: Izno.

@Izno: I don't see how this is an issue with Logstash itself?

Izno unsubscribed.Aug 11 2024, 2:26 PM
Aklapper added projects: ContentTranslation, Wikimedia-production-error.Aug 13 2024, 11:05 AM
Aklapper changed the subtype of this task from "Task" to "Production Error".

@bwang: For future reference, please file these using the production error form/template - thanks!

Offending url: props.suggestion.thumbnail.source comes from line 112 of CX's modules/entrypoints/ext.cx.entrypoints.newbytranslation/NewByTranslationPopup.vue

PWaigi-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.Aug 20 2024, 8:22 AM
ngkountas changed the task status from Open to In Progress.Aug 20 2024, 2:59 PM
ngkountas claimed this task.
ngkountas triaged this task as Medium priority.
ngkountas added projects: LPL Essential (LPL Essential 2024 Jul-Oct), Unplanned-Sprint-Work.
ngkountas moved this task from Sprint Backlog to In Progress on the LPL Essential (LPL Essential 2024 Jul-Oct) board.
gerritbot added a comment.Aug 20 2024, 3:32 PM

Change #1064054 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX NewByTranslationPopup: Add check to avoid "TypeError"

https://gerrit.wikimedia.org/r/1064054

gerritbot added a project: Patch-For-Review.Aug 20 2024, 3:32 PM
ngkountas moved this task from In Progress to Needs Review on the LPL Essential (LPL Essential 2024 Jul-Oct) board.Aug 20 2024, 3:32 PM
gerritbot added a comment.Aug 21 2024, 4:39 AM

Change #1064054 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX NewByTranslationPopup: Add check to avoid "TypeError"

https://gerrit.wikimedia.org/r/1064054

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.20; 2024-08-27).Aug 21 2024, 5:00 AM
thcipriani moved this task from Untriaged to Aug 2024 on the Wikimedia-production-error board.Aug 29 2024, 3:22 PM
abi_ moved this task from Needs Review to Pending Deployment on the LPL Essential (LPL Essential 2024 Jul-Oct) board.Sep 19 2024, 8:26 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 19 2024, 8:30 AM
ngkountas moved this task from Pending Deployment to Need QA on the LPL Essential (LPL Essential 2024 Jul-Oct) board.Sep 20 2024, 4:34 PM
ngkountas added a subscriber: Pginer-WMF.Sep 20 2024, 5:51 PM

The last occurrence of this error was on August 29th, which is the day that the fix has been deployed to group2 wikis. Logstash search: https://logstash.wikimedia.org/app/discover#/?_g=h@7b5aa23&_a=h@9b739dd.

@Pginer-WMF I think we can close this task as done!

Pginer-WMF closed this task as Resolved.Sep 23 2024, 8:18 AM
Pginer-WMF moved this task from Need QA to Done on the LPL Essential (LPL Essential 2024 Jul-Oct) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits