| stjn | |
| Sep 2 2024, 11:27 AM |
| F57401816: image.png | |
| Sep 2 2024, 11:28 AM |
| F57401769: image.png | |
| Sep 2 2024, 11:27 AM |
| F57401753: image.png | |
| Sep 2 2024, 11:27 AM |
Steps to replicate the issue (include links if applicable):
Vector 2010 (default skin in multiple wikis!):
Monobook:
Vector 2022 for comparison:
What happens?:
The popup design was untested in skins other than Vector 2022 and has font size issues. Those issues should be fixed.
cc @Dogu
I'm afraid I fail to see a font size issue in the screenshots... Where (=string in that screenshot) to see a problem, please?
The "36 змін..." line being a bit smaller, or what?
I added Vector 2022 screenshot for comparison, the last line is 11.76px in font size in Vector 2010 while the first two are 18px and 16px. I don't think that was an intentional choice.
I started writing a patch for this...
.skin-vector-legacy .mw-fr-revision-details-dialog .cdx-dialog__body, .skin-monobook .mw-fr-revision-details-dialog .cdx-dialog__body, .skin-timeless .mw-fr-revision-details-dialog .cdx-dialog__body { font-size: 120%; line-height: 150%; }
... but I decided it'd be better to file a ticket in Codex and have them fix it upstream instead. Since this affects multiple skins and I don't think it's intentional since the text is smaller than in their Codex example images at https://doc.wikimedia.org/codex/main/components/demos/dialog.html
The upstream ticket is T373817: Codex Dialog body "font size" and "line height" are too small in old vector, monobook, and timeless
Marking as stalled until that ticket is resolved. Marking as Upstream
This isn't really a regression because this Codex Dialog is new to FlaggedRevs and has never had the bigger font size. I think a regression bug is something that used to work but no longer works.
To be clear, this seems to be explicitly from the inclusion into #contentSub. Maybe the popup should still be there but if it wasn’t, this issue wouldn’t be propping up (though similar ones might be depending on location). Colour is also different on some of your screenshots, for example.
I don't see this as an issue that needs to be fixed upstream in Codex. As @stjn mentions, the styles making the font smaller are coming from where it is in the DOM (specifically, the font-size: 84% is coming from #mw-content-subtitle). If those styles are adjusted or the dialog is moved elsewhere in the DOM structure, the text is the "correct" size.
Anyone got any better ideas to resolve this ticket than the following?
.skin-vector-legacy .mw-fr-revision-details-dialog .cdx-dialog__body, .skin-monobook .mw-fr-revision-details-dialog .cdx-dialog__body, .skin-timeless .mw-fr-revision-details-dialog .cdx-dialog__body { font-size: 120%; line-height: 150%; }
If not I'll code up a patch for that.
Alternatively, would it possible to just move the dialog somewhere else in the DOM so that the unwanted styles are no longer applied?
Better idea would be to put the styles on .mw-fr-revision-details itself (and probably in rem units?) so it doesn’t necessarily gets affected by future Codex changes.
As I’ve outlined in T373769: Rework "Page version status" in FlaggedRevs to be unambiguous about its nature, current Codex-based popup is not really accessible in any way, so reworking it to be accessible (and moving from #contentSub to .mw-indicators in the process) is the actual way to solve this.