Page MenuHomePhabricator

[M] [BUG] Navigation bar layout on iPadOS 18 for watchlist and suggested edits
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. On iPadOS 18, open version 7.5.9.
  2. Tap suggested edits card from Explore, or visit an article, tap watch from overflow menu, then visit watchlist from toast

Expected results

Navigation bar is laid out correctly

Actual results

Navigation bar is too large, and content is hidden underneath

Notably this fixes itself if the device is rotated.

Screenshots

Screenshot 2024-09-23 at 4.52.33 PM (1×766 px, 296 KB)

Screenshot 2024-09-23 at 4.52.49 PM (1×766 px, 312 KB)

Environments observed

App version: 7.5.9 (4078)
OS versions: iPadOS 18
Device model: iPad mini
Device language: EN

Event Timeline

Note: this will also affect Watchlist in it's new location under the Profile menu.
This is a nice-to-have fix for the Navigation Part 1 release, or shortly after.

Tsevener renamed this task from [BUG] Navigation bar layout on iPadOS 18 for watchlist and suggested edits to [M] [BUG] Navigation bar layout on iPadOS 18 for watchlist and suggested edits.Sep 25 2024, 2:23 PM

I see a different weird behavior where the watchlist Navigation (back and filter) moves upwards after I navigate to it: video https://drive.google.com/file/d/1Nk5Ujmry2Bh5vzVZ4U0KFEY51BH-pwO5/view?usp=sharing

Also I noted a bug on the navigating to Watchlist on a different task where when you come back, things disappear, I am not sure if it's due to this one or the Profile menu: https://phabricator.wikimedia.org/T374166#10202945

I see a different weird behavior where the watchlist Navigation (back and filter) moves upwards after I navigate to it: video

Yeah, unfortunately I couldn't fix that little jump. It's related to the way our custom navigation bar from Explore/Article interacts with the Watchlist view, which was built using the system navigation bar. In iPadOS18 Apple made changes to the navigation bar to incorporate their floating tab bar, which caused issues with a lot of the transitions from older views using custom navigation bar.

I did try to add the custom navigation bar into Watchlist just now, and it's not laying out correctly and I don't think it would be a quick effort. The better place to put that time in is to wrap up our system navigation bar tech debt (T363606). The prototype branch has this transition fixed:

https://drive.google.com/file/d/1jvwB4RC1cwaeNR2u0RIxBWp04Y1ArKTh/view?usp=sharing

Also I noted a bug on the navigating to Watchlist on a different task where when you come back, things disappear, I am not sure if it's due to this one or the Profile menu:

I think this is an unrelated bug, so we can look into it as a part of the other task.

Sounds good, thanks @Tsevener - good to know the jump will be fixed when we do the system navigation bar tech debt.