Maniphest T375760

update-views cookbook doesn't handle filters correctly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	fnegri
	Sep 26 2024, 2:31 PM

Tags

Referenced Files

None

Subscribers

Description

if --filter is omitted, the cookbook fails because it passes None to the maintain-views script
filtering by database is not possible because the script always adds --all-databases

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	update-views: improve filter handling	operations/cookbooks	master	+18 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
					Restricted Task
		Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
		Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
		Resolved		Niharika	T324492 Temporary accounts - MVP
		Resolved		Madalina	T326816 [Epic] Update features for temporary accounts
		Open		None	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
		Resolved		Dreamy_Jazz	T368949 [Epic] Implement global autoblocks from global user blocks
		Resolved		Dreamy_Jazz	T374859 Globally autoblock the user's IP address when User::spreadAnyEditBlock is called
		Resolved		Dreamy_Jazz	T374853 Update the GlobalBlockManager service to support global autoblocks
		Resolved		fnegri	T371486 Hide the value of gb_address column in public replicas if gb_autoblock_parent_id is not null
		Resolved		fnegri	T375760 update-views cookbook doesn't handle filters correctly

Event Timeline

fnegri created this task.Sep 26 2024, 2:31 PM

Change #1075928 had a related patch set uploaded (by FNegri; author: FNegri):

[operations/cookbooks@master] update-views: improve filter handling

https://gerrit.wikimedia.org/r/1075928

gerritbot added a project: Patch-For-Review.Sep 26 2024, 2:31 PM

fnegri triaged this task as Medium priority.Sep 26 2024, 2:52 PM

fnegri moved this task from Backlog to In progress on the cloud-services-team (FY2024/2025-Q1-Q2) board.

JJMC89 moved this task from Backlog to Wiki replicas on the Data-Services board.Sep 26 2024, 2:53 PM

Change #1075928 merged by jenkins-bot:

[operations/cookbooks@master] update-views: improve filter handling

https://gerrit.wikimedia.org/r/1075928

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2024, 4:31 PM

fnegri closed this task as Resolved.Sep 26 2024, 4:34 PM

fnegri moved this task from In progress to Done on the cloud-services-team (FY2024/2025-Q1-Q2) board.