Page MenuHomePhabricator
Create Task
Maniphest T374853

Update the GlobalBlockManager service to support global autoblocks
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The GlobalBlockManager service needs to be updated to support managing global autoblocks. This includes:

  • Marking a block as being able to cause autoblocks
  • Creating, updating and removing global autoblocks
  • Retroactively autoblocking using IPs acquired from the hook added in T374850

Details

SubjectRepoBranchLines +/-
Retroactively autoblock IPs when globally blockingmediawiki/extensions/GlobalBlockingmaster+228 -4
Add wgGlobalBlockingEnableAutoblocksmediawiki/extensions/GlobalBlockingmaster+20 -0
Create GlobalBlock::newFromRowmediawiki/extensions/GlobalBlockingmaster+33 -33
Add GlobalBlockManager::autoblockmediawiki/extensions/GlobalBlockingmaster+331 -10
Add GlobalBlockLookup::getAutoblockReasonmediawiki/extensions/GlobalBlockingmaster+144 -4
Update GlobalBlockManager::block to allow code to enable autoblocksmediawiki/extensions/GlobalBlockingmaster+157 -44
Define wgGlobalBlockingEnableAutoblocks as falseoperations/mediawiki-configmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Sep 16 2024, 2:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2024, 2:33 PM
Dreamy_Jazz added a subtask: T374850: Add hook to get IPs to retroactively globally auto block.Sep 16 2024, 2:34 PM
Dreamy_Jazz added a subtask: T374855: Hide the value of gbw_address in the public replicas if the associated globalblocks table row has gb_autoblock_parent_id as not null.Sep 16 2024, 3:03 PM
Dreamy_Jazz added a parent task: T374859: Globally autoblock the user's IP address when User::spreadAnyEditBlock is called.
Dreamy_Jazz added a subtask: T371486: Hide the value of gb_address column in public replicas if gb_autoblock_parent_id is not null.
Dreamy_Jazz closed subtask T374855: Hide the value of gbw_address in the public replicas if the associated globalblocks table row has gb_autoblock_parent_id as not null as Declined.Sep 17 2024, 11:43 AM
Dreamy_Jazz added a subtask: T374945: Stop writing to gbw_address and gbw_target_central_id.Sep 17 2024, 12:30 PM
Dreamy_Jazz removed a subtask: T374937: Drop gbw_address and gbw_target_central_id from the global_block_whitelist table.Sep 17 2024, 6:27 PM
Dreamy_Jazz closed subtask T374850: Add hook to get IPs to retroactively globally auto block as Resolved.Sep 19 2024, 10:52 AM
Dreamy_Jazz mentioned this in T374945: Stop writing to gbw_address and gbw_target_central_id.Sep 23 2024, 1:36 PM
Dreamy_Jazz removed a subtask: T374945: Stop writing to gbw_address and gbw_target_central_id.Sep 23 2024, 2:36 PM
kostajh moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Sep 24 2024, 8:34 AM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 26 2024, 2:31 PM
Dreamy_Jazz set the point value for this task to 2.
fnegri closed subtask T371486: Hide the value of gb_address column in public replicas if gb_autoblock_parent_id is not null as Resolved.Sep 26 2024, 4:46 PM
gerritbot added a comment.Oct 4 2024, 11:47 AM

Change #1077939 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Update GlobalBlockManager for global autoblocks

https://gerrit.wikimedia.org/r/1077939

gerritbot added a project: Patch-For-Review.Oct 4 2024, 11:47 AM
gerritbot added a comment.Oct 4 2024, 2:17 PM

Change #1077963 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockManager::block to allow code to enable autoblocks

https://gerrit.wikimedia.org/r/1077963

Dreamy_Jazz moved this task from Sprint Beatboxing (Sept 16-27) to Sprint Cello (Oct 7 - 18) on the Trust and Safety Product Sprint board.Oct 8 2024, 10:29 AM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)); removed Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.
gerritbot added a comment.Oct 8 2024, 12:48 PM

Change #1078655 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Add GlobalBlockLookup::getAutoblockReason

https://gerrit.wikimedia.org/r/1078655

gerritbot added a comment.Oct 8 2024, 4:16 PM

Change #1078710 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Add wgGlobalBlockingEnableAutoblocks

https://gerrit.wikimedia.org/r/1078710

gerritbot added a comment.Oct 8 2024, 4:36 PM

Change #1078713 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Define wgGlobalBlockingEnableAutoblocks as false

https://gerrit.wikimedia.org/r/1078713

gerritbot added a comment.Oct 8 2024, 4:41 PM

Change #1078713 merged by jenkins-bot:

[operations/mediawiki-config@master] Define wgGlobalBlockingEnableAutoblocks as false

https://gerrit.wikimedia.org/r/1078713

Stashbot added a comment.Oct 8 2024, 4:42 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-08T16:42:24Z] <dreamyjazz@deploy2002> Started scap sync-world: Backport for [[gerrit:1078713|Define wgGlobalBlockingEnableAutoblocks as false (T374853)]], [[gerrit:1078712|Remove wgGlobalBlockingAllowGlobalAccountBlocks as unused]]

Stashbot added a comment.Oct 8 2024, 4:44 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-08T16:44:36Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:1078713|Define wgGlobalBlockingEnableAutoblocks as false (T374853)]], [[gerrit:1078712|Remove wgGlobalBlockingAllowGlobalAccountBlocks as unused]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Oct 8 2024, 4:49 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-08T16:49:15Z] <dreamyjazz@deploy2002> Finished scap sync-world: Backport for [[gerrit:1078713|Define wgGlobalBlockingEnableAutoblocks as false (T374853)]], [[gerrit:1078712|Remove wgGlobalBlockingAllowGlobalAccountBlocks as unused]] (duration: 06m 50s)

gerritbot added a comment.Oct 8 2024, 6:02 PM

Change #1078723 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Retroactively autoblock IPs when globally blocking

https://gerrit.wikimedia.org/r/1078723

gerritbot added a comment.Oct 10 2024, 11:29 AM

Change #1079247 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlock::newFromRow

https://gerrit.wikimedia.org/r/1079247

gerritbot added a comment.Oct 10 2024, 12:23 PM

Change #1077963 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockManager::block to allow code to enable autoblocks

https://gerrit.wikimedia.org/r/1077963

gerritbot added a comment.Oct 10 2024, 12:23 PM

Change #1078655 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Add GlobalBlockLookup::getAutoblockReason

https://gerrit.wikimedia.org/r/1078655

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.27; 2024-10-15).Oct 10 2024, 1:00 PM
gerritbot added a comment.Oct 10 2024, 1:01 PM

Change #1077939 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Add GlobalBlockManager::autoblock

https://gerrit.wikimedia.org/r/1077939

gerritbot added a comment.Oct 10 2024, 1:55 PM

Change #1078710 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Add wgGlobalBlockingEnableAutoblocks

https://gerrit.wikimedia.org/r/1078710

gerritbot added a comment.Oct 10 2024, 1:55 PM

Change #1079247 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlock::newFromRow

https://gerrit.wikimedia.org/r/1079247

gerritbot added a comment.Oct 16 2024, 12:23 PM

Change #1078723 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Retroactively autoblock IPs when globally blocking

https://gerrit.wikimedia.org/r/1078723

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2024, 12:30 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.28; 2024-10-22); removed MW-1.43-notes (1.43.0-wmf.27; 2024-10-15).Oct 16 2024, 1:01 PM
Dreamy_Jazz updated the task description. (Show Details)Oct 16 2024, 8:24 PM

This will be QA'd through other tickets, such as T376993: Allow Special:GlobalBlock to manage whether a global account block causes global autoblocks.

Dreamy_Jazz closed this task as Resolved.Oct 16 2024, 8:25 PM
Dreamy_Jazz moved this task from Needs review to Done on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits