Page MenuHomePhabricator
Create Task
Maniphest T375787

Cookie-based feature flag for SUL3
Closed, ResolvedPublic
Actions

Description

SUL3 (T348388: Use central login wiki for login (SUL3)) is currently available on Beta behind a query parameter based feature flag, which isn't really useful for testing. We should have a cookie-based opt-in.

Details

SubjectRepoBranchLines +/-
[beta-cluster] Enable cookie-based SUL3 feature flagoperations/mediawiki-configmaster+2 -2
SharedDomainUtils: Add cookie-based SUL3 activation mechanismmediawiki/extensions/CentralAuthmaster+30 -6
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT345245 Mitigate phase-out of third-party cookies across in Wikimedia production
 OpenNoneT345249 Mitigate phase-out of third-party cookies in CentralAuth
 OpenNoneT348388 Use central login wiki for login (SUL3)
 OpenNoneT362713 Implement the new login process which redirects to the central login wiki for showing the login/signup form
 DeclinedNoneT363411 Run cancreateaccount checks in the context of another wiki
 ResolvedDAlangi_WMFT363483 Split CentralAuth primary authentication provider into loginwiki and non-loginwiki version
 ResolvedDAlangi_WMFT369650 Tokenize sensitive parameters in SUL3 URLs
 DeclinedNoneT364862 Render central login page with customizations from starting wiki
 ResolvedTgrT363699 Determine and implement SUL 3 login handshake mechanism
 OpenNoneT369467 SUL3: Consider adding interstitial when the user is already logged in centrally
 ResolvedDAlangi_WMFT369668 Figure out how to handle "remember me" flag in SUL3 login flow
 OpenNoneT372703 Set central session ID on the local wiki during SUL3 login
 ResolvedPRODUCTION ERRORTgrT373507 TypeError: Argument 1 passed to MediaWiki\Extension\CentralAuth\CentralAuthTokenManager::consume() must be of the type string, null given
 StalledNoneT364866 Adapt to changes in post-login/signup hooks after switching to a central login wiki
 OpenTgrT369180 Ensure no AuthenticationRequests are added to the local login flow in SUL3 mode
 ResolvedPRODUCTION ERRORTgrT373504 Wikimedia\NormalizedException\NormalizedException: Authentication failed because of inconsistent provider array
 ResolvedDAlangi_WMFT370810 Forward "campaign" parameter during SUL3 account creation
 ResolvedDAlangi_WMFT370813 Support signup mode in SUL3 local login
 In ProgressDAlangi_WMFT375788 Implement SUL3 central autologin
 In ProgressDAlangi_WMFT376488 Implement SUL3 central login for temp users
 DuplicateNoneT377141 Enable SUL3 central login for temporary accounts
 In ProgressDAlangi_WMFT375796 Synchronize SUL2 and SUL3 central browser state
 OpenJTweed-WMFT375954 Create SUL 3 rollout plan for Wikimedia production
 ResolvedDAlangi_WMFT375787 Cookie-based feature flag for SUL3
 OpenNoneT377142 Improve code quality for SUL3 shared domain logic

Event Timeline

Tgr created this task.Sep 26 2024, 5:47 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptSep 26 2024, 5:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr added a parent task: T348388: Use central login wiki for login (SUL3).Sep 26 2024, 5:48 PM
Tgr added a parent task: T375788: Implement SUL3 central autologin.Sep 26 2024, 5:50 PM
DAlangi_WMF changed the task status from Open to In Progress.Sep 27 2024, 8:59 AM
DAlangi_WMF claimed this task.
DAlangi_WMF triaged this task as Medium priority.
DAlangi_WMF moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
gerritbot added a comment.Sep 27 2024, 11:47 AM

Change #1076186 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] SharedDomainUtils: Add cookie-based SUL3 activation mechanism

https://gerrit.wikimedia.org/r/1076186

gerritbot added a project: Patch-For-Review.Sep 27 2024, 11:47 AM
gerritbot added a comment.Sep 27 2024, 12:01 PM

Change #1076195 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[operations/mediawiki-config@master] [beta-cluster] Enable cookie-based SUL3 feature flag

https://gerrit.wikimedia.org/r/1076195

Tgr edited parent tasks, added: T375954: Create SUL 3 rollout plan for Wikimedia production; removed: T348388: Use central login wiki for login (SUL3).Sep 28 2024, 11:50 AM
Tgr moved this task from Backlog to In progress on the SUL3 board.Sep 30 2024, 8:48 AM
gerritbot added a comment.Sep 30 2024, 1:54 PM

Change #1076186 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SharedDomainUtils: Add cookie-based SUL3 activation mechanism

https://gerrit.wikimedia.org/r/1076186

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.25; 2024-10-01).Sep 30 2024, 2:00 PM
gerritbot added a comment.Oct 1 2024, 12:02 PM

Change #1076195 merged by jenkins-bot:

[operations/mediawiki-config@master] [beta-cluster] Enable cookie-based SUL3 feature flag

https://gerrit.wikimedia.org/r/1076195

DAlangi_WMF closed this task as Resolved.Oct 1 2024, 12:23 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 1 2024, 12:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits