Page MenuHomePhabricator
Create Task
Maniphest T376359

[wmf.25 - regression] mobile - watch star disappears when clicked
Open, HighPublic2 Estimated Story Points
Actions

Description

Steps:

  1. On mobile go to a wmf.25 wiki - e.g. testwiki, cawiki.
  2. On a random page, click on the star to add a page to your Watchlist.

What happened:

  • when the Watch star is clicked - it "disappears":

Screen Shot 2024-10-02 at 6.01.33 PM.png (1×910 px, 124 KB)

  • when you are on a page that was added to your Watchlist, the Watch star icon is not visible.

Screen Shot 2024-10-02 at 6.06.16 PM.png (1×884 px, 167 KB)

watch the animated gif:
watch star disappear.gif (537×431 px, 48 KB)

Event Timeline

Etonkovidova created this task.Thu, Oct 3, 1:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Oct 3, 1:09 AM
ovasileva triaged this task as High priority.Thu, Oct 3, 11:28 AM
ovasileva edited projects, added Web-Team-Backlog (FY2024-25 Q2 Sprint 2); removed Web-Team-Backlog.
ovasileva edited projects, added Web-Team-Backlog (FY2024-25 Q2 Sprint 1); removed Web-Team-Backlog (FY2024-25 Q2 Sprint 2).
Jdlrobson added a parent task: T376394: [Tracking] Fix the remaining issues relating to Minerva link change..Thu, Oct 3, 2:46 PM
ovasileva removed a parent task: T376394: [Tracking] Fix the remaining issues relating to Minerva link change..Thu, Oct 3, 5:33 PM
ovasileva set the point value for this task to 2.
bwang subscribed.Thu, Oct 3, 5:34 PM

Has to do with the unstar progressive icon not being available. probably was introduced with the codex icon change in minerva. not related to the minerva link change

SToyofuku-WMF moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.Thu, Oct 3, 5:35 PM
Jdlrobson added a comment.Thu, Oct 3, 5:42 PM

This should be using the class minerva-icon--unStar instead of minerva-icon--unStar--progressive which is present and a background-color: @color-progressive

ovasileva moved this task from Ready for Development to Needs analysis on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.Thu, Oct 3, 5:59 PM
Jdlrobson added a project: Web Team Essential Work 2024 (Adoption of Codex for icons).Thu, Oct 3, 6:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits