[wmf.25 - regression] mobile - watch star disappears when clicked
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Etonkovidova
	Oct 3 2024, 1:09 AM

Description

Steps:

On mobile go to a wmf.25 wiki - e.g. testwiki, cawiki.
On a random page, click on the star to add a page to your Watchlist.

What happened:

when the Watch star is clicked - it "disappears":

Screen Shot 2024-10-02 at 6.01.33 PM.png (1×910 px, 124 KB)

when you are on a page that was added to your Watchlist, the Watch star icon is not visible.

Screen Shot 2024-10-02 at 6.06.16 PM.png (1×884 px, 167 KB)

watch the animated gif:

watch star disappear.gif (537×431 px, 48 KB)

Derived Requirement

Ensure that the Watch star icon remains visible after a page is added to the Watchlist when using a mobile device on a wmf.25 wiki.

BDD

Feature: Watchlist Star Icon Visibility on Mobile

Scenario: Ensure the Watch star remains visible after adding a page to the Watchlist

Given the user is on a random page on a wmf.25 wiki using a mobile device
When the user clicks the Watch star to add the page to their Watchlist
Then the Watch star icon should remain visible, indicating that the page has been added to the Watchlist

Test Steps

Test Case 1: Ensure Watch Star Icon Remains Visible After Adding Page to Watchlist

Open a wmf.25 wiki (e.g., testwiki or cawiki) on a mobile device.
Navigate to a random page.
Click on the Watch star icon to add the page to your Watchlist.
AC1: Confirm that the Watch star icon remains visible after the page is added to the Watchlist, rather than disappearing.

QA Results - Beta

AC	Status	Details
1	✅	T376359#10207838

QA Results - Prod

AC	Status	Details
1	✅	T376359#10232135

Details

	Subject	Repo	Branch	Lines +/-
	Fixes Watchstar display when clicked	mediawiki/skins/MinervaNeue	master	+10 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T374145 Migrate ResourceLoader Icons in Minerva to use Codex
		Resolved		ovasileva	T376359 [wmf.25 - regression] mobile - watch star disappears when clicked

Event Timeline

Etonkovidova created this task.Oct 3 2024, 1:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2024, 1:09 AM

ovasileva triaged this task as High priority.Oct 3 2024, 11:28 AM

ovasileva edited projects, added Web-Team-Backlog (FY2024-25 Q2 Sprint 2); removed Web-Team-Backlog.

ovasileva edited projects, added Web-Team-Backlog (FY2024-25 Q2 Sprint 1); removed Web-Team-Backlog (FY2024-25 Q2 Sprint 2).

Jdlrobson added a parent task: T376394: [Tracking] Fix the remaining issues relating to Minerva link change..Oct 3 2024, 2:46 PM

ovasileva removed a parent task: T376394: [Tracking] Fix the remaining issues relating to Minerva link change..Oct 3 2024, 5:33 PM

ovasileva set the point value for this task to 2.

Has to do with the unstar progressive icon not being available. probably was introduced with the codex icon change in minerva. not related to the minerva link change

SToyofuku-WMF moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.Oct 3 2024, 5:35 PM

This should be using the class minerva-icon--unStar instead of minerva-icon--unStar--progressive which is present and a background-color: @color-progressive

ovasileva moved this task from Ready for Development to Needs analysis on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.Oct 3 2024, 5:59 PM

Jdlrobson added a project: Web Team Essential Work 2024 (Adoption of Codex for icons and links).Oct 3 2024, 6:11 PM

Jdlrobson added a parent task: T374145: Migrate ResourceLoader Icons in Minerva to use Codex.Oct 4 2024, 7:10 PM

Jdlrobson moved this task from Needs analysis to Doing on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.Oct 4 2024, 7:13 PM

Change #1078002 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fixes Watchstar display when clicked

https://gerrit.wikimedia.org/r/1078002

gerritbot added a project: Patch-For-Review.Oct 4 2024, 7:14 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.Oct 4 2024, 7:14 PM

Change #1078002 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fixes Watchstar display when clicked

https://gerrit.wikimedia.org/r/1078002

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.26; 2024-10-08).Oct 7 2024, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2024, 2:30 PM

bwang assigned this task to Edtadros.Oct 7 2024, 4:18 PM

bwang moved this task from Code Review to QA on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.

GMikesell-WMF claimed this task.Oct 7 2024, 5:50 PM

GMikesell-WMF updated Other Assignee, added: Edtadros.

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF added subscribers: Edtadros, GMikesell-WMF.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 15.0
Browser: Chrome 129
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://en.m.wikipedia.beta.wmflabs.org/wiki/Lightsaber

Test Steps

Test Case 1: Ensure Watch Star Icon Remains Visible After Adding Page to Watchlist

Open a Beta wmf.25 wiki (e.g., testwiki or cawiki for PROD) on a mobile device.
Navigate to a random page.
Click on the Watch star icon to add the page to your Watchlist.
✅ AC1: Confirm that the Watch star icon remains visible after the page is added to the Watchlist, rather than disappearing.

Beta stays while Test.Wiki watchlist icon disappears. This will be fixed on the next patch for Test.Wiki

Gif

Beta	Current Test.Wiki

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Oct 7 2024, 6:30 PM

GMikesell-WMF updated Other Assignee, removed: Edtadros.

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.Oct 7 2024, 6:34 PM

Looks good, thanks @GMikesell-WMF!

Edtadros mentioned this in T375670: Verify 1.43.0-wmf.26 deployment.Oct 13 2024, 2:02 AM

Test Result - Prod

Status: ✅ PASS
Environment: cawiki
OS: macOS Sequoia 15.0
Browser: Chrome 129
Device: MS
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Watch Star Icon Remains Visible After Adding Page to Watchlist

Open a Beta wmf.25 wiki (e.g., testwiki or cawiki for PROD) on a mobile device.
Navigate to a random page.
Click on the Watch star icon to add the page to your Watchlist.
✅ AC1: Confirm that the Watch star icon remains visible after the page is added to the Watchlist, rather than disappearing.