Page MenuHomePhabricator

Permalink warning is not styled in non-V22 skin
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The message "This is an old revision of this page" at the top is not styled. Running mw.loader.load('codex-styles') makes it styled.

What should have happened instead?:
The message is styled from the beginning.

Requirement

Ensure that the permalink warning message “This is an old revision of this page” is properly styled from the start in non-Vector 2022 skins. The message should be styled without requiring additional scripts such as mw.loader.load(‘codex-styles’).

BDD

Feature: Correct styling for permalink warning in non-V22 skins

Scenario: Styling of permalink warning in non-V22 skin
    Given the user is viewing an old revision of a page in a non-V22 skin
    When the "This is an old revision of this page" message is displayed
    Then the message should be styled properly without additional script loading.

Test Steps

Test Case 1: Verify styling of permalink warning in non-V22 skins

  1. Open https://en.wikipedia.org/w/index.php?title=Main_Page&oldid=1225257602&useskin=vector&safemode=1.
  2. Look for the “This is an old revision of this page” message at the top of the page.
  3. AC1: Confirm that the message is styled without manually loading additional scripts like mw.loader.load(‘codex-styles’).

https://phabricator.wikimedia.org/T376848#10257228

QA Results - Prod

ACStatusDetails
1T376848#10257228

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
CCiufo-WMF moved this task from Inbox to Triaging on the Design-System-Team board.
CCiufo-WMF subscribed.

I'm not sure why the styles aren't being loaded in this case. @Jdlrobson any ideas?

Change #1079316 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Include message box styles on old revisions

https://gerrit.wikimedia.org/r/1079316

Our generic logic only applies to content - not message boxes in subtitle.

Change #1079316 merged by jenkins-bot:

[mediawiki/core@master] Include message box styles on old revisions

https://gerrit.wikimedia.org/r/1079316

matmarex assigned this task to Jdlrobson.
matmarex removed a project: Patch-For-Review.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS
Browser: Chrome
Device: MS
Emulated Device: NA

Test Artifact(s):

Test Case 1: Verify styling of permalink warning in non-V22 skins

  1. Open https://en.wikipedia.org/w/index.php?title=Main_Page&oldid=1225257602&useskin=vector&safemode=1.
  2. Look for the “This is an old revision of this page” message at the top of the page.
  3. ✅AC1: Confirm that the message is styled without manually loading additional scripts like mw.loader.load(‘codex-styles’).

It looks styled correctly. Running mw.loader.load('codex-styles')didn't change anything.

screenshot 117.png (520×1 px, 218 KB)