Page MenuHomePhabricator

PHP Deprecated: Use of ChangeTags::getDisplayTableName was deprecated in MediaWiki 1.41. [Called from MediaWiki\Extension\Translate\RecentChangesTranslationFilterHookHandler::MediaWiki\Extension\Translate\{closure}]
Open, In Progress, LowPublic2 Estimated Story PointsPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of ChangeTags::getDisplayTableName was deprecated in MediaWiki 1.41. [Called from MediaWiki\Extension\Translate\RecentChangesTranslationFilterHookHandler::MediaWiki\Extension\Translate\{closure}]
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.2/extensions/Translate/src/RecentChangesTranslationFilterHookHandler.php(221)
#0[internal function]MWExceptionHandler::handleError(int, string, string, string, array)
#1/srv/mediawiki/php-1.44.0-wmf.2/includes/debug/MWDebug.php(385)trigger_error(string, int)
#2/srv/mediawiki/php-1.44.0-wmf.2/includes/debug/MWDebug.php(356)MediaWiki\Debug\MWDebug::sendRawDeprecated(string, bool, string)
#3/srv/mediawiki/php-1.44.0-wmf.2/includes/debug/MWDebug.php(237)MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, int)
#4/srv/mediawiki/php-1.44.0-wmf.2/includes/GlobalFunctions.php(773)MediaWiki\Debug\MWDebug::deprecated(string, string, string, int)
#5/srv/mediawiki/php-1.44.0-wmf.2/includes/changetags/ChangeTags.php(710)wfDeprecated(string, string)
#6/srv/mediawiki/php-1.44.0-wmf.2/extensions/Translate/src/RecentChangesTranslationFilterHookHandler.php(221)ChangeTags::getDisplayTableName()
#7/srv/mediawiki/php-1.44.0-wmf.2/includes/recentchanges/ChangesListStringOptionsFilterGroup.php(207)MediaWiki\Extension\Translate\RecentChangesTranslationFilterHookHandler->MediaWiki\Extension\Translate\{closure}(string, MediaWiki\Context\RequestContext, Wikimedia\Rdbms\DBConnRef, array, array, array, array, array, array)
#8/srv/mediawiki/php-1.44.0-wmf.2/includes/specialpage/ChangesListSpecialPage.php(1517)ChangesListStringOptionsFilterGroup->modifyQuery(Wikimedia\Rdbms\DBConnRef, MediaWiki\Specials\SpecialWatchlist, array, array, array, array, array, MediaWiki\Html\FormOptions, bool)
#9/srv/mediawiki/php-1.44.0-wmf.2/includes/specialpage/ChangesListSpecialPage.php(998)MediaWiki\SpecialPage\ChangesListSpecialPage->buildQuery(array, array, array, array, array, MediaWiki\Html\FormOptions)
#10/srv/mediawiki/php-1.44.0-wmf.2/includes/specialpage/ChangesListSpecialPage.php(676)MediaWiki\SpecialPage\ChangesListSpecialPage->getRows()
#11/srv/mediawiki/php-1.44.0-wmf.2/includes/specials/SpecialWatchlist.php(171)MediaWiki\SpecialPage\ChangesListSpecialPage->execute(null)
#12/srv/mediawiki/php-1.44.0-wmf.2/includes/specialpage/SpecialPage.php(728)MediaWiki\Specials\SpecialWatchlist->execute(null)
#13/srv/mediawiki/php-1.44.0-wmf.2/includes/specialpage/SpecialPageFactory.php(1726)MediaWiki\SpecialPage\SpecialPage->run(null)
#14/srv/mediawiki/php-1.44.0-wmf.2/includes/actions/ActionEntryPoint.php(504)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#15/srv/mediawiki/php-1.44.0-wmf.2/includes/actions/ActionEntryPoint.php(146)MediaWiki\Actions\ActionEntryPoint->performRequest()
#16/srv/mediawiki/php-1.44.0-wmf.2/includes/MediaWikiEntryPoint.php(200)MediaWiki\Actions\ActionEntryPoint->execute()
#17/srv/mediawiki/php-1.44.0-wmf.2/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#18/srv/mediawiki/w/index.php(3)require(string)
#19{main}
Notes

Warnings caused by code calling deprecated method. The issue already existed and was surfaced in 1.44.0-wmf.2 by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1080417

As of group1, only mediawiki and commons seem affected

Event Timeline

Oops, sorry, I accidentally dropped getDisplayTableName() from the query for code to fix. One moment!

Change #1088299 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Translate@master] RecentChangesTranslationFilterHookHandler: Replace call to deprecated ChangeTags::getDisplayTableName()

https://gerrit.wikimedia.org/r/1088299

Change #1088317 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] RecentChangesFilter: Remove usage of ChangeTags::getDisplayTableName

https://gerrit.wikimedia.org/r/1088317

Change #1088299 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] RecentChangesTranslationFilterHookHandler: Replace call to deprecated ChangeTags::getDisplayTableName()

https://gerrit.wikimedia.org/r/1088299

Change #1088329 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Translate@wmf/1.44.0-wmf.2] RecentChangesTranslationFilterHookHandler: Replace call to deprecated ChangeTags::getDisplayTableName()

https://gerrit.wikimedia.org/r/1088329

Nikerabbit lowered the priority of this task from High to Low.Nov 7 2024, 5:48 PM

@Jdforrester-WMF's patch avoids the log spam. We're exploring if we can make the code better in another patch.

Nikerabbit changed the task status from Open to In Progress.Nov 11 2024, 7:52 AM
abi_ removed abi_ as the assignee of this task.Nov 12 2024, 4:45 AM

I'm not working on this currently.